-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(components/tabs): update tab #759 #808
Conversation
ZurabDev
commented
Oct 11, 2023
- fix(components/tabs): update tab [BUG] @prizm-ui/components - PrizmTabsComponent отдаёт неверный индекс вкладки #759
Visit the preview URL for this PR (updated for commit f95545f): https://prizm-v3--pr808-feat-tabs-update-tab-qquxk9w3.web.app (expires Wed, 18 Oct 2023 12:45:26 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 6cf3db9b3e1bf46180849c1db2e28221d0904ddf |
Visit the preview URL for this PR (updated for commit f95545f): https://prizm-v2--pr808-feat-tabs-update-tab-ihfss5w0.web.app (expires Wed, 18 Oct 2023 12:47:03 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: ab7e21e23e82e687a92ac5a830ac2768df6e61b5 |
Visit the preview URL for this PR (updated for commit 5ce66be): https://prizm-v1--pr808-feat-tabs-update-tab-djmr47aa.web.app (expires Wed, 18 Oct 2023 12:47:37 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 3f40bac4652dbd13be483e7e4de02de469ed4b3f |
вот можно проверять, обновил последний пример для вывода active idx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
в примере по умолчанию active index = 0
жму на кнопочку открытия дропдауна
первый таб визуально теряет свой active state (перестает быть синим)
закрываю дропдаун
ФР:меняется active index на =1 и active state появляется у таба 2
ОР: открытие и закрытие дропдауна с табами не должно влиять на активный таб и приводить к переключению на другой таб
libs/components/src/lib/components/tabs/components/tab.component.ts
Outdated
Show resolved
Hide resolved
libs/components/src/lib/components/tabs/components/tab.component.ts
Outdated
Show resolved
Hide resolved
…nt.ts Co-authored-by: ickisIckis <darinafjordur@gmail.com>
…nt.ts Co-authored-by: ickisIckis <darinafjordur@gmail.com>