Skip to content
This repository has been archived by the owner on Jan 3, 2019. It is now read-only.

It seams that kind of a keyList is missing as the first argument of your off method. #2

Closed
mathiasprinz opened this issue Apr 17, 2013 · 3 comments
Assignees

Comments

@mathiasprinz
Copy link

Hi,
I have tried to unbind an event from a key with .off() like you told me inside your documentation: a.off('error', myErrorHandler) )
But nothing happens. I look inside your nice code and it seams, that the off method
doesn't support unbinding callbacks for only a special key? If I pass the function as first
argument a.off(myErrorHandler) it will be removed but I think for all keys.

Thanks allot

quaelin pushed a commit that referenced this issue Apr 17, 2013
@quaelin
Copy link
Contributor

quaelin commented Apr 17, 2013

Currently, it only works for all keys, as you say. I have fixed the documentation to reflect this. I will leave this issue open, however, because the ability to remove a listener only for specific key(s) is a nice feature so I'll try to implement that soon.

@ghost ghost assigned quaelin Apr 17, 2013
@mathiasprinz
Copy link
Author

I also think that this will improve atom. Thanks allot.
Also for the fast answer.

quaelin pushed a commit that referenced this issue Apr 21, 2013
@quaelin quaelin closed this as completed Apr 21, 2013
@mathiasprinz
Copy link
Author

Well done! Tanks allot.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants