Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parser is broken for arguments with parenthesis #68

Closed
ratijas opened this issue Sep 15, 2021 · 5 comments · Fixed by #71
Closed

Parser is broken for arguments with parenthesis #68

ratijas opened this issue Sep 15, 2021 · 5 comments · Fixed by #71

Comments

@ratijas
Copy link
Contributor

ratijas commented Sep 15, 2021

Parser is broken for arguments with parenthesis.

See example below. At the end of the first line, syntax highlighting engine returns to the global main context.

Qt6/qtdeclarative/src/qml/CMakeLists.txt:

qt_internal_extend_target(Qml CONDITION MSVC AND (TEST_architecture_arch STREQUAL "i386")
    LINK_OPTIONS
        "/BASE:0x66000000"
)

qt_internal_extend_target(Qml CONDITION MSVC
    DEFINES
        _CRT_SECURE_NO_WARNINGS
)

Example

Version

Sublime Text: Build 4113
Sublime-CMakeLists: 1.2.0

@rwols
Copy link
Collaborator

rwols commented Sep 15, 2021

@arcturus140 do you want to tackle this?

@arcturus140
Copy link
Contributor

Thank you for reporting this. I can replicate it on ST3.

I'll take care of it, but the following days i am occupied with other tasks. I expect to get to this next week.

@ratijas
Copy link
Contributor Author

ratijas commented Sep 17, 2021

Is there any reason left to stick to ST3? o_O

@arcturus140
Copy link
Contributor

ST4 provides mechanisms that allow backward compatibility with ST3

@ratijas
Copy link
Contributor Author

ratijas commented Sep 18, 2021

ST4 provides mechanisms that allow backward compatibility with ST3

Yes, there is one. Yet, why would you live with it? That's the question.

ratijas added a commit to ratijas/Sublime-CMakeLists that referenced this issue Feb 21, 2023
There's a lot of such code in Qt and KDE world.

Fixes zyxar#68
ratijas added a commit to ratijas/Sublime-CMakeLists that referenced this issue Feb 21, 2023
There's a lot of such code in Qt and KDE world.

Fixes zyxar#68
@rwols rwols closed this as completed in #71 Feb 21, 2023
rwols pushed a commit that referenced this issue Feb 21, 2023
There's a lot of such code in Qt and KDE world.

Fixes #68
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants