Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved package names for payload and rest, more granular bus topics to ma... #200

Merged
merged 1 commit into from May 17, 2013

Conversation

zznate
Copy link
Owner

@zznate zznate commented May 17, 2013

...tch packages. Closes #142

edwardcapriolo added a commit that referenced this pull request May 17, 2013
Moved package names for payload and rest, more granular bus topics to ma...
@edwardcapriolo edwardcapriolo merged commit 76275cf into master May 17, 2013
@edwardcapriolo
Copy link
Collaborator

Can you follow up...

  • public void handleRequestAsync(final HttpServerRequest request, Buffer buffer) {
  • IntraReq req = new IntraReq();
  • if (request.method.equals("GET")) {
  •  handleGet(request, buffer, req);
    
  • } else if (request.method.equals("POST")) {
  •  handlePost(request, buffer, req);
    
  • } else if (request.method.equals("DELETE")) {
  •  handleDelete(request, buffer, req);
    
  • } else if (request.method.equals("PUT")) {
  •  handlePut(request, buffer, req);
    
  • }
  • delegateAndReply(request, req);
  • }

@edwardcapriolo
Copy link
Collaborator

No majick strings on the happy path

@zznate
Copy link
Owner Author

zznate commented May 17, 2013

Yep - got some notes on that and a few other cleanups

@zznate zznate deleted the handler-rename-refactor branch May 17, 2013 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move refactor IntraHandlerJson to extend IntraHandlerBase
2 participants