Add raise/raiseload relationship loading strategy #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
tests huh? this is serious ! :) nice job. let me add a BB issue to get this in. |
- available via `lazy='raise'` or by setting the `raiseload` strategy via `options()` - behaves almost like `lazy='noload'`, but instead of returning `None` it raises `InvalidRequestError` - based on code from Mike Bayer that was posted to the sqlalchemy mailing list: https://groups.google.com/forum/#!topic/sqlalchemy/X_wA8K97smE
ThiefMaster
force-pushed
the
noload-raise-strategy
branch
from
24f2f71
to
6d334da
Compare
|
Dear contributor - This pull request is being moved to Gerrit, at https://gerrit.sqlalchemy.org/35, where it may be tested and reviewed more closely. As such, the pull request itself is being marked "closed" or "declined", however your contribution is merely being moved to our central review system. Please register at https://gerrit.sqlalchemy.org#/register/ to send and receive comments regarding this item. |
zzzeek
added a commit
that referenced
this pull request
Apr 19, 2016
Fixes: #3512 Co-Authored-By: Mike Bayer <mike_mp@zzzcomputing.com> Change-Id: Ibd126c50eda621e2f4120ee378f7313af2d7ec3c Pull-request: #193
This was referenced Nov 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lazy='raise'or by setting theraiseloadstrategyvia
options()lazy='noload', but instead of returningNoneit raises
InvalidRequestErrormailing list: https://groups.google.com/forum/#!topic/sqlalchemy/X_wA8K97smE
I've also added docs and a changelog entry. Not sure if 1.0.9 is the proper version for it, but since it's a minor feature which does not touch any existing functionality it seems like a safe thing to add in a minor version.