Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config: read defaults from app config #23

Closed
jirikuncar opened this issue Mar 29, 2017 · 2 comments · Fixed by #24
Closed

config: read defaults from app config #23

jirikuncar opened this issue Mar 29, 2017 · 2 comments · Fixed by #24
Assignees
@jirikuncar

Comments

@jirikuncar
Copy link
Collaborator

Investigate possibility to read default configuration from app.config if not arguments are given to Gravatar constructor.

--
see https://github.com/zzzsochi/Flask-Gravatar/blob/master/flask_gravatar/__init__.py#L47-L67
@zzzsochi
Copy link
Owner

Sorry, last two months was get out from my brain. :-)

If you want this feature — you do. I don't have time for this.

@jirikuncar jirikuncar reopened this May 16, 2017
@jirikuncar
Copy link
Collaborator Author

I will prepare a PR.

@jirikuncar jirikuncar self-assigned this May 16, 2017
jirikuncar added a commit to jirikuncar/Flask-Gravatar that referenced this issue May 16, 2017
@jirikuncar
config: read defaults from app config
a59731b 
* Try to read configuration values from application config if a context
  is available otherwise return an instance config or extension default.
  (closes zzzsochi#23)
@jirikuncar jirikuncar mentioned this issue May 16, 2017
Merged
jirikuncar added a commit to jirikuncar/Flask-Gravatar that referenced this issue May 16, 2017
@jirikuncar
config: read defaults from app config
15823e9 
* Try to read configuration values from application config if a context
  is available otherwise return an instance config or extension default.
  (closes zzzsochi#23)
jirikuncar added a commit to jirikuncar/Flask-Gravatar that referenced this issue May 16, 2017
@jirikuncar
config: read defaults from app config
6c5cae3 
* Try to read configuration values from application config if a context
  is available otherwise return an instance config or extension default.
  (closes zzzsochi#23)
jirikuncar added a commit to jirikuncar/Flask-Gravatar that referenced this issue May 16, 2017
@jirikuncar
config: read defaults from app config
ae454bf 
* Try to read configuration values from application config if a context
  is available otherwise return an instance config or extension default.
  (closes zzzsochi#23)
zzzsochi pushed a commit that referenced this issue May 16, 2017
@jirikuncar @zzzsochi
config: read defaults from app config
4c03450 
* Try to read configuration values from application config if a context
  is available otherwise return an instance config or extension default.
  (closes #23)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jirikuncar jirikuncar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

config: read defaults from app config jirikuncar/Flask-Gravatar
2 participants
@jirikuncar @zzzsochi