Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config: read defaults from app config #24

Merged
merged 1 commit into from May 16, 2017
Merged

config: read defaults from app config #24

merged 1 commit into from May 16, 2017

Conversation

jirikuncar
Copy link
Collaborator

@jirikuncar jirikuncar requested a review from zzzsochi May 16, 2017 07:23
zzzsochi
zzzsochi requested changes May 16, 2017
View reviewed changes
Copy link
Owner

@zzzsochi zzzsochi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are broken. Fix it! :-)

@jirikuncar
Copy link
Collaborator Author

@zzzsochi do you just agree with the general strategy?

@zzzsochi
Copy link
Owner

Yes. Good code.

@jirikuncar
Copy link
Collaborator Author

@zzzsochi I have added new tests and fixed the kwargs problem.

@jirikuncar
config: read defaults from app config
ae454bf 
* Try to read configuration values from application config if a context
  is available otherwise return an instance config or extension default.
  (closes zzzsochi#23)
@coveralls
Copy link

coveralls commented May 16, 2017 •
edited

Coverage Status

Coverage remained the same at 100.0% when pulling 6c5cae3 on jirikuncar:23 into ac17207 on zzzsochi:master.

@coveralls
Copy link

coveralls commented May 16, 2017 •
edited

Coverage Status

Coverage remained the same at 100.0% when pulling ae454bf on jirikuncar:23 into ac17207 on zzzsochi:master.

@coveralls
Copy link

coveralls commented May 16, 2017 •
edited

Coverage Status

Coverage remained the same at 100.0% when pulling ae454bf on jirikuncar:23 into ac17207 on zzzsochi:master.

@zzzsochi zzzsochi merged commit 4c03450 into zzzsochi:master May 16, 2017
@jirikuncar jirikuncar deleted the 23 branch May 16, 2017 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zzzsochi zzzsochi zzzsochi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

config: read defaults from app config
3 participants
@jirikuncar @zzzsochi @coveralls