-
Notifications
You must be signed in to change notification settings - Fork 183
docs(api): liquid classes in 8.5 #18619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many comments on liquid_classes.rst
. We can work through these early next week and then move on to the other modified files.
merging with upstream chore_release-8.5.0
…quid-classes-in-8.5.0 merging remote changes with local
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## chore_release-8.5.0 #18619 +/- ##
=======================================================
- Coverage 24.08% 22.59% -1.50%
=======================================================
Files 3265 3258 -7
Lines 282662 281767 -895
Branches 29924 29872 -52
=======================================================
- Hits 68079 63659 -4420
- Misses 214558 218083 +3525
Partials 25 25
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
9230147
to
42f66a2
Compare
…s/opentrons into liquid-classes-in-8.5.0 merging
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed the Complex Commands pages. Biggest systematic change would be if we decided to not use the term "basic". As I read through, I realized that you use the term passim and it could be a pain to change every instance. So I would suggest focusing on rewording only the instances of "basic complex" back-to-back, which are fewer.
…nd meniscus-relative shoutout
…s/opentrons into liquid-classes-in-8.5.0 rebased and merging
ed843ad
to
53c8f05
Compare
…s/opentrons into liquid-classes-in-8.5.0
Co-authored-by: Ed Cormany <edward.cormany@opentrons.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the persistent work to put together this huge docs PR for a huge new feature. Everything looks really solid and should give our users a solid basis for understanding liquid classes. I'm sure there will be additions and corrections in the future, but this is good to go for now!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really great! Thanks for the hard work @emilyburghardt (and all the reviewers too)!! The graphics look so cool @jacksonseidenberg!
The only important thing I think missing is that none of the Liquid classes articles link to the complex commands articles (unless I missed it). So even though there are links to the liquid-class based transfers' API reference, I could not find the details of how to use the new methods until I navigated to the 'Complex Commands' section on my own since I knew where to look.
I think we can add a link to the complex commands page when InstrumentContext.transfer_with_liquid_class()
is introduced in the example in the Liquid Classes article &/or in the API reference for the LC transfer methods. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small question about this: How does this schematic indicate the submerge position? Usually we want users to pick a submerge position that's inside the liquid, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two good callouts here.
@sanni-t I'm totally fine adding a link to the complex commands page. will probably combine this in a PR with another small change I need to make for Caila.
@ddcc4 I think what we mean here is submerge start position. If I'm right, this is just called "submerge position" in the liquid class definition, which is why I left it that way in the table.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh! If that's the submerge start position, then this picture makes sense. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I must have been thinking of "aspiratePosition" and "dispensePosition" when I was looking at this picture, but I guess we don't have pictures for those?
Overview
Liquid classes in API 2.24. Includes new articles covering liquid classes and liquid class definitions, plus changes throughout our Complex Commands section.
Test Plan and Hands on Testing
Changelog
-brought over liquid classes text from PR #17992
get_liquid_class
anddefine_liquid_class
entriesReview requests
Risk assessment