Skip to content

docs(api): liquid classes in 8.5 #18619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 46 commits into from
Jul 3, 2025

Conversation

emilyburghardt
Copy link
Collaborator

@emilyburghardt emilyburghardt commented Jun 12, 2025

Overview

Liquid classes in API 2.24. Includes new articles covering liquid classes and liquid class definitions, plus changes throughout our Complex Commands section.

Test Plan and Hands on Testing

Changelog

-brought over liquid classes text from PR #17992

  • reorganized the liquid classes article to ease into property descriptions
  • build issues with images in the properties table; currently in the docs as a list to avoid this.
  • adding custom liquid class creator section (and differentiate between customizing and creating from scratch)
  • built out liquid class definition tables section
  • updated API reference for tip handling options, get_liquid_class and define_liquid_class entries
  • linked users to github schema for creating their own liquid class

Review requests

Risk assessment

Copy link
Contributor

@ecormany ecormany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many comments on liquid_classes.rst. We can work through these early next week and then move on to the other modified files.

Copy link

codecov bot commented Jun 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 22.59%. Comparing base (011870e) to head (4c8654b).
Report is 1 commits behind head on chore_release-8.5.0.

Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                   @@
##           chore_release-8.5.0   #18619      +/-   ##
=======================================================
- Coverage                24.08%   22.59%   -1.50%     
=======================================================
  Files                     3265     3258       -7     
  Lines                   282662   281767     -895     
  Branches                 29924    29872      -52     
=======================================================
- Hits                     68079    63659    -4420     
- Misses                  214558   218083    +3525     
  Partials                    25       25              
Flag Coverage Δ
protocol-designer 18.70% <ø> (ø)
step-generation 4.32% <ø> (-1.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 133 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@emilyburghardt emilyburghardt force-pushed the liquid-classes-in-8.5.0 branch from 9230147 to 42f66a2 Compare June 24, 2025 22:12
Copy link
Contributor

@ecormany ecormany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the Complex Commands pages. Biggest systematic change would be if we decided to not use the term "basic". As I read through, I realized that you use the term passim and it could be a pain to change every instance. So I would suggest focusing on rewording only the instances of "basic complex" back-to-back, which are fewer.

@emilyburghardt emilyburghardt requested review from a team as code owners June 30, 2025 22:27
@emilyburghardt emilyburghardt requested review from smb2268 and removed request for a team June 30, 2025 22:27
@ecormany ecormany force-pushed the liquid-classes-in-8.5.0 branch from ed843ad to 53c8f05 Compare July 1, 2025 14:26
Copy link
Contributor

@ecormany ecormany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the persistent work to put together this huge docs PR for a huge new feature. Everything looks really solid and should give our users a solid basis for understanding liquid classes. I'm sure there will be additions and corrections in the future, but this is good to go for now!

@emilyburghardt emilyburghardt merged commit 6569b31 into chore_release-8.5.0 Jul 3, 2025
45 checks passed
Copy link
Member

@sanni-t sanni-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really great! Thanks for the hard work @emilyburghardt (and all the reviewers too)!! The graphics look so cool @jacksonseidenberg!

The only important thing I think missing is that none of the Liquid classes articles link to the complex commands articles (unless I missed it). So even though there are links to the liquid-class based transfers' API reference, I could not find the details of how to use the new methods until I navigated to the 'Complex Commands' section on my own since I knew where to look.

I think we can add a link to the complex commands page when InstrumentContext.transfer_with_liquid_class() is introduced in the example in the Liquid Classes article &/or in the API reference for the LC transfer methods. What do you think?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small question about this: How does this schematic indicate the submerge position? Usually we want users to pick a submerge position that's inside the liquid, right?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two good callouts here.

@sanni-t I'm totally fine adding a link to the complex commands page. will probably combine this in a PR with another small change I need to make for Caila.

@ddcc4 I think what we mean here is submerge start position. If I'm right, this is just called "submerge position" in the liquid class definition, which is why I left it that way in the table.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh! If that's the submerge start position, then this picture makes sense. Thanks!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I must have been thinking of "aspiratePosition" and "dispensePosition" when I was looking at this picture, but I guess we don't have pictures for those?

@emilyburghardt emilyburghardt deleted the liquid-classes-in-8.5.0 branch July 7, 2025 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs papi-v2 Python API V2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants