refactor(shared-data, api): require locatingFeaturesAsParent
for module defs
#18645
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Works towards EXEC-77
Overview
In #18628, we wanted to require
locatingFeaturesAsParent
for module definitions, but we couldn't (see comments in PR discussion), so we marked the field as optional and followed up with #18639. Now that the module definition debacle is resolved, we can make the field required as originally intended.Test Plan and Hands on Testing
Changelog
locatingFeaturesAsParent
is required for module definitions.Risk assessment
none, we don't do anything with this field yet