Merge back 'chore_release-pd-8.5.0' into 'edge' #18660
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntinue (#18627) Fixes logic for showing form errors, especially when reopening an errored-out saved form. We previously used a state variable for whether or not to show the form errors, such that they would only show if a user tried to continue/save a form containing an error. After a large error handling [refactor](#18437) was merged, this state was unused, such that errors would show automatically when reopening a form. This PR adds logic to the `makeSingleEditFieldProps` util to show form errors in the following scenarios: 1. the error is due to the field being required, and the form is saved and reopened 2. the error is of any type, the form is pre-saved or saved, and the user attempts to continue or save I also wire up a new optional property of the form error to specify whether or not to show the error upon reopening in scenario 1 above.
Here, we remove the `updatePatchPathField` from `dependentFieldsUpdateMoveLiquid`.
Labware labels are passed through from the protocol api all the way to the commands and eventually the client with little actual _functionality_ dependent on their types or their values. That means that the only thing that checks them is pydantic model validation, and if you avoid that - as the legacy command mapper does by using model_construct() - then other downstream things won't be happy. In this case, OT-2 LPC starts its session by echoing commands it reads from the robot analysis back out to a maintenance run. When a client uses HTTP to create commands, pydantic model validation _does_ run, and it would fail, and this wasn't an anticipated error scenario because, well, it's echoed from the protocol! But the incorrect data made it through. Another way to handle this would be to do pydantic model validation on the protocol inputs, but that would break any old protocols that implicitly depended on this working. Compatibility! Also IMO it's silly that we enforce this if the entire system works just fine if you give it an integer. Closes RESC-423
# Overview We had defined a `pd_step` context manager so that we could group Python commands from the same PD step together, and so that we could emit fields from PD that are not expressible in the Python API (step name, step description, step form parameters, etc.). We were planning to use it like this: ``` with pd_step(name="My Mix Step", description="Mix very well", ...): pipette_left.pick_up_tip() pipette_left.mix(...) ``` However, command annotations serve the same purpose, and command annotations will also provide a context manager for grouping steps. So I'm removing our `pd_step` context manager. Command annotations are not available in the public API yet, but we'll just wait for it and use it when it's available. ## Test Plan and Hands on Testing Updated unit tests. ## Risk assessment Low. Feature has never been released publicly.
Fixes following bugs that i found while testing advanced settings for py interop with consolidate and distribute 1. use correct `fixtureId` for consolidate and distribute blowout location in a trash bin/waste chute 2. cast the `delay.duration` values as numbers to avoid them appearing as strings 3. if dispense destination is a `trash_bin` or `waste_chute` then remove the array 4. `pipetteName` in the custom liquid class definition should be the api pipette name, not the JS pipette name 5. emit `configure_nozzle_layout` for 96-channel full and partial tip support
SyntaxColoring
approved these changes
Jun 17, 2025
) This PR wires up OT-2 default values when creating a new moveLiquid step, including aspirate/dispense submerge/retract speeds and default disposal volumes for multiDispense path transfers. I also refactor the logic for stepping through the moveLiquid step form in attempt to share logic as much as possible for Flex and OT-2 protocol moveLiquid step creation. Lastly, I wire up aspirate/dispense submerge/retract speeds required, as well as remove liquid class compatibility warnings for OT-2.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## edge #18660 +/- ##
===========================================
- Coverage 59.83% 24.12% -35.72%
===========================================
Files 3218 3282 +64
Lines 277818 285236 +7418
Branches 28320 28696 +376
===========================================
- Hits 166244 68808 -97436
- Misses 111388 216403 +105015
+ Partials 186 25 -161
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This picks up our changes in
chore_release-8.5.0andchore_release-pd-8.5.0from the past few days.Will commit this merge at the end-of-day.