Skip to content

fix(app): do not prompt module setup if no instrument is attached #18668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: edge
Choose a base branch
from

Conversation

ahiuchingau
Copy link
Contributor

@ahiuchingau ahiuchingau commented Jun 17, 2025

Overview

We do not want to show the banner prompting user to setup their module unless an instrument is attached. This matches the ODD behavior.
Closes EXEC-1624

@ahiuchingau ahiuchingau requested a review from a team as a code owner June 17, 2025 21:50
@ahiuchingau ahiuchingau requested review from smb2268 and removed request for a team June 17, 2025 21:50
Copy link
Contributor

@CaseyBatten CaseyBatten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wowie zowie. Makes sense to me, don't think we use pipette calibration for any of the module flows.

@vegano1
Copy link
Contributor

vegano1 commented Jun 18, 2025

We do need pipettes for module calibration though, I think this needs to be enforced for specific modules that require calibration like the tempdeck, thermo cycler, etc.

@CaseyBatten
Copy link
Contributor

We do need pipettes for module calibration though, I think this needs to be enforced for specific modules that require calibration like the tempdeck, thermo cycler, etc.

Ah so we'll need to extend the null handling to cover the SECTIONS.PLACE_ADAPTER case as well. Looking through the remaining module wizard flows I don't think there are others that will require this, so the place adapter step followed by the probe attach and detach steps should give coverage.

Copy link
Contributor

@CaseyBatten CaseyBatten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extended comment below regarding remaining coverage needed

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on further feedback we'll need to add coverage on the SECTIONS.PLACE_ADAPTER case on line 218 here because the pipette is also used when probing calibration blocks.

@ahiuchingau ahiuchingau force-pushed the stacker_setup-flow-wont-show-if-no-attached-instruments branch from 5986a90 to 2fd986c Compare June 18, 2025 19:27
@ahiuchingau ahiuchingau changed the title fix(app): render ModuleWizardScreen regardless of a pipette's presence fix(app): do not prompt module setup if no instrument is attached Jun 18, 2025
@ahiuchingau ahiuchingau requested a review from CaseyBatten June 18, 2025 19:29
Copy link

codecov bot commented Jun 18, 2025

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 24.76%. Comparing base (0aeacc6) to head (3719265).
Report is 5 commits behind head on edge.

Files with missing lines Patch % Lines
app/src/molecules/UpdateBanner/index.tsx 0.00% 9 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #18668      +/-   ##
==========================================
- Coverage   24.76%   24.76%   -0.01%     
==========================================
  Files        3284     3284              
  Lines      285457   285462       +5     
  Branches    28663    28661       -2     
==========================================
  Hits        70704    70704              
- Misses     214732   214737       +5     
  Partials       21       21              
Flag Coverage Δ
protocol-designer 19.04% <0.00%> (-0.01%) ⬇️
step-generation 5.25% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
app/src/molecules/UpdateBanner/index.tsx 0.00% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ahiuchingau ahiuchingau force-pushed the stacker_setup-flow-wont-show-if-no-attached-instruments branch from 2fd986c to 3719265 Compare June 20, 2025 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants