-
Notifications
You must be signed in to change notification settings - Fork 184
fix(app): do not prompt module setup if no instrument is attached #18668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: edge
Are you sure you want to change the base?
fix(app): do not prompt module setup if no instrument is attached #18668
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wowie zowie. Makes sense to me, don't think we use pipette calibration for any of the module flows.
We do need pipettes for module calibration though, I think this needs to be enforced for specific modules that require calibration like the tempdeck, thermo cycler, etc. |
Ah so we'll need to extend the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extended comment below regarding remaining coverage needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on further feedback we'll need to add coverage on the SECTIONS.PLACE_ADAPTER
case on line 218 here because the pipette is also used when probing calibration blocks.
5986a90
to
2fd986c
Compare
ModuleWizardScreen
regardless of a pipette's presence
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## edge #18668 +/- ##
==========================================
- Coverage 24.76% 24.76% -0.01%
==========================================
Files 3284 3284
Lines 285457 285462 +5
Branches 28663 28661 -2
==========================================
Hits 70704 70704
- Misses 214732 214737 +5
Partials 21 21
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
2fd986c
to
3719265
Compare
Overview
We do not want to show the banner prompting user to setup their module unless an instrument is attached. This matches the ODD behavior.
Closes EXEC-1624