Skip to content

feat(protocol-designer): add 8.5.0 migration modal #18673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 18, 2025

Conversation

ncdiehl11
Copy link
Collaborator

@ncdiehl11 ncdiehl11 commented Jun 18, 2025

Overview

This PR adds copy for 8.5.0 migration modal and wires it up. It also updates the copy for import confirmation from "Confirm" to "Import", and updates tests accordingly.

Note that much of the logic determining which migration modal to show has been removed and simplified to show the latest migration content.

Closes AUTH-1975

Test Plan and Hands on Testing

  • import a pre-8.5.0 PD protocol and verify that the import modal copy matches that specified on the linked ticket

Review requests

see test plan

Risk assessment

low

This PR adds copy for 8.5.0 migration modal and wires it up. It also updates the copy for import confirmation from "Confirm" to "Import", and updates tests accordingly.

Closes AUTH-1975
Copy link

codecov bot commented Jun 18, 2025

Codecov Report

Attention: Patch coverage is 60.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 24.03%. Comparing base (22cec22) to head (fe134a8).
Report is 2 commits behind head on chore_release-pd-8.5.0.

Files with missing lines Patch % Lines
...onents/organisms/FileUploadMessagesModal/index.tsx 50.00% 6 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                    Coverage Diff                     @@
##           chore_release-pd-8.5.0   #18673      +/-   ##
==========================================================
- Coverage                   24.04%   24.03%   -0.02%     
==========================================================
  Files                        3256     3256              
  Lines                      281502   281383     -119     
  Branches                    28550    28552       +2     
==========================================================
- Hits                        67695    67625      -70     
+ Misses                     213782   213733      -49     
  Partials                       25       25              
Flag Coverage Δ
protocol-designer 19.09% <60.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...onents/organisms/FileUploadMessagesModal/utils.tsx 76.85% <100.00%> (+3.09%) ⬆️
...onents/organisms/FileUploadMessagesModal/index.tsx 73.77% <50.00%> (-6.63%) ⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@@ -226,7 +242,9 @@ export const getMigrationMessage = (
) {
return getNoBehaviorChangeMessage({ t })
}
if (migrationsRan.includes('8.1.0')) {
if (migrationsRan.includes('8.5.0')) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nit here: since the docs will include all the copy from previous migration versions, i believe we can simplify the message to a singular generic message. then update getGenericDidMigrateMessage to return the new copy.

export const getMigrationMessage = (
  props: MigrationMessageProps
): ModalContents => {
  const { t } = props

  return getGenericDidMigrateMessage({ t })
}

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

honestly you can just have the copy directly in getMigrationMessage and remove the getGenericDidMigrateMessage() fn all together

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it, I vastly simplified the migration content logic since we only need to show the latest generic migration copy.

@ncdiehl11 ncdiehl11 marked this pull request as ready for review June 18, 2025 15:55
@ncdiehl11 ncdiehl11 requested a review from a team as a code owner June 18, 2025 15:55
@ncdiehl11 ncdiehl11 removed the request for review from a team June 18, 2025 15:55
Copy link
Collaborator

@jerader jerader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left some clean up nits for the cypress test. after that is addressed, this lgtm!

@ncdiehl11 ncdiehl11 merged commit 30b2dc6 into chore_release-pd-8.5.0 Jun 18, 2025
19 of 20 checks passed
@ncdiehl11 ncdiehl11 deleted the pd_feat-migration-modal-850 branch June 18, 2025 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants