Skip to content

fix(shared-data): Faster ethanol-80 dispense flowrates and delay times after retesting #18675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

andySigler
Copy link
Contributor

@andySigler andySigler commented Jun 18, 2025

Overview

Initial testing was done using 2.0 delay times and flow-rates of 7 and 35. This made the pipetting very slow, which makes it easier to get good CV, but is not ideal for protocol duration. The testing iteratively testing faster flow-rates and delay times to find faster settings that get identical results. The new validated values are in the PR.

Also fixed some mistakes in the blowout parameter flowrate, where the flowrate exceeded the physical possible max speed of the plunger. This is not an issue for robot software, because at runtime it will limit the speed to the max, however in PD this causes an error/warning to pop up (which is great!)

Test Plan and Hands on Testing

Changelog

Review requests

Risk assessment

@andySigler andySigler requested review from sanni-t and jbleon95 June 18, 2025 17:21
@andySigler andySigler requested a review from a team as a code owner June 18, 2025 17:21
@andySigler andySigler changed the base branch from edge to chore_release-8.5.0 June 18, 2025 17:21
Copy link

codecov bot commented Jun 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 25.02%. Comparing base (ec1cfa1) to head (68e79b1).
Report is 1 commits behind head on chore_release-8.5.0.

Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                    @@
##           chore_release-8.5.0   #18675       +/-   ##
========================================================
- Coverage                54.65%   25.02%   -29.63%     
========================================================
  Files                     3258     3257        -1     
  Lines                   281774   278918     -2856     
  Branches                 29494    29204      -290     
========================================================
- Hits                    153999    69813    -84186     
- Misses                  127585   209070    +81485     
+ Partials                   190       35      -155     
Flag Coverage Δ
app 3.20% <ø> (-44.10%) ⬇️
labware-library 4.03% <ø> (+0.06%) ⬆️
opentrons-ai-client 3.17% <ø> (-0.01%) ⬇️
protocol-designer 18.70% <ø> (ø)
shared-data 2.42% <ø> (-70.36%) ⬇️
step-generation 4.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1853 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@andySigler andySigler force-pushed the fix-shared-data-liquid-class-ethanol-faster-delays-and-flowrates branch from 8299ec5 to b4e054f Compare June 20, 2025 15:55
@andySigler andySigler force-pushed the fix-shared-data-liquid-class-ethanol-faster-delays-and-flowrates branch from b4e054f to 68e79b1 Compare June 26, 2025 17:09
@andySigler andySigler requested review from ncdiehl11 and sanni-t June 26, 2025 17:11
@andySigler andySigler merged commit c070dd7 into chore_release-8.5.0 Jun 26, 2025
73 of 74 checks passed
@andySigler andySigler deleted the fix-shared-data-liquid-class-ethanol-faster-delays-and-flowrates branch June 26, 2025 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants