fix(opentrons-ai-client): removed tabs to simplify and fix whitescreen #18687
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Elyorcv |
When user select "Paste from document" tab, state management and type for this tab is not handled properly. This causes infinite loop in the white screen. Instead of solving this, I just removed that tabs thus no need to manage states anymore. This is because me and Mike decided not to use Add individual steps tab. |
koji
reviewed
Jun 20, 2025
| {t('paste_from_document_title')} | ||
| <ControlledTextAreaField | ||
| name={STEPS_FIELD_NAME} | ||
| height="180px" |
There was a problem hiding this comment.
Oops I forget it again! changed to rem Thanks @koji
koji
approved these changes
Jun 20, 2025
Elyorcv
deleted the
AUTH-1973-whitescreen-on-ui-wizard-after-hitting-confirm-button
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Closes AUTH-1973
This PR removes tab to simplify and fix whitescreen issue.
Test Plan and Hands on Testing
CI handles them
Review requests
Follow below:
Risk assessment
Low