e2e tests: Enables should test kubelet managed /etc/hosts file for Windows #124852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
|
/test pull-kubernetes-e2e-capz-windows-master |
k8s-ci-robot
added
do-not-merge/needs-kind
claudiubelu
force-pushed
the
e2e-etc-hosts-test
branch
from
349a871
to
8da49e4
Compare
k8s-ci-robot
added
size/M
|
/test pull-kubernetes-e2e-capz-windows-master |
…ndows We previously skipped this test because Docker did not support mounting individual files in Containers. Since then, support for Docker has been removed, and containerd on Windows supports this feature. We can run this test on Windows.
claudiubelu
force-pushed
the
e2e-etc-hosts-test
branch
from
8da49e4
to
34cab73
Compare
k8s-ci-robot
added
the
area/conformance
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: claudiubelu The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
sig/architecture
claudiubelu
changed the title
k8s-ci-robot
added
release-note-none
claudiubelu
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
/test pull-kubernetes-e2e-capz-windows-master |
bart0sh
reviewed
May 15, 2024
| if framework.NodeOSDistroIs("windows") { | ||
| etcHostsPath = etcHostsPathWindows | ||
| etcHostsOriginalPath = etcHostsOriginalPathWindows | ||
| } |
There was a problem hiding this comment.
Looks good to me, just one nit: can we somehow avoid duplicating this in 3 places?
|
/triage accepted |
k8s-ci-robot
added
triage/accepted
|
/kind failing-test |
k8s-ci-robot
added
kind/failing-test
haircommander
moved this from Triage
to PRs Waiting on Author
in SIG Node CI/Test Board
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind failing-test
/sig testing
/sig windows
What this PR does / why we need it:
We previously skipped this test because Docker did not support mounting individual files in Containers.
Since then, support for Docker has been removed, and containerd on Windows supports this feature. We can run this test on Windows.
Which issue(s) this PR fixes:
Related ##124426
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: