Move dictionary up and down buttons out of kebab menu #971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kuuuube
added
kind/enhancement
jamesmaa
reviewed
May 20, 2024
| @@ -62,6 +62,8 @@ | |||
| </button> | |||
| </div> | |||
| <input type="number" step="1" class="short-height dictionary-priority"> | |||
| <button type="button" class="icon-button" id="dictionary-move-up" data-menu-action="moveUp"><span class="icon-button-inner"><span class="icon" data-icon="up-chevron"></span></span></button> | |||
There was a problem hiding this comment.
Is there alt text that we can add to help confused users?
There was a problem hiding this comment.
If users are getting confused about what up and down arrows do I'm concerned about them.
Due to the size of the arrows we cant really add a "down" label. Could do "Up" and "Dn" maybe.
Yes, it moves the dictionary to number in the list that you input. |
|
Moved dict priority setting under advanced. Expecting this to be merged alongside or after #981. Without that change this ui doesn't make sense. |
jamesmaa
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #981. It doesn't make sense to have this ui unless the dict order sorting works properly.
Repositioning dictionaries is a huge pain right now and requires two button clicks to move a dictionary a single space up. Using
Move to...or having to repeatedly hit the menu button and then move up or down is not a good user experience.Ideally we want something like drag and drop but I think this change helps a bit before we get to that.
Screenshot:
Tested on Firefox, Chromium, Firefox Android, and Kiwi browser.