Fixes incorrect read/write permissions on Flutter.framework and FlutterMacOS.framework #148580

LouiseHsu · 2024-05-17T21:43:29Z

Pre-launch Checklist

I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
I read the [Tree Hygiene] wiki page, which explains my responsibilities.
I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
I signed the [CLA].
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is [test-exempt].
I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
All existing and new tests are passing.

nilsreichardt · 2024-05-19T11:54:39Z

Thanks for the fix! When this fix is merged, can we cherry pick it and release it as a hotfix since many Flutter users are affected and can't publish MacOS apps with Flutter v3.22.0 anymore?

Building Flutter projects on MacOS fails if FlutterMacOS.framwork is read-only (ie. in a Nix environment) #147142
MacOS: Codemagic - The installer package includes files that are only readable by the root user (3.22.0) #148354

jmagman · 2024-05-20T16:44:59Z

packages/flutter_tools/test/host_cross_arch.shard/macos_content_validation_test.dart

+      final File flutterMacOSFramework = fileSystem.file(
+        fileSystem.path.join(
+          outputApp.path,
+          'Contents',
+          'Frameworks',
+          'FlutterMacOS.framework',
+        ),
+      );


outputFlutterFramework is the same thing immediately above, so you should be able to use that. And it's a directory, not a file.

jmagman · 2024-05-20T16:45:46Z

packages/flutter_tools/test/host_cross_arch.shard/ios_content_validation_test.dart

@@ -456,6 +456,19 @@ void main() {
        ],
      );
      expect(appCodesign, const ProcessResultMatcher());
+
+      final File flutterIOSFramework = fileSystem.file(


flutterFramework is already the same thing, you should be able to use that, and it's a directory.

jmagman

LGTM

auto-submit · 2024-05-20T17:22:06Z

auto label is removed for flutter/flutter/148580, due to - The status or check suite Mac_arm64 tool_host_cross_arch_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.

jmagman · 2024-05-20T17:49:05Z

packages/flutter_tools/test/host_cross_arch.shard/ios_content_validation_test.dart

      final String flutterFramework = fileSystem.path.join(
        appBundle.path,
-        'Frameworks',
-        'Flutter.framework',
+        flutterFrameworkDir.path,
        'Flutter',
      );


Shouldn't this be:

final String flutterFramework = fileSystem.path.join( flutterFrameworkDir.path, 'Flutter', );

auto-submit · 2024-05-20T18:30:30Z

auto label is removed for flutter/flutter/148580, due to - The status or check suite Linux tool_integration_tests_4_4 has failed. Please fix the issues identified (or deflake) before re-applying this label.

auto-submit · 2024-05-20T18:41:04Z

auto label is removed for flutter/flutter/148580, due to - The status or check suite Mac tool_integration_tests_4_4 has failed. Please fix the issues identified (or deflake) before re-applying this label.

…erMacOS.framework (flutter#148580) Fixes flutter#148354 Fixes flutter#147142 Closes flutter#147144 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing.

During FlutterMacOS.framework engine universal fat framework creation, make sure the framework is `u=rwx,go=rx` when it's created. There's a framework-side workaround in-flight flutter/flutter#148580. However, this is still a good thing to do engine-side, particularly for add-to-app when they don't go through the `flutter assemble` tooling. I'll also add a test around here, once this rolls https://github.com/flutter/flutter/blob/02a6c91e4d37d28f42c8f8e4d4335b0defed41c1/packages/flutter_tools/test/host_cross_arch.shard/macos_content_validation_test.dart#L30 Fixes flutter/flutter#148354 [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style

… and FlutterMacOS.framework (flutter/flutter#148580)

jmagman · 2024-05-21T16:16:38Z

Thanks for the fix! When this fix is merged, can we cherry pick it and release it as a hotfix since many Flutter users are affected and can't publish MacOS apps with Flutter v3.22.0 anymore?

@nilsreichardt Yes, this will be hotfixed to 3.22. More details at #148354 (comment)

During FlutterMacOS.framework engine universal fat framework creation, make sure the framework is `u=rwx,go=rx` when it's created. There's a framework-side workaround in-flight flutter/flutter#148580. However, this is still a good thing to do engine-side, particularly for add-to-app when they don't go through the `flutter assemble` tooling. I'll also add a test around here, once this rolls https://github.com/flutter/flutter/blob/02a6c91e4d37d28f42c8f8e4d4335b0defed41c1/packages/flutter_tools/test/host_cross_arch.shard/macos_content_validation_test.dart#L30 Fixes flutter/flutter#148354 [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style

nilsreichardt · 2024-05-21T19:11:06Z

@nilsreichardt Yes, this will be hotfixed to 3.22. More details at #148354 (comment)

Thanks, that's awesome <3

flutter/flutter@02a6c91...d02292d 2024-05-21 ian@hixie.ch Make FileSystem dependency explicit througout (more). (flutter/flutter#148095) 2024-05-20 magder@google.com Remove add-to-app bitcode warning (flutter/flutter#148587) 2024-05-20 rmolivares@renzo-olivares.dev SelectionArea's selection should not be cleared on loss of window focus (flutter/flutter#148067) 2024-05-20 katelovett@google.com [wiki migration] Engine team pages (flutter/flutter#148696) 2024-05-20 goderbauer@google.com Manual roll camera dependency (flutter/flutter#148426) 2024-05-20 katelovett@google.com [wiki migration] Framework team pages (flutter/flutter#148721) 2024-05-20 engine-flutter-autoroll@skia.org Roll Flutter Engine from a8fb9daae8d0 to c2ef01f6f1ab (3 revisions) (flutter/flutter#148722) 2024-05-20 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.25.5 to 3.25.6 (flutter/flutter#148715) 2024-05-20 49699333+dependabot[bot]@users.noreply.github.com Bump codecov/codecov-action from 4.4.0 to 4.4.1 (flutter/flutter#148714) 2024-05-20 louisehsu@google.com Fixes incorrect read/write permissions on Flutter.framework and FlutterMacOS.framework (flutter/flutter#148580) 2024-05-20 engine-flutter-autoroll@skia.org Roll Flutter Engine from c6fecf65fbf3 to a8fb9daae8d0 (3 revisions) (flutter/flutter#148700) 2024-05-20 jason-simmons@users.noreply.github.com Remove the no-shuffle tag on the flutter_tools create_test suite (flutter/flutter#148688) 2024-05-20 andrewrkolos@gmail.com log incoming vm service messages in `FlutterVMService::runInView` (flutter/flutter#148596) 2024-05-20 sokolovskyi.konstantin@gmail.com Add tests for shared_app_data.#.dart API examples. (flutter/flutter#147830) 2024-05-20 sokolovskyi.konstantin@gmail.com Add tests for logical_key_set.0.dart API example. (flutter/flutter#147735) 2024-05-20 katelovett@google.com [wiki migration] Ecosystem team pages (flutter/flutter#148589) 2024-05-20 sokolovskyi.konstantin@gmail.com Fix painting API examples tests directories structure. (flutter/flutter#148177) 2024-05-20 102401667+Dimilkalathiya@users.noreply.github.com fixes `CupertinoModalPopupRoute` (flutter/flutter#147823) 2024-05-20 nate.w5687@gmail.com Implement new `AnimationStatus` getters (flutter/flutter#148570) 2024-05-20 nate.w5687@gmail.com Reland "`if` chains â�� `switch` expressions" (flutter/flutter#148634) 2024-05-20 gspencergoog@users.noreply.github.com Factor out `RawView`, make `View` listen to engine generated view focus events (flutter/flutter#143259) 2024-05-20 zanderso@users.noreply.github.com Remove all tests from a02s. Replace with mokey in bringup (flutter/flutter#148563) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC rmistry@google.com,stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…-coder-xu/flutter into fix/slider_text_null_error * 'fix/slider_text_null_error' of https://github.com/hello-coder-xu/flutter: (65 commits) Change implementation method fix slider text null error Make FileSystem dependency explicit througout (more). (flutter#148095) Remove add-to-app bitcode warning (flutter#148587) SelectionArea's selection should not be cleared on loss of window focus (flutter#148067) [wiki migration] Engine team pages (flutter#148696) Manual roll camera dependency (flutter#148426) [wiki migration] Framework team pages (flutter#148721) Roll Flutter Engine from a8fb9daae8d0 to c2ef01f6f1ab (3 revisions) (flutter#148722) Bump github/codeql-action from 3.25.5 to 3.25.6 (flutter#148715) Bump codecov/codecov-action from 4.4.0 to 4.4.1 (flutter#148714) Fixes incorrect read/write permissions on Flutter.framework and FlutterMacOS.framework (flutter#148580) Roll Flutter Engine from c6fecf65fbf3 to a8fb9daae8d0 (3 revisions) (flutter#148700) Remove the no-shuffle tag on the flutter_tools create_test suite (flutter#148688) log incoming vm service messages in `FlutterVMService::runInView` (flutter#148596) Add tests for shared_app_data.#.dart API examples. (flutter#147830) Add tests for logical_key_set.0.dart API example. (flutter#147735) [wiki migration] Ecosystem team pages (flutter#148589) Fix painting API examples tests directories structure. (flutter#148177) fixes `CupertinoModalPopupRoute` (flutter#147823) ...

…r#6778) flutter/flutter@02a6c91...d02292d 2024-05-21 ian@hixie.ch Make FileSystem dependency explicit througout (more). (flutter/flutter#148095) 2024-05-20 magder@google.com Remove add-to-app bitcode warning (flutter/flutter#148587) 2024-05-20 rmolivares@renzo-olivares.dev SelectionArea's selection should not be cleared on loss of window focus (flutter/flutter#148067) 2024-05-20 katelovett@google.com [wiki migration] Engine team pages (flutter/flutter#148696) 2024-05-20 goderbauer@google.com Manual roll camera dependency (flutter/flutter#148426) 2024-05-20 katelovett@google.com [wiki migration] Framework team pages (flutter/flutter#148721) 2024-05-20 engine-flutter-autoroll@skia.org Roll Flutter Engine from a8fb9daae8d0 to c2ef01f6f1ab (3 revisions) (flutter/flutter#148722) 2024-05-20 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.25.5 to 3.25.6 (flutter/flutter#148715) 2024-05-20 49699333+dependabot[bot]@users.noreply.github.com Bump codecov/codecov-action from 4.4.0 to 4.4.1 (flutter/flutter#148714) 2024-05-20 louisehsu@google.com Fixes incorrect read/write permissions on Flutter.framework and FlutterMacOS.framework (flutter/flutter#148580) 2024-05-20 engine-flutter-autoroll@skia.org Roll Flutter Engine from c6fecf65fbf3 to a8fb9daae8d0 (3 revisions) (flutter/flutter#148700) 2024-05-20 jason-simmons@users.noreply.github.com Remove the no-shuffle tag on the flutter_tools create_test suite (flutter/flutter#148688) 2024-05-20 andrewrkolos@gmail.com log incoming vm service messages in `FlutterVMService::runInView` (flutter/flutter#148596) 2024-05-20 sokolovskyi.konstantin@gmail.com Add tests for shared_app_data.#.dart API examples. (flutter/flutter#147830) 2024-05-20 sokolovskyi.konstantin@gmail.com Add tests for logical_key_set.0.dart API example. (flutter/flutter#147735) 2024-05-20 katelovett@google.com [wiki migration] Ecosystem team pages (flutter/flutter#148589) 2024-05-20 sokolovskyi.konstantin@gmail.com Fix painting API examples tests directories structure. (flutter/flutter#148177) 2024-05-20 102401667+Dimilkalathiya@users.noreply.github.com fixes `CupertinoModalPopupRoute` (flutter/flutter#147823) 2024-05-20 nate.w5687@gmail.com Implement new `AnimationStatus` getters (flutter/flutter#148570) 2024-05-20 nate.w5687@gmail.com Reland "`if` chains â�� `switch` expressions" (flutter/flutter#148634) 2024-05-20 gspencergoog@users.noreply.github.com Factor out `RawView`, make `View` listen to engine generated view focus events (flutter/flutter#143259) 2024-05-20 zanderso@users.noreply.github.com Remove all tests from a02s. Replace with mokey in bringup (flutter/flutter#148563) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC rmistry@google.com,stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

nilsreichardt · 2024-05-23T12:58:01Z

Verified that it works with Flutter v3.22.1 👍 See: https://github.com/SharezoneApp/sharezone-app/actions/runs/9207185401/job/25328215964

@itsjustkevin I think this change is missing in the changelog of v3.22.1

jmagman · 2024-05-23T17:48:41Z

@nilsreichardt Thanks for validating! You're right about the changelog, I'll follow up.

Update changelog to include #148580 in the list of fixes.

Update changelog to include flutter#148580 in the list of fixes.

github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label May 17, 2024

LouiseHsu changed the title ~~before tests~~ Fixes incorrect read/write permissions on Flutter.framework and FlutterMacOS.framework May 17, 2024

LouiseHsu marked this pull request as ready for review May 17, 2024 23:33

LouiseHsu requested a review from jmagman May 17, 2024 23:38

nilsreichardt mentioned this pull request May 19, 2024

Fix Flutter project builds under Nix environments on MacOS #147144

Closed

9 tasks

jmagman reviewed May 20, 2024

View reviewed changes

jmagman approved these changes May 20, 2024

View reviewed changes

jmagman added the autosubmit Merge PR when tree becomes green via auto submit App label May 20, 2024

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 20, 2024

jmagman mentioned this pull request May 20, 2024

Update file permissions for FlutterMacOS.framework flutter/engine#52930

Merged

8 tasks

jmagman reviewed May 20, 2024

View reviewed changes

LouiseHsu added the autosubmit Merge PR when tree becomes green via auto submit App label May 20, 2024

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 20, 2024

LouiseHsu added the autosubmit Merge PR when tree becomes green via auto submit App label May 20, 2024

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 20, 2024

github-actions bot added the engine flutter/engine repository. See also e: labels. label May 20, 2024

LouiseHsu force-pushed the fix-read-write-perms-mac branch from ade30ab to bed73fc Compare May 20, 2024 20:57

github-actions bot removed the engine flutter/engine repository. See also e: labels. label May 20, 2024

LouiseHsu added 6 commits May 20, 2024 14:00

before tests

6bc7658

tests

158498e

boop

21bc399

revert test change

c2e60ca

boop

3d38612

.

8a792d2

LouiseHsu force-pushed the fix-read-write-perms-mac branch from bed73fc to 8a792d2 Compare May 20, 2024 21:00

LouiseHsu added the autosubmit Merge PR when tree becomes green via auto submit App label May 20, 2024

LouiseHsu merged commit 185f526 into flutter:master May 20, 2024
130 checks passed

LouiseHsu added the cp: stable cherry pick this pull request to stable release candidate branch label May 20, 2024

engine-flutter-autoroll mentioned this pull request May 21, 2024

Roll Flutter from 02a6c91e4d37 to d02292dbc409 (22 revisions) flutter/packages#6778

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2024

185f526dd Fixes incorrect read/write permissions on Flutter.framework…

7e69896

… and FlutterMacOS.framework (flutter/flutter#148580)

itsjustkevin mentioned this pull request May 23, 2024

Update 3.22.1 release notes to include missing fix. #148999

Merged

itsjustkevin added a commit that referenced this pull request May 30, 2024

Update 3.22.1 release notes to include missing fix. (#148999)

07c256f

Update changelog to include #148580 in the list of fixes.

victorsanni pushed a commit to victorsanni/flutter that referenced this pull request May 31, 2024

Update 3.22.1 release notes to include missing fix. (flutter#148999)

1f54f43

Update changelog to include flutter#148580 in the list of fixes.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixes incorrect read/write permissions on Flutter.framework and FlutterMacOS.framework #148580

Fixes incorrect read/write permissions on Flutter.framework and FlutterMacOS.framework #148580

LouiseHsu commented May 17, 2024 •

edited by jmagman

nilsreichardt commented May 19, 2024

jmagman May 20, 2024

jmagman May 20, 2024

jmagman left a comment

auto-submit bot commented May 20, 2024

jmagman May 20, 2024 •

edited

auto-submit bot commented May 20, 2024

auto-submit bot commented May 20, 2024

jmagman commented May 21, 2024

nilsreichardt commented May 21, 2024

nilsreichardt commented May 23, 2024 •

edited

jmagman commented May 23, 2024

Fixes incorrect read/write permissions on Flutter.framework and FlutterMacOS.framework #148580

Fixes incorrect read/write permissions on Flutter.framework and FlutterMacOS.framework #148580

Conversation

LouiseHsu commented May 17, 2024 • edited by jmagman

Pre-launch Checklist

nilsreichardt commented May 19, 2024

jmagman May 20, 2024

Choose a reason for hiding this comment

jmagman May 20, 2024

Choose a reason for hiding this comment

jmagman left a comment

Choose a reason for hiding this comment

auto-submit bot commented May 20, 2024

jmagman May 20, 2024 • edited

Choose a reason for hiding this comment

auto-submit bot commented May 20, 2024

auto-submit bot commented May 20, 2024

jmagman commented May 21, 2024

nilsreichardt commented May 21, 2024

nilsreichardt commented May 23, 2024 • edited

jmagman commented May 23, 2024

LouiseHsu commented May 17, 2024 •

edited by jmagman

jmagman May 20, 2024 •

edited

nilsreichardt commented May 23, 2024 •

edited