Update file permissions for FlutterMacOS.framework #52930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
zanderso
approved these changes
May 20, 2024
jmagman
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 20, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
May 20, 2024
…148722) flutter/engine@a8fb9da...c2ef01f 2024-05-20 magder@google.com Update file permissions for FlutterMacOS.framework (flutter/engine#52930) 2024-05-20 jonahwilliams@google.com [Impeller] leave glyph atlas in transfer dst to improve vulkan throughput. (flutter/engine#52908) 2024-05-20 skia-flutter-autoroll@skia.org Roll Dart SDK from 54c384453207 to 08f4324c988b (1 revision) (flutter/engine#52931) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
flutteractionsbot
pushed a commit
to flutteractionsbot/engine
that referenced
this pull request
May 21, 2024
During FlutterMacOS.framework engine universal fat framework creation, make sure the framework is `u=rwx,go=rx` when it's created. There's a framework-side workaround in-flight flutter/flutter#148580. However, this is still a good thing to do engine-side, particularly for add-to-app when they don't go through the `flutter assemble` tooling. I'll also add a test around here, once this rolls https://github.com/flutter/flutter/blob/02a6c91e4d37d28f42c8f8e4d4335b0defed41c1/packages/flutter_tools/test/host_cross_arch.shard/macos_content_validation_test.dart#L30 Fixes flutter/flutter#148354 [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
5 tasks
jmagman
added
the
revert
|
A reason for requesting a revert of flutter/engine/52930 could |
auto-submit
bot
removed
the
revert
auto-submit bot
pushed a commit
that referenced
this pull request
May 21, 2024
Fix typo from #52930. The entire framework bundle/directory needs 755 perms (not recursive), but that PR instead updated the binary within the framework bundle. Once this rolls I'll rebase flutter/flutter#148786 and merge that test. Engine-side fix for flutter/flutter#148354
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During FlutterMacOS.framework engine universal fat framework creation, make sure the framework is
u=rwx,go=rxwhen it's created.There's a framework-side workaround in-flight flutter/flutter#148580.
However, this is still a good thing to do engine-side, particularly for add-to-app when they don't go through the
flutter assembletooling.I'll also add a test around here, once this rolls https://github.com/flutter/flutter/blob/02a6c91e4d37d28f42c8f8e4d4335b0defed41c1/packages/flutter_tools/test/host_cross_arch.shard/macos_content_validation_test.dart#L30
Fixes flutter/flutter#148354
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.