Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fixed issue #9507: Admin GUI: Decimal format in answers pdf export ev…
…en for 'only intenger' numeric questions
- Loading branch information
Showing
1 changed file
with
10 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
98e9ecc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not allways remove last 0 : https://github.com/LimeSurvey/LimeSurvey/blob/master/application/helpers/qanda_helper.php#L3406
98e9ecc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I chose the most conservative option. I think we shouldn't remove 0s from string fields. Imagine, for example, a ID code 1234.4567.000. About numerical fields in general (not integer only) I'm not sure.
98e9ecc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't have question type ? Must be apply only to numerical and multi_numerical. You're sure for 2.06 ? DB type is not DECIMAL ?
98e9ecc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done:
3b1ae46
Version 2.06 works fine, I tested it again.