For Windows, the hostname in kube-apiserver is in lowercase.

[shettyg]

Currently, the startup scripts force an environment variable
to have lowercase node name. This gets complex once we add
support to native windows services as they don't get
env variables from local shell.

An example of startup script is function: Start-AntreaAgent in
https://raw.githubusercontent.com/antrea-io/antrea/v1.2.0/hack/windows/Helper.psm1

Signed-off-by: Gurucharan Shetty gurushetty@google.com

[wenyingd]

LGTM

[lzhecheng]

LGTM.
/test-all

[lzhecheng]

/test-all

[codecov-commenter]

Codecov Report

Merging #2672 (7923400) into main (d8d70ac) will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main    #2672   +/-   ##
=======================================
  Coverage   60.70%   60.71%           
=======================================
  Files         285      285           
  Lines       23003    23006    +3     
=======================================
+ Hits        13965    13967    +2     
+ Misses       7544     7540    -4     
- Partials     1494     1499    +5     

Flag	Coverage Δ
e2e-tests	∅ <ø> (?)
kind-e2e-tests	48.41% <0.00%> (+0.03%)	⬆️
unit-tests	41.06% <0.00%> (-0.02%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
pkg/util/env/env.go	41.46% <0.00%> (-2.13%)	⬇️
pkg/controller/grouping/controller.go	67.24% <0.00%> (-1.73%)	⬇️
pkg/agent/flowexporter/exporter/exporter.go	80.23% <0.00%> (-1.17%)	⬇️
pkg/agent/cniserver/server.go	68.91% <0.00%> (-0.65%)	⬇️
pkg/agent/util/net.go	35.82% <0.00%> (-0.55%)	⬇️
pkg/agent/route/route_linux.go	43.50% <0.00%> (-0.50%)	⬇️
pkg/agent/openflow/pipeline.go	75.23% <0.00%> (+0.07%)	⬆️
pkg/legacyclient/clientset/versioned/clientset.go	30.64% <0.00%> (+4.83%)	⬆️
pkg/controller/networkpolicy/status_controller.go	77.12% <0.00%> (+5.88%)	⬆️

[tnqn]

The Node name is in lowercase on Linux too. kubelet converts it when reporting nodeName regardless of the platform, and server side API validation requires all metadata.name are in lower case.
So could we adjust the commit title a little to avoid confusion? e.g. "Convert NodeName got from env var to lowercase on Windows"

[shettyg]

The Node name is in lowercase on Linux too. kubelet converts it when reporting nodeName regardless of the platform, and server side API validation requires all metadata.name are in lower case.
So could we adjust the commit title a little to avoid confusion? e.g. "Convert NodeName got from env var to lowercase on Windows"

I updated the commit subject. Please take a look again

[tnqn]

LGTM

[tnqn]

/test-all
/test-windows-all

[antoninbas]

@tnqn feel free to cherry-pick this to release-1.3 if you think it is a good idea

[tnqn]

/skip-e2e as "TestLegacyAntreaPolicy/TestGroupAuditLogging" failed for known reason and has been fixed in #2683.
/test-conformance

[tnqn]

/test-windows-all

[tnqn]

/test-windows-e2e
/test-windows-networkpolicy
/test-windows-conformance

[tnqn]

/test-windows-networkpolicy
/test-windows-conformance

[tnqn]

jenkins-windows-networkpolicy failed due to some certificate issue. And apparently the change is not the cause. Merging it as other windows tests succeeded.