New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Electron input handling #3381
base: master
Are you sure you want to change the base?
Electron input handling #3381
Conversation
…ould be consumed. We cannot execute ANY JavaScript on the renderer until it receives a t/nil signal back from Nyxt. Otherwise we will deadlock the system.
@aadcg There are two commits here, both show two different ways of handling the new challenges faced with synchronous input handling in electron. The bottom line: WE CANNOT execute ANY JavaScript when handling input from the renderer. We need to return If we do not do this, the system will deadlock. Why?
I hope the above makes sense. It is kind of hard to write out :-) |
@jmercouris I think I understood the ideas. If I'm not mistaken, you're still trying out different approaches so I'll review when ready. Please limit you summary commit messages to 50 chars.
|
I will keep this in mind, and whenever reasonable, will limit my commit message summaries! |
I am ready to continue with one approach, I would like your opinion about which one it should be. Do you have any suggestions about what you think? |
I'm not sure I understand the consequences of each of the 2 approaches. The one from commit 519d380 seems closer to how it works in GTK. The other one, from commit d058c17, seems odd in the sense that So, my question would be: in what way is d058c17 superior to 519d380? |
Description
Checklist:
(asdf:test-system :nyxt/<renderer>)
)