-
Notifications
You must be signed in to change notification settings - Fork 35.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[27.x] Backports #29888
[27.x] Backports #29888
Conversation
The issue is that compilation is done with `x86_64-w64-mingw32-g++-posix`, but then linking is done with `x86_64-w64-mingw32-g++`. I'm guessing this has been broken since bitcoin#24131 (01d1845), but have not checked. Fixes bitcoin#29734. Unblocks bitcoin#29527 (now DEBUG=1 builds can be tested). Github-Pull: bitcoin#29747 Rebased-From: b7e7e72
To avoid issues with DNS blacklisting, I've setup a separate domain for my DNS seed. Github-Pull: bitcoin#29691 Rebased-From: 4f273ab
Re-enable feature_init Github-Pull: bitcoin#29856 Rebased-From: fadf7e9
Github-Pull: bitcoin#29869 Rebased-From: c2e0489
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code CoverageFor detailed information about the code coverage, see the test coverage report. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
Github-Pull: bitcoin#29886 Rebased-From: c087549
Github-Pull: bitcoin#29892 Rebased-From: fa4c696
Github-Pull: bitcoin#29859 Rebased-From: dd3e0fa
256c329
to
fe49299
Compare
Github-Pull: bitcoin#29870 Rebased-From: fa6ab0d
fe49299
to
29892c7
Compare
The script provided for signature might be externally provided, for instance by way of 'finalizepsbt'. Therefore the script might be ill-crafted, so don't assume pubkeys are always 32 bytes. Thanks to Niklas for finding this. Github-Pull: bitcoin#29853 Rebased-From: 4d8d213
29892c7
to
d70daed
Compare
Github-Pull: bitcoin#29776 Rebased-From: bbe82c1
d70daed
to
74f1e92
Compare
The 32 to 64-bit time_t transition causes a build failure in the built-in zlib about conflicting _TIME_BITS and _FILE_OFFSET_BITS. Note that zlib doesn't use time_t at all, so it is a false alarm. Take the following patch from upstream zlib: https://github.com/madler/zlib/commit/a566e156b3fa07b566ddbf6801b517a9dba04fa3.patch Closes bitcoin#29980. Github-Pull: bitcoin#29985 Rebased-From: 2e266f3
74f1e92
to
cdc6e12
Compare
Github-Pull: bitcoin#29934 Rebased-From: 2257404
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left one question, looks good otherwise
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 4689006
Without my earlier misunderstanding, this all looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reACK bd5860b |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
re-ACK bd5860b
I suggest to add bitcoin-core/gui#812 and bitcoin-core/gui#813. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK bd5860b
I'll put these into the next PR, that will likely also do release prep. |
Backports:
CHECK_ATOMIC
test #29859