Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Bump s390x to ubuntu:24.04 #29856

Merged
merged 1 commit into from
Apr 15, 2024
Merged

Conversation

maflcko
Copy link
Member

@maflcko maflcko commented Apr 11, 2024

Now that most other CI tasks are rolled to 24.04, roll this one as well.
Also, re-enable feature_init.

@DrahtBot
Copy link
Contributor

DrahtBot commented Apr 11, 2024

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage

For detailed information about the code coverage, see the test coverage report.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK fanquake

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

@DrahtBot DrahtBot added the Tests label Apr 11, 2024
@laanwj
Copy link
Member

laanwj commented Apr 11, 2024

im not sure it was intended to be rollling from debian to ubuntu too 😄

Not sure ubuntu exists for s390, but we'll see if CI passes.

@maflcko
Copy link
Member Author

maflcko commented Apr 11, 2024

Not sure ubuntu exists for s390, but we'll see if CI passes.

I think they are only missing riscv64, after commit docker-library/docs@54617b9#diff-aa2475d4f8253db9a16955859cf75ba0a5d4f2e2418db0d07390376ca47f1e48R39

@emc99
Copy link

emc99 commented Apr 11, 2024

What's s390x?

@laanwj
Copy link
Member

laanwj commented Apr 11, 2024

I think they are only missing riscv64, after commit

Great!

What's s390x?

s390x is some old IBM CPU architecture, we test on it to check if everything works on big-endian machines.

Re-enable feature_init
Copy link
Member

@fanquake fanquake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK fadf7e9 - finished running after ~5 hours.

@fanquake fanquake merged commit 3abee5e into bitcoin:master Apr 15, 2024
16 checks passed
@maflcko maflcko deleted the 2404-ci-s390x- branch April 15, 2024 09:04
fanquake pushed a commit to fanquake/bitcoin that referenced this pull request Apr 16, 2024
Re-enable feature_init

Github-Pull: bitcoin#29856
Rebased-From: fadf7e9
fanquake pushed a commit to fanquake/bitcoin that referenced this pull request Apr 16, 2024
Re-enable feature_init

Github-Pull: bitcoin#29856
Rebased-From: fadf7e9
@fanquake fanquake mentioned this pull request Apr 16, 2024
@fanquake
Copy link
Member

Backported to 27.x in #29888.

fanquake added a commit that referenced this pull request May 13, 2024
bd5860b [WIP] doc: release notes for 27.x (fanquake)
475aac4 doc: add LLVM instruction for macOS < 13 (Sjors Provoost)
a995902 depends: Fix build of Qt for 32-bit platforms (laanwj)
0fcceef Fix #29767, set m_synced = true after Commit() (nanlour)
ae9a2ed sign: don't assume we are parsing a sane Miniscript (Antoine Poinsot)
a6a59cf rpc: Reword SighashFromStr error message (MarcoFalke)
364bf01 build: Fix false positive `CHECK_ATOMIC` test for clang-15 (Hennadii Stepanov)
9277793 test: Fix failing univalue float test (MarcoFalke)
5c09791 doc: archive 27.0 release notes (fanquake)
897e5af [rpc, bugfix] Enforce maximum value for setmocktime (dergoegge)
602cfd5 ci: Bump s390x to ubuntu:24.04 (MarcoFalke)
20e6e8d Change Luke Dashjr seed to dashjr-list-of-p2p-nodes.us (Luke Dashjr)
a6862c5 depends: fix mingw-w64 Qt DEBUG=1 build (fanquake)

Pull request description:

  Backports:
  * #29691
  * #29747
  * #29776
  * #29853
  * #29856
  * #29859
  * #29869
  * #29870
  * #29886
  * #29892
  * #29934
  * #29985

ACKs for top commit:
  willcl-ark:
    reACK bd5860b
  stickies-v:
    re-ACK bd5860b
  TheCharlatan:
    ACK bd5860b

Tree-SHA512: a1a40de70cf52b5fc01d9dcc772421751a18c6a48a726c4c05c0371c585a53a27902e17daed9e0d721ab7763c94bb32de05c146bd6bc73fd558edd08b31e8547
glozow pushed a commit to glozow/bitcoin that referenced this pull request May 13, 2024
Re-enable feature_init

Github-Pull: bitcoin#29856
Rebased-From: fadf7e9
glozow pushed a commit to glozow/bitcoin that referenced this pull request May 23, 2024
Re-enable feature_init

Github-Pull: bitcoin#29856
Rebased-From: fadf7e9
glozow added a commit that referenced this pull request May 24, 2024
aa7e876 [doc] add draft release notes for 26.2rc1 (glozow)
21d9aaa p2p, bugfix: detect addnode cjdns peers in GetAddedNodeInfo() (Jon Atack)
ec5ce2f windeploy: Renew certificate (Ava Chow)
96d0e81 rpc: Reword SighashFromStr error message (MarcoFalke)
6685aff rpc: move UniValue in blockToJSON (willcl-ark)
7f45e00 depends: Fix build of Qt for 32-bit platforms (laanwj)
f9b76ba ci: Pull in qtbase5-dev instead of seperate low-level libraries (laanwj)
c587753 doc: Suggest installing dev packages for debian/ubuntu qt5 build (laanwj)
7ecdb08 ci: Bump s390x to ubuntu:24.04 (MarcoFalke)
d9ef6cf sign: don't assume we are parsing a sane Miniscript (Antoine Poinsot)
e4859c8 depends: fix mingw-w64 Qt DEBUG=1 build (fanquake)
bb46b90 Fix #29767, set m_synced = true after Commit() (nanlour)
bf5b6fc Throw error if invalid parameters passed to getnetworkhashps RPC endpoint (Jameson Lopp)
a81a922 [rpc, bugfix] Enforce maximum value for setmocktime (dergoegge)
d39ea51 Change Luke Dashjr seed to dashjr-list-of-p2p-nodes.us (Luke Dashjr)
c21bbcc [doc] archive 26.1 release notes (glozow)

Pull request description:

  Archives 26.1 release notes and adds draft release notes for 26.2rc1

  Also backports:
  - #29691
  - #29869
  - #28554
  - #29747
  - #29853
  - #29856
  - #29764
  - #29776
  - #29985
  - #30094
  - #29870
  - #30149
  - #30085

ACKs for top commit:
  stickies-v:
    re-ACK aa7e876, only changes are fixing commit msg and transifex reference
  willcl-ark:
    ACK aa7e876

Tree-SHA512: b81ba6092640de696d782114cdf43e7ed1d63ea0a3231cade30653c2743d87700e0f852a1b1fcc42ae313b2d4f004e6026ddbad87d58c2fde0a660e90026ed98
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants