Change Luke Dashjr seed to dashjr-list-of-p2p-nodes.us #29691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To avoid issues with DNS blacklisting, I've setup a separate domain for my DNS seed.
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code CoverageFor detailed information about the code coverage, see the test coverage report. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
|
Concept ACK, seems like a fine name. Haven't tested yet. |
|
Concept ACK 4f273ab, name looks good to me |
|
ACK 4f273ab DNS seems to resolve just fine for me, and returns IP addresses with a fair bit of overlap with the ones my DNS seed has. |
|
@luke-jr can you GPG sign this commit? Someone, possibly you, should also make a PR to update it here: https://github.com/bitcoin-core/bitcoin-maintainer-tools/blob/main/check-dnsseeds.py (better still if it just parses I ran the above script locally and it's happy. |
fanquake
approved these changes
Apr 6, 2024
There was a problem hiding this comment.
ACK 4f273ab
Someone, possibly you, should also make a PR to update it here:
I don't see why the person making the PR there matters; it's only copying what is in kernel/chainparams. Opened one for recent changes: bitcoin-core/bitcoin-maintainer-tools#160
fanquake
added a commit
to bitcoin-core/bitcoin-maintainer-tools
that referenced
this pull request
Apr 9, 2024
d439798 dns: update seeds from kernel/chainparams (fanquake) Pull request description: For after bitcoin/bitcoin#29691. ACKs for top commit: glozow: ACK d439798 Tree-SHA512: da8a4f520badaabf526c666c6745bf8b15ba5893cf1f424b014732105c80729152b62064e7c8dae8c0c4f8782eddf6c62e4c86e049886a7ae8199488b607acb0
fanquake
pushed a commit
to fanquake/bitcoin
that referenced
this pull request
Apr 16, 2024
To avoid issues with DNS blacklisting, I've setup a separate domain for my DNS seed. Github-Pull: bitcoin#29691 Rebased-From: 4f273ab
Merged
|
Backported to 27.x in #29888. |
glozow
pushed a commit
to glozow/bitcoin
that referenced
this pull request
Apr 17, 2024
To avoid issues with DNS blacklisting, I've setup a separate domain for my DNS seed. Github-Pull: bitcoin#29691 Rebased-From: 4f273ab
fanquake
added a commit
that referenced
this pull request
May 13, 2024
bd5860b [WIP] doc: release notes for 27.x (fanquake) 475aac4 doc: add LLVM instruction for macOS < 13 (Sjors Provoost) a995902 depends: Fix build of Qt for 32-bit platforms (laanwj) 0fcceef Fix #29767, set m_synced = true after Commit() (nanlour) ae9a2ed sign: don't assume we are parsing a sane Miniscript (Antoine Poinsot) a6a59cf rpc: Reword SighashFromStr error message (MarcoFalke) 364bf01 build: Fix false positive `CHECK_ATOMIC` test for clang-15 (Hennadii Stepanov) 9277793 test: Fix failing univalue float test (MarcoFalke) 5c09791 doc: archive 27.0 release notes (fanquake) 897e5af [rpc, bugfix] Enforce maximum value for setmocktime (dergoegge) 602cfd5 ci: Bump s390x to ubuntu:24.04 (MarcoFalke) 20e6e8d Change Luke Dashjr seed to dashjr-list-of-p2p-nodes.us (Luke Dashjr) a6862c5 depends: fix mingw-w64 Qt DEBUG=1 build (fanquake) Pull request description: Backports: * #29691 * #29747 * #29776 * #29853 * #29856 * #29859 * #29869 * #29870 * #29886 * #29892 * #29934 * #29985 ACKs for top commit: willcl-ark: reACK bd5860b stickies-v: re-ACK bd5860b TheCharlatan: ACK bd5860b Tree-SHA512: a1a40de70cf52b5fc01d9dcc772421751a18c6a48a726c4c05c0371c585a53a27902e17daed9e0d721ab7763c94bb32de05c146bd6bc73fd558edd08b31e8547
glozow
added a commit
that referenced
this pull request
May 24, 2024
aa7e876 [doc] add draft release notes for 26.2rc1 (glozow) 21d9aaa p2p, bugfix: detect addnode cjdns peers in GetAddedNodeInfo() (Jon Atack) ec5ce2f windeploy: Renew certificate (Ava Chow) 96d0e81 rpc: Reword SighashFromStr error message (MarcoFalke) 6685aff rpc: move UniValue in blockToJSON (willcl-ark) 7f45e00 depends: Fix build of Qt for 32-bit platforms (laanwj) f9b76ba ci: Pull in qtbase5-dev instead of seperate low-level libraries (laanwj) c587753 doc: Suggest installing dev packages for debian/ubuntu qt5 build (laanwj) 7ecdb08 ci: Bump s390x to ubuntu:24.04 (MarcoFalke) d9ef6cf sign: don't assume we are parsing a sane Miniscript (Antoine Poinsot) e4859c8 depends: fix mingw-w64 Qt DEBUG=1 build (fanquake) bb46b90 Fix #29767, set m_synced = true after Commit() (nanlour) bf5b6fc Throw error if invalid parameters passed to getnetworkhashps RPC endpoint (Jameson Lopp) a81a922 [rpc, bugfix] Enforce maximum value for setmocktime (dergoegge) d39ea51 Change Luke Dashjr seed to dashjr-list-of-p2p-nodes.us (Luke Dashjr) c21bbcc [doc] archive 26.1 release notes (glozow) Pull request description: Archives 26.1 release notes and adds draft release notes for 26.2rc1 Also backports: - #29691 - #29869 - #28554 - #29747 - #29853 - #29856 - #29764 - #29776 - #29985 - #30094 - #29870 - #30149 - #30085 ACKs for top commit: stickies-v: re-ACK aa7e876, only changes are fixing commit msg and transifex reference willcl-ark: ACK aa7e876 Tree-SHA512: b81ba6092640de696d782114cdf43e7ed1d63ea0a3231cade30653c2743d87700e0f852a1b1fcc42ae313b2d4f004e6026ddbad87d58c2fde0a660e90026ed98
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid issues with DNS blacklisting, I've setup a separate domain for my DNS seed.
(This time, without a potentially alarming name)