Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ceph.spec.in, debian/control: Add bc to build dependencies #13338

Merged
merged 1 commit into from Feb 10, 2017

Conversation

kshtsk
Copy link
Contributor

@kshtsk kshtsk commented Feb 9, 2017

The bc is missing for ceph-helpers.sh

Fixes: http://tracker.ceph.com/issues/18876
Signed-off-by: Kyr Shatskyy kyrylo.shatskyy@gmail.com

@kshtsk kshtsk closed this Feb 9, 2017
@kshtsk kshtsk reopened this Feb 9, 2017
@kshtsk
Copy link
Contributor Author

kshtsk commented Feb 9, 2017

@smithfarm could you please review this patch

@smithfarm
Copy link
Contributor

@kshtsk Could you open a bug at http://tracker.ceph.com describing the problem this is fixing?

Then, add a line to the commit message (directly above Signed-off-by: line) like this:

Fixes: http://tracker.ceph.com/issues/$ISSUE_NUMBER

Thanks

@smithfarm smithfarm self-assigned this Feb 9, 2017
@smithfarm smithfarm changed the title Add bc to ceph spec build/ops: rpm: Add bc to ceph spec Feb 9, 2017
@smithfarm
Copy link
Contributor

@kshtsk Also need to add the build dep to debian/control Thanks

@dmick
Copy link
Member

dmick commented Feb 9, 2017

  1. is this not also a build dependency for debian? (edit: oops nathan already asked)
  2. it would also be nice if PR title and commit title were clearer: "ceph.spec.in, debian/control: Add bc to build dependencies".

The bc is missing for ceph-helpers.sh

Fixes: http://tracker.ceph.com/issues/18876
Signed-off-by: Kyr Shatskyy <kyrylo.shatskyy@gmail.com>
@kshtsk kshtsk changed the title build/ops: rpm: Add bc to ceph spec ceph.spec.in, debian/control: Add bc to build dependencies Feb 9, 2017
Copy link
Member

@dmick dmick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@smithfarm smithfarm merged commit 9bd91dc into ceph:master Feb 10, 2017
@kshtsk kshtsk deleted the add-bc-to-deps branch August 13, 2020 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants