Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

msg/simple/Pipe: support IPv6 QoS. #13370

Merged
merged 1 commit into from Feb 16, 2017
Merged

Conversation

robbat2
Copy link
Contributor

@robbat2 robbat2 commented Feb 11, 2017

Extend DSCP marking for heartbeat packets to IPv6, as commit
9b9a682 only implemented
support for IPv4.

Backport: jewel, luminious
Fixes: http://tracker.ceph.com/issues/18887
Signed-off-by: Robin H. Johnson robin.johnson@dreamhost.com

Extend DSCP marking for heartbeat packets to IPv6, as commit
9b9a682 only implemented
support for IPv4.

Backport: jewel, luminious
Fixes: http://tracker.ceph.com/issues/18887
Signed-off-by: Robin H. Johnson <robin.johnson@dreamhost.com>
@robbat2
Copy link
Contributor Author

robbat2 commented Feb 11, 2017

This needs to be implemented in src/msg/async/net_handler.cc as well, but it's a little bit harder to get the address family there.

Copy link
Contributor

@badone badone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liewegas
Copy link
Member

@yuyuyu101 should we do this for msg/async too?

@yuyuyu101
Copy link
Member

sure, this can go ahead. I could supply async codes later

@robbat2
Copy link
Contributor Author

robbat2 commented Feb 13, 2017

@yuyuyu101 I started on the async path, but the address family isn't available in the NetHandler::set_priority (only the fd and prio are passed in), and I'm wondering if you have an opinion on what you'd like passed into that function for it.

@yuyuyu101
Copy link
Member

@robbat2 hmm, I think we can add new argument for set_priority and passing family into

@robbat2
Copy link
Contributor Author

robbat2 commented Feb 14, 2017

async version is here: #13418

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants