mon: does not check for IO errors on every transaction #6091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do this globally intead of relying on teh zillion mon callers to check the error code. There are no cases where we want to tolerate a commit failure. Fixes: ceph#13089 Signed-off-by: Sage Weil <sage@redhat.com> (cherry picked from commit 2fb7b1f)
Currently we already do a small write when the *first* election in a round happens (to update the election epoch). If the backend happens to fail while we are already in the midst of elections, however, we may continue to call elections without verifying we are still writeable. Signed-off-by: Sage Weil <sage@redhat.com> (cherry picked from commit ef909cc) Conflicts: src/mon/Elector.cc no MonitorDBStore::TransactionRef in firefly
smithfarm
force-pushed
the
wip-13252-firefly
branch
from
716a5f1
to
6d396a3
Compare
ghost
pushed a commit
that referenced
this pull request
Oct 20, 2015
…transaction Reviewed-by: Loic Dachary <ldachary@redhat.com>
|
@liewegas does this backport look good to merge ? It passed a run of the firefly rados suite ( see http://tracker.ceph.com/issues/11644#note-110 ). Note that there was a valgrind issues but it is unrelated and fixed by #6325. |
|
👍 |
ghost
pushed a commit
that referenced
this pull request
Oct 20, 2015
mon: does not check for IO errors on every transaction Reviewed-by: Sage Weil <sage@redhat.com>
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/13252