Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding weight files for BDT regression used in deadChannel recovery #1

Merged
merged 4 commits into from Aug 1, 2019

Conversation

taroni
Copy link
Contributor

@taroni taroni commented Jun 12, 2019

These files are used for the BDT regression used in the dead channel recovery of the Ecal Barrel (PR #27175 cms-sw/cmssw#27175)
@nancymarinelli

@cmsbuild
Copy link

A new Pull Request was created by @taroni (Silvia Taroni) for branch master.

@perrotta, @smuzaffar, @mrodozov, @cmsbuild, @slava77, @gudrutis can you please review it and eventually sign? Thanks.
@argiro this is something you requested to watch as well.
cms-bot commands are listed here

@cmsbuild
Copy link

Pull request #1 was updated.

@mrodozov
Copy link

please test with cms-sw/cmsdist#5037

@cmsbuild
Copy link

cmsbuild commented Jun 12, 2019

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmsdist#5037
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/908/console Started: 2019/06/12 15:12

@mrodozov
Copy link

please test with cms-sw/cmsdist#5037

@cmsbuild
Copy link

cmsbuild commented Jun 12, 2019

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmssw#27175
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/915/console Started: 2019/06/12 16:56

@cmsbuild
Copy link

cmsbuild commented Jun 12, 2019

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmssw#27175,cms-sw/cmsdist#5037
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/918/console Started: 2019/06/12 17:43

@cmsbuild
Copy link

-1

Tested at: 1160d09

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-231878/918/summary.html

I found follow errors while testing this PR

Failed tests: RelVals AddOn

  • RelVals:

When I ran the RelVals I found an error in the following workflows:
135.4 step1

runTheMatrix-results/135.4_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS/step1_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS.log

5.1 step1
runTheMatrix-results/5.1_TTbar+TTbarFS+HARVESTFS/step1_TTbar+TTbarFS+HARVESTFS.log

  • AddOn:

I found errors in the following addon tests:

cmsDriver.py TTbar_8TeV_TuneCUETP8M1_cfi --conditions auto:run1_mc --fast -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,EI,VALIDATION --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot Realistic8TeVCollision : FAILED - time: date Wed Jun 12 19:11:24 2019-date Wed Jun 12 19:07:46 2019 s - exit: 17920
cmsDriver.py TTbar_13TeV_TuneCUETP8M1_cfi --conditions auto:run2_mc_l1stage1 --fast -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,EI,VALIDATION --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot NominalCollision2015 --era Run2_25ns : FAILED - time: date Wed Jun 12 19:13:01 2019-date Wed Jun 12 19:08:03 2019 s - exit: 17920
cmsDriver.py TTbar_13TeV_TuneCUETP8M1_cfi --conditions auto:run2_mc --fast -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,EI,VALIDATION --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot NominalCollision2015 --era Run2_2016 : FAILED - time: date Wed Jun 12 19:13:09 2019-date Wed Jun 12 19:08:11 2019 s - exit: 17920

@cmsbuild
Copy link

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

@cmsbuild
Copy link

cmsbuild commented Jun 13, 2019

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmssw#27175,cms-sw/cmsdist#5037
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/945/console Started: 2019/06/13 16:04

@cmsbuild
Copy link

Comparison job queued.

@cmsbuild
Copy link

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9d7fd8/1714/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 2628564
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2628246
  • DQMHistoTests: Total skipped: 317
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 133 log files, 14 edm output root files, 32 DQM output files

@cmsbuild
Copy link

cmsbuild commented Jul 31, 2019

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmssw#27175
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1746/console Started: 2019/07/31 17:10

@cmsbuild
Copy link

Comparison job queued.

@cmsbuild
Copy link

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9d7fd8/1746/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-9d7fd8/22034.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2026D46_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D46+RecoFullGlobal_2026D46+HARVESTFullGlobal_2026D46

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 2484130
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2483812
  • DQMHistoTests: Total skipped: 317
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 132 log files, 14 edm output root files, 32 DQM output files

@slava77
Copy link

slava77 commented Aug 1, 2019

+1

based on (limited) tests in jenkins with cms-sw/cmssw#27175 58ca071,
as noted in
cms-sw/cmssw#27175 (comment) and confirmed in
cms-sw/cmssw#27175 (comment)

please proceed with merging of this PR and the related update in cmsdist so that the change appears in the IBs
Thank you.

@cmsbuild
Copy link

cmsbuild commented Aug 1, 2019

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@smuzaffar
Copy link
Contributor

done, new data files should apear in today's 23h IB

@slava77
Copy link

slava77 commented Aug 1, 2019

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants