Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

msafety set to 1e-4 #26

Merged
merged 1 commit into from Nov 30, 2020
Merged

Conversation

smrenna
Copy link
Contributor

@smrenna smrenna commented Nov 23, 2020

Request from Sam Bein for lower threshold on MSAFETY in ResonanceDecays (only) to allow for pMSSM decays with really small mass splittings.

@cmsbuild
Copy link

A new Pull Request was created by @smrenna (Stephen Mrenna) for branch cms/230.

@cmsbuild, @smuzaffar, @mrodozov can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

@qliphy
Copy link

qliphy commented Nov 24, 2020

please test for CMSSW_10_2_X

@cmsbuild
Copy link

cmsbuild commented Nov 24, 2020

The tests are being triggered in jenkins.
Test Parameters:

@qliphy
Copy link

qliphy commented Nov 24, 2020

@smrenna Should this also be included in other branches? e.g.
https://github.com/cms-externals/pythia8/blob/cms/240/src/ResonanceDecays.cc#L30

@smrenna
Copy link
Contributor Author

smrenna commented Nov 24, 2020 via email

@cmsbuild
Copy link

+1
Tested at: 57ae2d4
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3f4ad6/10969/summary.html
CMSSW: CMSSW_10_2_X_2020-11-23-2300
SCRAM_ARCH: slc6_amd64_gcc700

@cmsbuild
Copy link

Comparison job queued.

@cmsbuild
Copy link

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3f4ad6/10969/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 31
  • DQMHistoTests: Total histograms compared: 3007546
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3007354
  • DQMHistoTests: Total skipped: 190
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
  • Checked 129 log files, 25 edm output root files, 31 DQM output files

@agrohsje
Copy link

Hi @qliphy . My main motivation was to not move too far away from the P8 default. As this is needed for SUSY and they can live with 10_2 and 9_4 I would prefer just updating P8.230. What do you think?

@qliphy
Copy link

qliphy commented Nov 26, 2020

@agrohsje ok, that sounds good. This PR is similar as #20 , but further reduce msafety.

@agrohsje
Copy link

Yes, should be identical to #20 but with lower values.

@agrohsje
Copy link

assign generators

@cmsbuild
Copy link

New categories assigned: generators

@alberto-sanchez,@SiewYan,@GurpreetSinghChahal,@mkirsano,@agrohsje you have been requested to review this Pull request/Issue and eventually sign? Thanks

@agrohsje
Copy link

+1

@mrodozov
Copy link

so this goes in 10_2 ?

@agrohsje
Copy link

10_2 and 9_4.

@mrodozov mrodozov merged commit 7bad346 into cms-externals:cms/230 Nov 30, 2020
@silviodonato
Copy link

cmsdist PRs cms-sw/cmsdist#6469 and cms-sw/cmsdist#6470

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants