Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10_2_X] MSAFETY set to 1e-4 #6469

Merged
merged 1 commit into from Dec 2, 2020
Merged

Conversation

mrodozov
Copy link
Contributor

No description provided.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mrodozov (Mircho Rodozov) for branch IB/CMSSW_10_2_X/gcc700.

@cmsbuild, @smuzaffar, @mrodozov can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

@mrodozov mrodozov changed the title MSAFETY set to 1e-4 - 10.2 [10_2_X] MSAFETY set to 1e-4 Nov 30, 2020
@mrodozov
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 30, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+1
Tested at: ae24c59
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0b90d7/11166/summary.html
CMSSW: CMSSW_10_2_X_2020-11-30-1100
SCRAM_ARCH: slc6_amd64_gcc700

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0b90d7/11166/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 31
  • DQMHistoTests: Total histograms compared: 3007546
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3007355
  • DQMHistoTests: Total skipped: 190
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
  • Checked 129 log files, 25 edm output root files, 31 DQM output files

@mrodozov
Copy link
Contributor Author

mrodozov commented Dec 1, 2020

I have nothing in mind, I have no idea what this difference is, so I'm just pointing it to someone that does. I mean someone had to read it and make sense of it. So it's ok from your perspective ?

@agrohsje
Copy link

agrohsje commented Dec 1, 2020

They are both fully compatible within statistical precision. Don't ask me why it gets reported. The same two get reported in a recent pr I made that had definitely no impact at all beyond statistics. So nothing to worry about but thanks for the heads-up.

@mrodozov
Copy link
Contributor Author

mrodozov commented Dec 1, 2020

+externals

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 1, 2020

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_10_2_X/gcc700 IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@makortel
Copy link
Contributor

makortel commented Dec 1, 2020

there are two comparison differences
https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_10_2_X_2020-11-30-1100+0b90d7/40197/validateJR/all_OldVSNew_TTbar13TeVPU2017wf10224p0/

Those are from logErrorHarvester and are (likely) caused by MessageLogger messages being emitted in different order. These are safe to ignore (almost?) always.

They are both fully compatible within statistical precision.

PR tests aim to be fully reproducible (as long as nothing in GEN or SIM changes).

@qliphy
Copy link
Contributor

qliphy commented Dec 2, 2020

+1

@cmsbuild cmsbuild merged commit 030418d into IB/CMSSW_10_2_X/gcc700 Dec 2, 2020
@silviodonato
Copy link
Contributor

see cms-externals/pythia8#26

@smuzaffar smuzaffar deleted the mrodozov-patch-1 branch December 3, 2020 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants