New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade pythia8 to 302 #5869
upgrade pythia8 to 302 #5869
Conversation
please test |
The tests are being triggered in jenkins. |
To be tested together with the PR CMSSW cms-sw/cmssw#29995 |
-1 Tested at: ffec6ab
I found compilation error when building: * The action "final-job" was not completed successfully because The following dependencies could not complete: build-external+geneva+1.0-RC3-7765b8 * The action "install-external+geneva-toolfile+1.0-7765b8" was not completed successfully because The following dependencies could not complete: build-external+geneva-toolfile+1.0-7765b8 * The action "build-external+geneva+1.0-RC3-7765b8" was not completed successfully because Failed to build geneva. Log file in /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc7_amd64_gcc820/external/geneva/1.0-RC3-7765b8/log. Final lines of the log file: /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc7_amd64_gcc820/external/geneva/1.0-RC3-7765b8/geneva-1.0-RC3/src/PythiaInterface/PythiaDriver.cpp:488:37: error: no matching function for call to 'Pythia8::Pythia::setUserHooksPtr(Geneva::UserHookRestriction*&)' _pythia.setUserHooksPtr(_userhook); ^ In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc7_amd64_gcc820/external/geneva/1.0-RC3-7765b8/geneva-1.0-RC3/include/Geneva/PythiaInterface/PythiaDriver.hpp:28, from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc7_amd64_gcc820/external/geneva/1.0-RC3-7765b8/geneva-1.0-RC3/src/PythiaInterface/PythiaDriver.cpp:23: /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc820/external/pythia8/302-7765b8/include/Pythia8/Pythia.h:135:8: note: candidate: 'bool Pythia8::Pythia::setUserHooksPtr(Pythia8::UserHooksPtr)' You can see the results of the tests here: |
@mkirsano , looks like |
The idea is to create a special release for extended tests |
Pull request #5869 was updated. |
I finally managed to test geneva build. This test rebuilds openloops, which requires 30 GB of disk space! I confirm that geneva build fails. I suggest to temporarily exclude it for a special release. |
The tests are being triggered in jenkins. |
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
@mkirsano , so I guess generators are ok with removal of |
dire and vincia are no more needed, they are included in pythia8. The removal of geneva is temporary, agreed with generators. |
@smuzaffar is it ready to be merged? |
+externals |
This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_11_2_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
No description provided.