Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SCRAM] Extra checks of tags and attributes, deploy docs #7077

Merged
merged 2 commits into from Jun 30, 2021

Conversation

smuzaffar
Copy link
Contributor

No description provided.

@smuzaffar
Copy link
Contributor Author

test parameters:

  • full_cmssw = true

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_12_0_X/master.

@cmsbuild, @smuzaffar, @mrodozov, @iarspider can you please review it and eventually sign? Thanks.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b1bd90/16336/summary.html
COMMIT: 8f62951
CMSSW: CMSSW_12_0_X_2021-06-29-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/7077/16336/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b1bd90/16336/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b1bd90/16336/git-merge-result

Build

I found compilation error when building:

                 from /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-06-29-2300/src/FWCore/Framework/interface/LuminosityBlock.h:22,
                 from /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-06-29-2300/src/FWCore/Framework/interface/one/implementors.h:27,
                 from /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-06-29-2300/src/FWCore/Framework/interface/one/analyzerAbilityToImplementor.h:26,
                 from /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-06-29-2300/src/FWCore/Framework/interface/one/EDAnalyzer.h:24,
                 from /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-06-29-2300/src/Alignment/APEEstimation/plugins/ApeEstimator.cc:28:
/build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-06-29-2300/src/FWCore/Reflection/interface/IterWithDict.h:10:10: fatal error: TList.h: No such file or directory
   10 | #include "TList.h"
      |          ^~~~~~~~~
In file included from /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-06-29-2300/src/FWCore/Reflection/interface/TypeWithDict.h:12,
                 from /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-06-29-2300/src/DataFormats/Provenance/interface/BranchDescription.h:16,
                 from /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-06-29-2300/src/DataFormats/Provenance/interface/StableProvenance.h:11,


@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

Pull request #7077 was updated.

@smuzaffar
Copy link
Contributor Author

+externals

@smuzaffar smuzaffar merged commit fd8f78a into IB/CMSSW_12_0_X/master Jun 30, 2021
@smuzaffar smuzaffar deleted the smuzaffar-patch-2 branch June 30, 2021 19:06
@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_12_0_X/master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b1bd90/16339/summary.html
COMMIT: 7ce2b36
CMSSW: CMSSW_12_0_X_2021-06-29-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/7077/16339/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b1bd90/16339/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b1bd90/16339/git-merge-result

Unit Tests

I found errors in the following unit tests:

---> test test_PixelBaryCentreTool had ERRORS

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 38
  • DQMHistoTests: Total histograms compared: 2785711
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2785688
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
  • Checked 160 log files, 37 edm output root files, 38 DQM output files
  • TriggerResults: no differences found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants