Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated root to tip of branch master #7299

Conversation

mrodozov
Copy link
Contributor

No description provided.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mrodozov (Mircho Rodozov) for branch IB/CMSSW_12_1_X/rootmaster.

@cmsbuild, @smuzaffar, @mrodozov, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @qliphy you are the release manager for this.
cms-bot commands are listed here

@mrodozov
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-981720/18539/summary.html
COMMIT: f110f83
CMSSW: CMSSW_12_1_ROOT6_X_2021-09-10-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/7299/18539/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_ROOT6_X_2021-09-10-2300/src/RecoTracker/MkFit/plugins/MkFitSeedConverter.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_ROOT6_X_2021-09-10-2300/src/RecoTracker/MkFit/plugins/MkFitSiPixelHitConverter.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_ROOT6_X_2021-09-10-2300/src/RecoTracker/MkFit/plugins/MkFitSiStripHitConverter.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_ROOT6_X_2021-09-10-2300/src/RecoTracker/MkFit/plugins/createPhase1TrackerGeometry.cc
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_ROOT6_X_2021-09-10-2300/src/RecoTracker/MkFit/plugins/createPhase1TrackerGeometry.cc: In function 'void {anonymous}::setupSteeringParamsIter0(mkfit::IterationConfig&)':
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_ROOT6_X_2021-09-10-2300/src/RecoTracker/MkFit/plugins/createPhase1TrackerGeometry.cc:35:10: error: 'class mkfit::SteeringParams' has no member named 'finalize_plan'; did you mean 'fill_plan'?
   35 |       sp.finalize_plan();
      |          ^~~~~~~~~~~~~
      |          fill_plan
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_ROOT6_X_2021-09-10-2300/src/RecoTracker/MkFit/plugins/createPhase1TrackerGeometry.cc:50:10: error: 'class mkfit::SteeringParams' has no member named 'finalize_plan'; did you mean 'fill_plan'?
   50 |       sp.finalize_plan();


@mrodozov
Copy link
Contributor Author

test parameters:

  • full_cmssw = true

@mrodozov
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-981720/18545/summary.html
COMMIT: f110f83
CMSSW: CMSSW_12_1_ROOT6_X_2021-09-10-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/7299/18545/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-981720/18545/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-981720/18545/git-merge-result

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 6108 differences found in the comparisons
  • DQMHistoTests: Total files compared: 39
  • DQMHistoTests: Total histograms compared: 3001001
  • DQMHistoTests: Total failures: 14825
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2986154
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
  • Checked 165 log files, 37 edm output root files, 39 DQM output files
  • TriggerResults: found differences in 2 / 38 workflows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants