Update for keeping gen-level nuclear info in AOD

[yetkinyilmaz]

This pull-request contains a fix in order to keep all nuclear information (npart, ncoll, reaction plane) when the HepMCProduct is dropped.

This should be considered as a bug-fix in 75X, the production of the "heavyIon" object has to be in the digi step in order to be usable for some large GEN-SIM samples already produced.

The implementation for CMSSW_8_0_X will be different, it will be added to the gen step, in a more elegant way.

[cmsbuild]

A new Pull Request was created by @yetkinyilmaz for CMSSW_7_5_X.

Update for keeping gen-level nuclear info in AOD

It involves the following packages:

Configuration/Applications
Configuration/PyReleaseValidation
Configuration/StandardSequences
GeneratorInterface/HiGenCommon
SimGeneral/Configuration
SimGeneral/MixingModule

@vciulli, @civanch, @covarell, @danduggan, @boudoul, @franzoni, @mdhildreth, @fabozzi, @cmsbuild, @srimanob, @thuer, @bendavid, @davidlange6, @govoni can you please review it and eventually sign? Thanks.
@ghellwig, @mkirsano, @wmtan, @makortel, @cbaus, @GiacomoSguazzoni, @rovere, @VinInn, @Martin-Grunewald, @cerati, @dgulhan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' or '@cmsbuild, please test' 'please test with cms-sw/cmsdist#PR' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[bendavid]

Are these changes already in 80x?

[yetkinyilmaz]

No, in 80X, there will be a different implementation.
For now, we had to implement this one alone urgently.

On 10/11/15 13:41, Josh Bendavid wrote:

Are these changes already in 80x?

—
Reply to this email directly or view it on GitHub
#12344 (comment).

[fabozzi]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9603/console

[cmsbuild]

+1
Tested at: 9a7807e
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12344/9603/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12344/9603/summary.html

[fabozzi]

+1

[civanch]

+1

[wmtan]

@yetkinyilmaz @davidlange6 @bendavid @fabozzi @civanch @Dr15Jones It is easy to prove that this PR broke step2 of relvals 140.1 and 140.4 in CMSSW_7_5_X. So, what should be done about this?
A) Ignore the test failures and hope for the best
B) Revert this PR and redo it.
C) Debug and fix this without reverting this PR.
If the choice is B or C, it should be up to the HI developers to fix this.

[yetkinyilmaz]

Thanks for the warning Bill, and sorry for the trouble.
I vote for C, I know where the problem happens and I will try a fix now.