Fix the hcaletValue function. #13252

matz-e · 2016-02-11T14:59:05Z

As the current implementation does not work for fine granularity HF
TP, it needs the additional version parameter to give proper values
for version ==1 and allow to query |ieta| > 32.

As an alternative, the hcaletValue functions that take ieta parameters should be removed/deprecated.

As the current implementation does not work for fine granularity HF TP, it needs the additional version parameter to give proper values for version ==1 and allow to query |ieta| > 32.

cmsbuild · 2016-02-11T14:59:25Z

A new Pull Request was created by @matz-e (Matthias Wolf) for CMSSW_8_0_X.

It involves the following packages:

CalibCalorimetry/CaloTPG
CalibFormats/CaloTPG

@diguida, @cerminar, @cmsbuild, @franzoni, @mmusich, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks.
@tocheng this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

mmusich · 2016-02-11T15:00:07Z

please test

cmsbuild · 2016-02-11T15:00:42Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11146/console

cmsbuild · 2016-02-11T15:12:59Z

-1
Tested at: a55b595
I found an error when building:

>> Compiling  /tmp/cmsbuild/workspace/ib-any-integration/CMSSW_8_0_X_2016-02-10-2300/src/CaloOnlineTools/HcalOnlineDb/src/LMap.cc 
>> Compiling  /tmp/cmsbuild/workspace/ib-any-integration/CMSSW_8_0_X_2016-02-10-2300/src/CaloOnlineTools/HcalOnlineDb/src/LMapLoader.cc 
>> Compiling  /tmp/cmsbuild/workspace/ib-any-integration/CMSSW_8_0_X_2016-02-10-2300/src/CaloOnlineTools/HcalOnlineDb/src/PluginManager.cc 
>> Compiling  /tmp/cmsbuild/workspace/ib-any-integration/CMSSW_8_0_X_2016-02-10-2300/src/CaloOnlineTools/HcalOnlineDb/src/RooGKCounter.cc 
/tmp/cmsbuild/workspace/ib-any-integration/CMSSW_8_0_X_2016-02-10-2300/src/CaloOnlineTools/HcalOnlineDb/src/HcalLutManager.cc: In member function 'std::map > HcalLutManager::getCompressionLutXmlFromAsciiMaster(std::string, std::string, int, bool)':
/tmp/cmsbuild/workspace/ib-any-integration/CMSSW_8_0_X_2016-02-10-2300/src/CaloOnlineTools/HcalOnlineDb/src/HcalLutManager.cc:568:40: error: no matching function for call to 'CaloTPGTranscoderULUT::HTvalid(const int&, const int&)'
     _coder.HTvalid(row->ieta, row->iphi) ){
                                        ^
/tmp/cmsbuild/workspace/ib-any-integration/CMSSW_8_0_X_2016-02-10-2300/src/CaloOnlineTools/HcalOnlineDb/src/HcalLutManager.cc:568:40: note: candidate is:
In file included from /tmp/cmsbuild/workspace/ib-any-integration/CMSSW_8_0_X_2016-02-10-2300/src/CaloOnlineTools/HcalOnlineDb/interface/HcalLutManager.h:25:0,
                 from /tmp/cmsbuild/workspace/ib-any-integration/CMSSW_8_0_X_2016-02-10-2300/src/CaloOnlineTools/HcalOnlineDb/src/HcalLutManager.cc:21:

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13252/11146/summary.html

jimbrooke · 2016-02-16T19:13:26Z

Does this PR have an impact on L1 trigger jet energy scales?

Remove the function that provides ET values averaged over phi, as its new signature overlaps with the old signature of hcaletValue(ieta, iphi, count). Infers the TP version mostly from the depth, as done here: https://github.com/cms-sw/cmssw/blob/CMSSW_8_0_X/DataFormats/HcalDetId/src/HcalTrigTowerDetId.cc#L30

cmsbuild · 2016-02-17T11:07:47Z

Pull request #13252 was updated. @diguida, @cerminar, @cmsbuild, @franzoni, @deguio, @ggovi, @mmusich, @vanbesien, @mulhearn, @davidlange6 can you please check and sign again.

mmusich · 2016-02-17T11:08:15Z

please test

cmsbuild · 2016-02-17T11:08:30Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11276/console

matz-e · 2016-02-17T11:09:16Z

@jimbrooke I don't think so, this is just messing with the interface, and not changing anything w.r.t. algorithms.

matz-e · 2016-02-17T11:11:28Z

I have actually removed the hcaletValue(ieta, compET) function, as adding the version makes it overlap with the signature of hcaletValue(ieta, iphi, compET), and can lead to unwarranted side-effects.

I've also tried to patch up the dependencies as good as I can understand them, if someone could point me to testing procedures for those packages or look over the changes, that would be great.

cmsbuild · 2016-02-17T14:10:38Z

-1
Tested at: 4e2ddda
When I ran the RelVals I found an error in the following worklfows:
134.911 step2

runTheMatrix-results/134.911_RunSinglePh2015D+RunSinglePh2015D+HLTDR2_25ns+RECODR2_25nsreHLT+HARVESTDR2_25nsreHLT/step2_RunSinglePh2015D+RunSinglePh2015D+HLTDR2_25ns+RECODR2_25nsreHLT+HARVESTDR2_25nsreHLT.log
----- Begin Fatal Exception 17-Feb-2016 13:46:50 CET-----------------------
An exception of category 'FallbackFileOpenError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing input source of type PoolSource
   [2] Calling RootFileSequenceBase::initTheFile()
   [3] Calling StorageFactory::open()
   [4] Calling XrdFile::open()
Exception Message:
Failed to open the file 'root://xrootd-cms.infn.it//store/data/Run2015D/SinglePhoton/RAW/v1/000/256/677/00000/1ADDE997-605D-E511-944F-02163E01424B.root'
   Additional Info:
      [a] XrdCl::File::Open(name='root://eoscms.cern.ch//eos/cms/store/data/Run2015D/SinglePhoton/RAW/v1/000/256/677/00000/1ADDE997-605D-E511-944F-02163E01424B.root', flags=0x10, permissions=0660) => error '[FATAL] Socket timeout' (errno=0, code=103)
      [b] Remote server already encountered a fatal error; no redirections were performed.
      [c] Input file root://eoscms.cern.ch//eos/cms/store/data/Run2015D/SinglePhoton/RAW/v1/000/256/677/00000/1ADDE997-605D-E511-944F-02163E01424B.root could not be opened.
Fallback Input file root://xrootd-cms.infn.it//store/data/Run2015D/SinglePhoton/RAW/v1/000/256/677/00000/1ADDE997-605D-E511-944F-02163E01424B.root also could not be opened.
Original exception info is above; fallback exception info is below.
      [d] XrdCl::File::Open(name='root://xrootd-cms.infn.it//store/data/Run2015D/SinglePhoton/RAW/v1/000/256/677/00000/1ADDE997-605D-E511-944F-02163E01424B.root', flags=0x10, permissions=0660) => error '[FATAL] Redirect limit has been reached' (errno=0, code=306). No additional data servers were found.
      [e] Last URL tried: root://xrootd-cms.infn.it:1094//store/data/Run2015D/SinglePhoton/RAW/v1/000/256/677/00000/1ADDE997-605D-E511-944F-02163E01424B.root?tried=
      [f] Problematic data server: xrootd-cms.infn.it:1094
      [g] Disabled source: xrootd-cms.infn.it:1094
----- End Fatal Exception -------------------------------------------------

140.53 step2

runTheMatrix-results/140.53_RunHI2011+RunHI2011+RECOHID11+HARVESTDHI/step2_RunHI2011+RunHI2011+RECOHID11+HARVESTDHI.log
----- Begin Fatal Exception 17-Feb-2016 13:52:40 CET-----------------------
An exception of category 'FallbackFileOpenError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing input source of type PoolSource
   [2] Calling RootFileSequenceBase::initTheFile()
   [3] Calling StorageFactory::open()
   [4] Calling XrdFile::open()
Exception Message:
Failed to open the file 'root://xrootd-cms.infn.it//store/hidata/HIRun2011/HIMinBiasUPC/RAW/v1/000/182/124/0011F55A-8F13-E111-A987-003048F118C6.root'
   Additional Info:
      [a] XrdCl::File::Open(name='root://eoscms.cern.ch//eos/cms/store/hidata/HIRun2011/HIMinBiasUPC/RAW/v1/000/182/124/0011F55A-8F13-E111-A987-003048F118C6.root', flags=0x10, permissions=0660) => error '[FATAL] Socket timeout' (errno=0, code=103)
      [b] Remote server already encountered a fatal error; no redirections were performed.
      [c] Input file root://eoscms.cern.ch//eos/cms/store/hidata/HIRun2011/HIMinBiasUPC/RAW/v1/000/182/124/0011F55A-8F13-E111-A987-003048F118C6.root could not be opened.
Fallback Input file root://xrootd-cms.infn.it//store/hidata/HIRun2011/HIMinBiasUPC/RAW/v1/000/182/124/0011F55A-8F13-E111-A987-003048F118C6.root also could not be opened.
Original exception info is above; fallback exception info is below.
      [d] XrdCl::File::Open(name='root://xrootd-cms.infn.it//store/hidata/HIRun2011/HIMinBiasUPC/RAW/v1/000/182/124/0011F55A-8F13-E111-A987-003048F118C6.root', flags=0x10, permissions=0660) => error '[ERROR] Operation expired' (errno=0, code=206). No additional data servers were found.
      [e] Last URL tried: root://xrootd-cms.infn.it:1094//store/hidata/HIRun2011/HIMinBiasUPC/RAW/v1/000/182/124/0011F55A-8F13-E111-A987-003048F118C6.root?tried=
      [f] Problematic data server: xrootd-cms.infn.it:1094
      [g] Disabled source: xrootd-cms.infn.it:1094
----- End Fatal Exception -------------------------------------------------

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13252/11276/summary.html

abdoulline · 2016-03-04T07:06:08Z

Matthias, did you run
runTheMatrix tests after update yesterday?
I mean the changes shouln't affect old/"regular" 2x3 HF TPs in Run1 tests?

abdoulline · 2016-03-04T07:17:21Z

...I was too fast...
Jenkins tests obviously show there is no problem with 2x3 HF TPs per se
(with Run1 and 2015 geometry).

mmusich · 2016-03-04T07:19:50Z

@abdoulline thid PR is not yet merged. Is this needed for #13581 to work properly?

abdoulline · 2016-03-04T07:24:39Z

No, it's not _needed_, as far I know

But David refers to it as a possible culprit in the thread
#13581

On Fri, 4 Mar 2016, Marco Musich wrote:

@abdoulline thid PR is not yet merged. Is this needed for #13581 to work properly?

—
Reply to this email directly or view it on GitHub.[AEx02kCtecX5wWTkwVJrk3trh3DsExzdks5pp90ZgaJpZM4HYOEE.gif]

davidlange6 · 2016-03-04T07:26:42Z

is the same code... so I worry - but hcal should understand.. I'm making a merged PR so we can test on our side.

deguio · 2016-03-07T14:33:19Z

+1

mmusich · 2016-03-25T08:41:36Z

+1

matz-e · 2016-04-06T09:43:06Z

Are there any additional requirements to get this in? The version for 81X got merged a while ago?

ggovi · 2016-04-06T15:02:00Z

+1

mulhearn · 2016-04-12T14:32:11Z

+1

cmsbuild · 2016-04-12T14:32:42Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

davidlange6 · 2016-04-14T10:58:11Z

+1

Fix the hcaletValue function.

a55b595

As the current implementation does not work for fine granularity HF TP, it needs the additional version parameter to give proper values for version ==1 and allow to query |ieta| > 32.

cmsbuild added this to the Next CMSSW_8_0_X milestone Feb 11, 2016

cmsbuild added l1-pending alca-pending pending-signatures tests-pending orp-pending comparison-pending labels Feb 11, 2016

cmsbuild added tests-started and removed tests-pending labels Feb 11, 2016

cmsbuild added tests-rejected and removed tests-started labels Feb 11, 2016

cmsbuild added dqm-pending db-pending tests-pending and removed tests-rejected labels Feb 17, 2016

cmsbuild added tests-started and removed tests-pending labels Feb 17, 2016

davidlange6 mentioned this pull request Mar 4, 2016

Adding 1x1 HF trigger primitives in Hcal Geometry tags #13581

Merged

davidlange6 mentioned this pull request Mar 4, 2016

hcal geometry updates for 2016 #13589

Closed

cmsbuild added dqm-approved and removed dqm-pending labels Mar 7, 2016

rekovic mentioned this pull request Mar 18, 2016

Effect of HF TP on L1T cms-l1t-offline/cmssw#202

Open

cmsbuild added alca-approved and removed alca-pending labels Mar 25, 2016

cmsbuild added db-approved and removed db-pending labels Apr 6, 2016

cmsbuild added l1-approved fully-signed and removed l1-pending pending-signatures labels Apr 12, 2016

cmsbuild added orp-approved and removed orp-pending labels Apr 14, 2016

cmsbuild merged commit abd4163 into cms-sw:CMSSW_8_0_X Apr 14, 2016

matz-e deleted the fix-calotpg-hcalet branch September 15, 2017 15:02

abdoulline mentioned this pull request Feb 17, 2021

Access Conditions DB for HCAL Pulse Filtering Weights #32717

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix the hcaletValue function. #13252

Fix the hcaletValue function. #13252

matz-e commented Feb 11, 2016

cmsbuild commented Feb 11, 2016

mmusich commented Feb 11, 2016

cmsbuild commented Feb 11, 2016

cmsbuild commented Feb 11, 2016

jimbrooke commented Feb 16, 2016

cmsbuild commented Feb 17, 2016

mmusich commented Feb 17, 2016

cmsbuild commented Feb 17, 2016

matz-e commented Feb 17, 2016

matz-e commented Feb 17, 2016

cmsbuild commented Feb 17, 2016

abdoulline commented Mar 4, 2016

abdoulline commented Mar 4, 2016

mmusich commented Mar 4, 2016

abdoulline commented Mar 4, 2016

davidlange6 commented Mar 4, 2016

deguio commented Mar 7, 2016

mmusich commented Mar 25, 2016

matz-e commented Apr 6, 2016

ggovi commented Apr 6, 2016

mulhearn commented Apr 12, 2016

cmsbuild commented Apr 12, 2016

davidlange6 commented Apr 14, 2016

Fix the hcaletValue function. #13252

Fix the hcaletValue function. #13252

Conversation

matz-e commented Feb 11, 2016

cmsbuild commented Feb 11, 2016

mmusich commented Feb 11, 2016

cmsbuild commented Feb 11, 2016

cmsbuild commented Feb 11, 2016

jimbrooke commented Feb 16, 2016

cmsbuild commented Feb 17, 2016

mmusich commented Feb 17, 2016

cmsbuild commented Feb 17, 2016

matz-e commented Feb 17, 2016

matz-e commented Feb 17, 2016

cmsbuild commented Feb 17, 2016

abdoulline commented Mar 4, 2016

abdoulline commented Mar 4, 2016

mmusich commented Mar 4, 2016

abdoulline commented Mar 4, 2016

davidlange6 commented Mar 4, 2016

deguio commented Mar 7, 2016

mmusich commented Mar 25, 2016

matz-e commented Apr 6, 2016

ggovi commented Apr 6, 2016

mulhearn commented Apr 12, 2016

cmsbuild commented Apr 12, 2016

davidlange6 commented Apr 14, 2016