update trajectory filters (minNumberOfHits --> minNumberOfHitsForLoopers) #13421

mtosi · 2016-02-22T09:56:45Z

this PR is meant to update the name of a trajectory filter parameter (minNumberOfHits --> minNumberOfHitsForLoopers)

I also take the opportunity of deleting few existAs checks which were still present in the TrackingTools/TrajectoryFiltering package
=> the HLT customization function (HLTrigger/Configuration/python/customizeHLTforCMSSW.py) has been updated in order to make the HLT menu compatible w/ this update ("usual" temporary solution waiting for the confDB update)

in addition, I noticed there were few cases in which the class constructor, where default input parameters were used, was not in synch w/ the default parameter values given by config
=> the default parameters have been updated as well

I ran
HLTrigger/Configuration/test/cmsDriver.sh
and
addOnTests.py
I got the few errors ([1] from cmsDriver and [2] from addOnTests, respectively)
but I think they are not related to my changes

@VinInn @rovere @perrotta @Martin-Grunewald

[1]
Creating DigiL1RawHLT HIon_MC
DIGI:pdigi_valid,L1,DIGI2RAW,HLT:HIon,ENDJOB
entry /store/relval/CMSSW_7_6_0_pre6/RelValZEEMM_13_HI/GEN-SIM/76X_mcRun2_HeavyIon_v4-v1/00000/EA469164-6A69-E511-A361-008CFA008768.root
###################################################################

WARNING: this module is deprecated.

Please use CondCore.CondDB.CondDB_cfi.py

###################################################################
Step: DIGI Spec: ['pdigi_valid']
Step: L1 Spec:
L1TCalorimeter Sequence configured for Stage-1 (2015) trigger.
L1TMuon Sequence configured for Legacy trigger (Run1 and Run 2015).
L1TGlobal Sequence configured for Legacy trigger (Run1 and Run 2015).
L1TCalorimeter Conditions configured for Stage-1 (2015) trigger.
Step: DIGI2RAW Spec:
L1TDigiToRaw Sequence configured for Stage-1 (2015) trigger.
Step: HLT Spec: ['HIon']
Step: ENDJOB Spec:

Conditions read from CMS_CONDITIONS via FrontierProd

customising the process with L1THLT from HLTrigger/Configuration/CustomConfigs
customising the process with customizeHLTforFullSim from HLTrigger/Configuration/customizeHLTforMC
Config file RelVal_DigiL1RawHLT_HIon_MC.py created

Creating FastSim HIon_MC
GEN,SIM,RECOBEFMIX,DIGI,L1,L1Reco,RECO,HLT:HIon,ENDJOB
Traceback (most recent call last):
File "/afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc6_amd64_gcc493/cms/cmssw/CMSSW_8_0_X_2016-02-15-2300/bin/slc6_amd64_gcc493/cmsDriver.py", line 55, in
run()
File "/afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc6_amd64_gcc493/cms/cmssw/CMSSW_8_0_X_2016-02-15-2300/bin/slc6_amd64_gcc493/cmsDriver.py", line 11, in run
options = OptionsFromCommandLine()
File "/afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc6_amd64_gcc493/cms/cmssw/CMSSW_8_0_X_2016-02-15-2300/python/Configuration/Applications/cmsDriverOptions.py", line 33, in OptionsFromCommandLine
options=OptionsFromItems(sys.argv[1:])
File "/afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc6_amd64_gcc493/cms/cmssw/CMSSW_8_0_X_2016-02-15-2300/python/Configuration/Applications/cmsDriverOptions.py", line 271, in OptionsFromItems
raise Exception("ERROR: the --option fast is only compatible with the default scenario (--scenario=pp)")
Exception: ERROR: the --option fast is only compatible with the default scenario (--scenario=pp)

[2]
cmsDriver.py TTbar_Tauola_13TeV_cfi -s GEN,SIM,DIGI,L1,DIGI2RAW --mc --scenario=pp -n 10 --conditions auto:run2_mc_GRun --relval 9000,50 --datatier "GEN-SIM-RAW" --eventcontent RAWSIM --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_25ns --magField 38T_PostLS1 --fileout file:RelVal_Raw_GRun_MC.root : FAILED - time: date Wed Feb 17 17:52:54 2016-date Wed Feb 17 17:47:04 2016 s - exit: 34560

log file:
/afs/cern.ch/work/t/tosi/public/trackingHLT/update_trajectory_filtering/CMSSW_8_0_X_2016-02-15-2300/src/HLTrigger/Configuration/test/addOnTests/logs/cmsDriver-hlt_mc_GRun_cmsDriver.py_TTbar_Tauola_13TeV_cfi_-s_GEN,SIM,DIGI,L1,DIGI2RAW_--mc_--scenario=pp_-n_10_--conditions_auto:run2_mc_GRun_--relval_9000,50_--datatier_G.log

cmsbuild · 2016-02-22T09:57:07Z

A new Pull Request was created by @mtosi (mia tosi) for CMSSW_8_0_X.

It involves the following packages:

HLTrigger/Configuration
TrackingTools/TrajectoryFiltering

@perrotta, @cmsbuild, @cvuosalo, @slava77, @Martin-Grunewald, @fwyzard, @davidlange6 can you please review it and eventually sign? Thanks.
@geoff-smith, @makortel, @GiacomoSguazzoni, @rovere, @VinInn, @Martin-Grunewald, @bellan, @jalimena, @cerati, @gpetruc, @istaslis, @dgulhan this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

VinInn · 2016-02-22T10:03:40Z

@cmsbuild, please test

cmsbuild · 2016-02-22T10:03:59Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11434/console

makortel · 2016-02-22T10:59:29Z

TrackingTools/TrajectoryFiltering/interface/CkfBaseTrajectoryFilter.h

+    desc.add<edm::ParameterSetDescription>("lostHitsFractionTrajectoryFilter",descLostHitsFraction);
+    desc.add<edm::ParameterSetDescription>("minHitsTrajectoryFilter",         descMinHits);
+    return desc;
+  }


Out of curiosity, what is this function for? Are we going to get a fillDescriptions() mechanism for global PSets?

If I have understood things correctly, I'm also afraid that the code above would generate a PSet that would not be valid for CkfBaseTrajectoryFilter, that is

cms.PSet( looperTrajectoryFilter = cms.PSet( ... ), lostHitsFractionTrajectoryFilter = cms.PSet( ... ), minHitsTrajectoryFilter = cms.PSet( ... ) )

(although personally I wouldn't mind this style)

ciao
thanks for the remark
such a function is not called yet,
I added it as a book keeper for trying to dealing w/ the fillDescription (as you catch ;) )
yes, it is adding an extra PSet, as now
instead of simply adding the parameters list
(as said this is just a book keeper)

cmsbuild · 2016-02-22T11:02:18Z

+1
Tested at: 91f9442
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13421/11434/summary.html

cmsbuild · 2016-02-22T11:52:08Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13421/11434/summary.html

slava77 · 2016-02-22T22:04:22Z

@mtosi is this required to be in 80X?
We should probably start with 81X and then backport.
Please make a PR in 81X.

cvuosalo · 2016-02-22T23:17:10Z

+1

For #13421 91f9442

Code clean-up of trajectory filters. There should be no change in monitored quantities.

The code changes are satisfactory, and Jenkins tests against baseline CMSSW_8_0_X_2016-02-21-2300 show no significant differences, as expected.

mtosi · 2016-02-23T08:32:34Z

I've just created PR #13436 (81x)
hope it is fine

mtosi · 2016-03-03T14:12:13Z

can this PR be integrated ?
thanks

Martin-Grunewald · 2016-03-03T14:23:23Z

after the l1extra migration!

mtosi · 2016-03-03T14:24:54Z

right, thanks martin

mtosi · 2016-05-02T08:23:55Z

PR #13436 has been closed w/o being merged (81x)
could this PR be integrated ?

slava77 · 2016-05-02T20:09:52Z

this PR no longer merges.
Please rebase.

rovere · 2016-05-03T09:24:18Z

@Martin-Grunewald was there a problem with this rebase?

Martin-Grunewald · 2016-05-03T09:25:26Z

80X was just fine and no rebase was needed.
The rebase was needed for the old 81X PR #13436

rovere · 2016-05-03T09:28:05Z

I think you are wrong, since while doing the rebase on top of a recent IB we had conflicts...

cmsbuild · 2016-05-03T12:20:11Z

+1
Tested at: b4c0547
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13421/12778/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
28c5955
6a402e1
ac50b95
b32f7e2
dcd856a
aa213df
4671ab5
054adb6
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13421/12778/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13421/12778/git-merge-result

cmsbuild · 2016-05-03T13:53:25Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13421/12778/summary.html

cvuosalo · 2016-05-03T21:45:49Z

+1

For #13421 b4c0547

Second approval after re-base. Jenkins tests are still OK, but DQM plots show changes from the other PRs Jenkins included in the test.

Martin-Grunewald · 2016-05-04T08:50:45Z

+1

cmsbuild · 2016-05-04T08:51:08Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

Martin-Grunewald · 2016-05-11T08:35:37Z

@davidlange6
Please integrate this in 80X (the 81X PRs are #13436 / #14317)!

cmsbuild added this to the Next CMSSW_8_0_X milestone Feb 22, 2016

cmsbuild added reconstruction-pending hlt-pending pending-signatures tests-pending orp-pending comparison-pending labels Feb 22, 2016

cmsbuild added tests-started and removed tests-pending labels Feb 22, 2016

makortel reviewed Feb 22, 2016
View reviewed changes

cmsbuild added tests-approved and removed tests-started labels Feb 22, 2016

cmsbuild added comparison-available and removed comparison-pending labels Feb 22, 2016

cmsbuild added reconstruction-approved and removed reconstruction-pending labels Feb 22, 2016

cvuosalo mentioned this pull request Feb 23, 2016

update trajectory filters (minNumberOfHits --> minNumberOfHitsForLoopers) #13436

Closed

cmsbuild added tests-started and removed tests-pending labels May 3, 2016

cmsbuild added tests-approved and removed tests-started labels May 3, 2016

cmsbuild added comparison-available and removed comparison-pending labels May 3, 2016

cmsbuild added reconstruction-approved and removed reconstruction-pending labels May 3, 2016

cvuosalo mentioned this pull request May 3, 2016

update trajectory filters (minNumberOfHits --> minNumberOfHitsForLoopers) #14317

Merged

cmsbuild added hlt-approved fully-signed and removed hlt-pending pending-signatures labels May 4, 2016

davidlange6 merged commit b2edca0 into cms-sw:CMSSW_8_0_X May 11, 2016

Martin-Grunewald added a commit to cms-tsg-storm/cmssw that referenced this pull request May 12, 2016

Migration for cms-sw#13421 / cms-sw#14317

683ff9f

Martin-Grunewald added a commit to cms-tsg-storm/cmssw that referenced this pull request May 12, 2016

Migration for cms-sw#13421 / cms-sw#14317

0a7341e

Martin-Grunewald added a commit to cms-tsg-storm/cmssw that referenced this pull request May 12, 2016

Migration for cms-sw#13421 / cms-sw#14317

9307ee3

Martin-Grunewald added a commit to cms-tsg-storm/cmssw that referenced this pull request May 13, 2016

Migration for cms-sw#13421 / cms-sw#14317

149fc5f

Martin-Grunewald added a commit to cms-tsg-storm/cmssw that referenced this pull request May 13, 2016

Migration for cms-sw#13421 / cms-sw#14317

ceb45b9

Martin-Grunewald added a commit to cms-tsg-storm/cmssw that referenced this pull request May 18, 2016

Migration for cms-sw#13421 / cms-sw#14317

fadb5b9

Martin-Grunewald added a commit to cms-tsg-storm/cmssw that referenced this pull request May 24, 2016

Migration for cms-sw#13421 / cms-sw#14317

8a6d3be

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

update trajectory filters (minNumberOfHits --> minNumberOfHitsForLoopers) #13421

update trajectory filters (minNumberOfHits --> minNumberOfHitsForLoopers) #13421

mtosi commented Feb 22, 2016

cmsbuild commented Feb 22, 2016

VinInn commented Feb 22, 2016

cmsbuild commented Feb 22, 2016

makortel Feb 22, 2016

mtosi Feb 22, 2016

cmsbuild commented Feb 22, 2016

cmsbuild commented Feb 22, 2016

slava77 commented Feb 22, 2016

cvuosalo commented Feb 22, 2016

mtosi commented Feb 23, 2016

mtosi commented Mar 3, 2016

Martin-Grunewald commented Mar 3, 2016

mtosi commented Mar 3, 2016

mtosi commented May 2, 2016

slava77 commented May 2, 2016

rovere commented May 3, 2016

Martin-Grunewald commented May 3, 2016

rovere commented May 3, 2016

cmsbuild commented May 3, 2016

cmsbuild commented May 3, 2016

cvuosalo commented May 3, 2016

Martin-Grunewald commented May 4, 2016

cmsbuild commented May 4, 2016

Martin-Grunewald commented May 11, 2016

update trajectory filters (minNumberOfHits --> minNumberOfHitsForLoopers) #13421

update trajectory filters (minNumberOfHits --> minNumberOfHitsForLoopers) #13421

Conversation

mtosi commented Feb 22, 2016

WARNING: this module is deprecated.

Please use CondCore.CondDB.CondDB_cfi.py

Conditions read from CMS_CONDITIONS via FrontierProd

cmsbuild commented Feb 22, 2016

VinInn commented Feb 22, 2016

cmsbuild commented Feb 22, 2016

makortel Feb 22, 2016

Choose a reason for hiding this comment

mtosi Feb 22, 2016

Choose a reason for hiding this comment

cmsbuild commented Feb 22, 2016

cmsbuild commented Feb 22, 2016

slava77 commented Feb 22, 2016

cvuosalo commented Feb 22, 2016

mtosi commented Feb 23, 2016

mtosi commented Mar 3, 2016

Martin-Grunewald commented Mar 3, 2016

mtosi commented Mar 3, 2016

mtosi commented May 2, 2016

slava77 commented May 2, 2016

rovere commented May 3, 2016

Martin-Grunewald commented May 3, 2016

rovere commented May 3, 2016

cmsbuild commented May 3, 2016

cmsbuild commented May 3, 2016

cvuosalo commented May 3, 2016

Martin-Grunewald commented May 4, 2016

cmsbuild commented May 4, 2016

Martin-Grunewald commented May 11, 2016