Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update trajectory filters (minNumberOfHits --> minNumberOfHitsForLoopers) #14317

Conversation

mtosi
Copy link
Contributor

@mtosi mtosi commented May 2, 2016

PR #13436 was closed
this is the new one for having this update in

hope it is fine

@Martin-Grunewald @rovere @VinInn

@cmsbuild cmsbuild added this to the Next CMSSW_8_1_X milestone May 2, 2016
@cmsbuild
Copy link
Contributor

cmsbuild commented May 2, 2016

A new Pull Request was created by @mtosi (mia tosi) for CMSSW_8_1_X.

It involves the following packages:

HLTrigger/Configuration
TrackingTools/TrajectoryFiltering

@perrotta, @cmsbuild, @cvuosalo, @fwyzard, @Martin-Grunewald, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@geoff-smith, @makortel, @GiacomoSguazzoni, @rovere, @VinInn, @Martin-Grunewald, @bellan, @jalimena, @gpetruc, @cerati, @dgulhan this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@slava77
Copy link
Contributor

slava77 commented May 2, 2016

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 2, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12754/console

@cmsbuild
Copy link
Contributor

cmsbuild commented May 2, 2016

@cmsbuild
Copy link
Contributor

cmsbuild commented May 2, 2016

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14317/12754/summary.html

The workflows 140.53 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

@Martin-Grunewald
Copy link
Contributor

+1

@Martin-Grunewald
Copy link
Contributor

@cvuosalo, @slava77
please sign.

Thanks!

@cvuosalo
Copy link
Contributor

cvuosalo commented May 3, 2016

+1

For #14317 d26d86f

Code clean-up of trajectory filters. There should be no change in monitored quantities.

#13421 is the 80X version of this PR, and it has already been approved.

The code changes are satisfactory, and Jenkins tests against baseline CMSSW_8_1_X_2016-04-29-2300 show no significant differences, as expected.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 3, 2016

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit eff0eb0 into cms-sw:CMSSW_8_1_X May 4, 2016
Martin-Grunewald added a commit to cms-tsg-storm/cmssw that referenced this pull request May 12, 2016
Martin-Grunewald added a commit to cms-tsg-storm/cmssw that referenced this pull request May 12, 2016
Martin-Grunewald added a commit to cms-tsg-storm/cmssw that referenced this pull request May 12, 2016
Martin-Grunewald added a commit to cms-tsg-storm/cmssw that referenced this pull request May 13, 2016
Martin-Grunewald added a commit to cms-tsg-storm/cmssw that referenced this pull request May 13, 2016
Martin-Grunewald added a commit to cms-tsg-storm/cmssw that referenced this pull request May 18, 2016
Martin-Grunewald added a commit to cms-tsg-storm/cmssw that referenced this pull request May 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants