-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove HcalCholeskyMatrix object entirely #15320
remove HcalCholeskyMatrix object entirely #15320
Conversation
A new Pull Request was created by @kpedro88 (Kevin Pedro) for CMSSW_8_1_X. It involves the following packages: CondCore/HcalPlugins @ghellwig, @cerminar, @cmsbuild, @franzoni, @ggovi, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
@cmsbuild please test |
The tests are being triggered in jenkins. |
@cmsbuild please test |
The tests are being triggered in jenkins. |
+1 |
@ggovi @davidlange6 it would be nice to merge this quickly - while preparing this, I noticed another unused HCAL CondFormat that can be removed (HcalCovarianceMatrix). However, because that object has neighboring lines of code with HcalCholeskyMatrix in some places, I have to wait until this PR is merged so I can rebase. Otherwise, Git thinks there is a conflict. |
@ggovi ping |
@mmusich I hope you mean harmless... |
@kpedro88 freudian slip :) corrected now |
@davidlange6 reminder |
This PR finishes the removal of the unused HcalCholeskyMatrix object (see issue #14954).
attn: @abdoulline