HIP Killing and PreMixing for 80X #15458

mdhildreth · 2016-08-12T18:26:13Z

Add capabilities for luminosity scaling and PreMixing to HIP-killing code

mdhildreth · 2016-08-12T18:26:24Z

please test

cmsbuild · 2016-08-12T18:26:32Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/14511/console

cmsbuild · 2016-08-12T18:26:33Z

A new Pull Request was created by @mdhildreth for CMSSW_8_0_X.

It involves the following packages:

DataFormats/StdDictionaries
DataFormats/WrappedStdDictionaries
SimGeneral/Configuration
SimGeneral/DataMixingModule
SimGeneral/MixingModule
SimTracker/SiStripDigitizer

@smuzaffar, @civanch, @Dr15Jones, @mdhildreth, @cmsbuild, @davidlange6 can you please review it and eventually sign? Thanks.
@wmtan, @makortel, @sdevissc, @GiacomoSguazzoni, @jlagram, @rovere, @VinInn, @cnuttens, @prolay, @wddgit, @threus, @dgulhan, @LBeck this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

Dr15Jones · 2016-08-12T18:40:18Z

+1

cmsbuild · 2016-08-12T19:19:05Z

-1

Tested at: c4ee63d

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15458/14511/summary.html

I found follow errors while testing this PR

Failed tests: RelVals AddOn

RelVals:

When I ran the RelVals I found an error in the following worklfows:
8.0 step1

runTheMatrix-results/8.0_BeamHalo+BeamHalo+DIGICOS+RECOCOS+ALCABH+HARVESTCOS/step1_BeamHalo+BeamHalo+DIGICOS+RECOCOS+ALCABH+HARVESTCOS.log

9.0 step1

runTheMatrix-results/9.0_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST/step1_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST.log

25.0 step1

runTheMatrix-results/25.0_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT/step1_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT.log

1306.0 step1

runTheMatrix-results/1306.0_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15/step1_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15.log

1330.0 step1

runTheMatrix-results/1330.0_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15/step1_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15.log

25202.0 step1

runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25/step1_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25.log

50202.0 step1

runTheMatrix-results/50202.0_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50/step1_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50.log

101.0 step1

runTheMatrix-results/101.0_SingleElectronE120EHCAL+SingleElectronE120EHCAL/step1_SingleElectronE120EHCAL+SingleElectronE120EHCAL.log

5.1 step1

runTheMatrix-results/5.1_TTbar+TTbarFS+HARVESTFS/step1_TTbar+TTbarFS+HARVESTFS.log

4.22 step3

runTheMatrix-results/4.22_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC/step3_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC.log

1001.0 step3

runTheMatrix-results/1001.0_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3+ALCAHARVD4+ALCAHARVD5/step3_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3+ALCAHARVD4+ALCAHARVD5.log

135.4 step1

runTheMatrix-results/135.4_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS/step1_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS.log

AddOn:

I found errors in the following addon tests:

cmsDriver.py TTbar_8TeV_TuneCUETP8M1_cfi --conditions auto:run1_mc --fast -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,EI,HLT:@Fake,VALIDATION --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot Realistic8TeVCollision : FAILED - time: date Fri Aug 12 20:58:10 2016-date Fri Aug 12 20:56:55 2016 s - exit: 23040
cmsDriver.py TTbar_Tauola_13TeV_cfi -s GEN,SIM,DIGI,L1,DIGI2RAW --mc --scenario=pp -n 10 --conditions auto:run2_mc_GRun --relval 9000,50 --datatier "GEN-SIM-RAW" --eventcontent RAWSIM --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2016 --magField 38T_PostLS1 --fileout file:RelVal_Raw_GRun_MC.root : FAILED - time: date Fri Aug 12 20:57:58 2016-date Fri Aug 12 20:57:05 2016 s - exit: 23040
cmsRun /cvmfs/cms-ib.cern.ch/week1/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_8_0_X_2016-08-12-1100/src/HLTrigger/Configuration/test/OnLine_HLT_GRun.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Fri Aug 12 20:57:58 2016-date Fri Aug 12 20:57:05 2016 s - exit: 21504
cmsDriver.py RelVal -s HLT:GRun,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_GRun --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016 --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_GRun_MC.root --fileout file:RelVal_Raw_GRun_MC_HLT_RECO.root : FAILED - time: date Fri Aug 12 20:57:58 2016-date Fri Aug 12 20:57:05 2016 s - exit: 23040
cmsDriver.py TTbar_13TeV_TuneCUETP8M1_cfi --conditions auto:run2_mc --fast -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,EI,HLT:@relval25ns,VALIDATION --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot NominalCollision2015 --era Run2_25ns --magField 38T_PostLS1 : FAILED - time: date Fri Aug 12 20:58:23 2016-date Fri Aug 12 20:57:10 2016 s - exit: 23040
cmsDriver.py TTbar_Tauola_13TeV_cfi -s GEN,SIM,DIGI,L1,DIGI2RAW --mc --scenario=pp -n 10 --conditions auto:run2_mc_PRef --relval 9000,50 --datatier "GEN-SIM-RAW" --eventcontent RAWSIM --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2016 --magField 38T_PostLS1 --fileout file:RelVal_Raw_PRef_MC.root : FAILED - time: date Fri Aug 12 20:57:53 2016-date Fri Aug 12 20:57:13 2016 s - exit: 23040
cmsRun /cvmfs/cms-ib.cern.ch/week1/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_8_0_X_2016-08-12-1100/src/HLTrigger/Configuration/test/OnLine_HLT_PRef.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Fri Aug 12 20:57:53 2016-date Fri Aug 12 20:57:13 2016 s - exit: 21504
cmsDriver.py RelVal -s HLT:PRef,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_PRef --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016 --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_PRef_MC.root --fileout file:RelVal_Raw_PRef_MC_HLT_RECO.root : FAILED - time: date Fri Aug 12 20:57:53 2016-date Fri Aug 12 20:57:13 2016 s - exit: 23040
cmsDriver.py TTbar_13TeV_TuneCUETP8M1_cfi --conditions auto:run2_mc --fast -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,EI,HLT:@relval2016,VALIDATION --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot NominalCollision2015 --era Run2_2016 --magField 38T_PostLS1 : FAILED - time: date Fri Aug 12 21:04:11 2016-date Fri Aug 12 20:57:14 2016 s - exit: 23040
cmsDriver.py TTbar_Tauola_8TeV_cfi -s GEN,SIM,DIGI,L1,DIGI2RAW --mc --scenario=pp -n 10 --conditions auto:run1_mc_Fake --relval 9000,50 --datatier "GEN-SIM-RAW" --eventcontent RAWSIM --customise=HLTrigger/Configuration/CustomConfigs.L1T --fileout file:RelVal_Raw_Fake_MC.root : FAILED - time: date Fri Aug 12 20:57:55 2016-date Fri Aug 12 20:57:20 2016 s - exit: 23040
cmsRun /cvmfs/cms-ib.cern.ch/week1/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_8_0_X_2016-08-12-1100/src/HLTrigger/Configuration/test/OnLine_HLT_Fake.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Fri Aug 12 20:57:55 2016-date Fri Aug 12 20:57:20 2016 s - exit: 21504
cmsDriver.py RelVal -s HLT:Fake,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run1_mc_Fake --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --processName=HLTRECO --filein file:RelVal_Raw_Fake_MC.root --fileout file:RelVal_Raw_Fake_MC_HLT_RECO.root : FAILED - time: date Fri Aug 12 20:57:55 2016-date Fri Aug 12 20:57:20 2016 s - exit: 23040
cmsDriver.py TTbar_Tauola_13TeV_cfi -s GEN,SIM,DIGI,L1,DIGI2RAW --mc --scenario=HeavyIons -n 10 --conditions auto:run2_mc_HIon --relval 9000,50 --datatier "GEN-SIM-RAW" --eventcontent RAWSIM --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2016,Run2_HI --magField 38T_PostLS1 --fileout file:RelVal_Raw_HIon_MC.root : FAILED - time: date Fri Aug 12 20:57:59 2016-date Fri Aug 12 20:57:21 2016 s - exit: 23040
cmsRun /cvmfs/cms-ib.cern.ch/week1/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_8_0_X_2016-08-12-1100/src/HLTrigger/Configuration/test/OnLine_HLT_HIon.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Fri Aug 12 20:57:59 2016-date Fri Aug 12 20:57:21 2016 s - exit: 21504
cmsDriver.py RelVal -s HLT:HIon,RAW2DIGI,L1Reco,RECO --mc --scenario=HeavyIons -n 10 --conditions auto:run2_mc_HIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016,Run2_HI --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_HIon_MC.root --fileout file:RelVal_Raw_HIon_MC_HLT_RECO.root : FAILED - time: date Fri Aug 12 20:57:59 2016-date Fri Aug 12 20:57:21 2016 s - exit: 23040
cmsDriver.py TTbar_Tauola_13TeV_cfi -s GEN,SIM,DIGI,L1,DIGI2RAW --mc --scenario=pp -n 10 --conditions auto:run2_mc_Fake1 --relval 9000,50 --datatier "GEN-SIM-RAW" --eventcontent RAWSIM --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_25ns --fileout file:RelVal_Raw_Fake1_MC.root : FAILED - time: date Fri Aug 12 20:58:00 2016-date Fri Aug 12 20:57:26 2016 s - exit: 23040
cmsRun /cvmfs/cms-ib.cern.ch/week1/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_8_0_X_2016-08-12-1100/src/HLTrigger/Configuration/test/OnLine_HLT_Fake1.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Fri Aug 12 20:58:00 2016-date Fri Aug 12 20:57:26 2016 s - exit: 21504
cmsDriver.py RelVal -s HLT:Fake1,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_Fake1 --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_25ns --processName=HLTRECO --filein file:RelVal_Raw_Fake1_MC.root --fileout file:RelVal_Raw_Fake1_MC_HLT_RECO.root : FAILED - time: date Fri Aug 12 20:58:00 2016-date Fri Aug 12 20:57:26 2016 s - exit: 23040
cmsDriver.py TTbar_Tauola_13TeV_cfi -s GEN,SIM,DIGI,L1,DIGI2RAW --mc --scenario=pp -n 10 --conditions auto:run2_mc_PIon --relval 9000,50 --datatier "GEN-SIM-RAW" --eventcontent RAWSIM --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2016 --magField 38T_PostLS1 --fileout file:RelVal_Raw_PIon_MC.root : FAILED - time: date Fri Aug 12 20:58:15 2016-date Fri Aug 12 20:57:41 2016 s - exit: 23040
cmsRun /cvmfs/cms-ib.cern.ch/week1/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_8_0_X_2016-08-12-1100/src/HLTrigger/Configuration/test/OnLine_HLT_PIon.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Fri Aug 12 20:58:15 2016-date Fri Aug 12 20:57:41 2016 s - exit: 21504
cmsDriver.py RelVal -s HLT:PIon,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_PIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016 --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_PIon_MC.root --fileout file:RelVal_Raw_PIon_MC_HLT_RECO.root : FAILED - time: date Fri Aug 12 20:58:15 2016-date Fri Aug 12 20:57:41 2016 s - exit: 23040

davidlange6 · 2016-08-12T19:40:55Z

@mdhildreth - that did not go well - can you have a look?

mdhildreth · 2016-08-12T21:26:54Z

Huh... Yes, I'll take a look...

mdhildreth · 2016-08-12T22:20:24Z

@iahmad-khan @smuzaffar @Degano I forgot about moving the probability map file to externals. Could you please replicate the /cmdist PR 2388 for 80X? It's exactly the same files.

smuzaffar · 2016-08-13T08:24:16Z

please test with cms-sw/cmsdist#2448

cmsbuild · 2016-08-13T08:26:00Z

The tests are being triggered in jenkins.
Using externals from cms-sw/cmsdist#2448
https://cmssdt.cern.ch/jenkins/job/cmsdist-cmssw-test-pr/69/console

cmsbuild · 2016-08-13T09:56:29Z

+1
Tested at: c4ee63d
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15458/69/summary.html

cmsbuild · 2016-12-07T02:43:21Z

Pull request #15458 was updated. @smuzaffar, @civanch, @Dr15Jones, @mdhildreth, @cmsbuild, @davidlange6 can you please check and sign again.

mdhildreth · 2016-12-07T02:49:04Z

Just rebased.

mdhildreth · 2016-12-07T02:49:12Z

please test

cmsbuild · 2016-12-07T02:49:20Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/16822/console Started: 2016/12/07 05:15

cmsbuild · 2016-12-07T05:36:38Z

+1
Tested at: ef931f1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15458/16822/summary.html

cmsbuild · 2016-12-07T05:36:41Z

Comparison job queued.

cmsbuild · 2016-12-07T06:10:51Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15458/16822/summary.html

This reverts commit ff83b47, reversing changes made to 0125196.

Revert "Merge pull request #15458 from mdhildreth/HIPPreMix80X"

cmsbuild added this to the Next CMSSW_8_0_X milestone Aug 12, 2016

cmsbuild added simulation-pending core-pending pending-signatures tests-pending orp-pending comparison-pending labels Aug 12, 2016

cmsbuild added tests-started and removed tests-pending labels Aug 12, 2016

cmsbuild added core-approved and removed core-pending labels Aug 12, 2016

cmsbuild added tests-rejected and removed tests-started labels Aug 12, 2016

cmsbuild added tests-pending and removed tests-rejected labels Aug 13, 2016

cmsbuild mentioned this pull request Aug 13, 2016

backport data-SimTracker-SiStripDigitizer to 80X cms-sw/cmsdist#2448

Merged

cmsbuild added tests-started and removed tests-pending labels Aug 13, 2016

cmsbuild removed the tests-started label Aug 13, 2016

mdhildreth added 3 commits December 7, 2016 03:41

fix remaining issues

b81fa4c

Fix backport issues

c02ee0e

put in failsafe to not run PreMixing and HIP simulation simultaneously

ef931f1

mdhildreth force-pushed the HIPPreMix80X branch from ad13f9f to ef931f1 Compare December 7, 2016 02:43

cmsbuild added core-pending simulation-pending and removed alca-pending analysis-pending db-pending l1-pending reconstruction-rejected labels Dec 7, 2016

cmsbuild added tests-started and removed tests-pending labels Dec 7, 2016

cmsbuild added tests-approved and removed tests-started labels Dec 7, 2016

cmsbuild added comparison-available and removed comparison-pending labels Dec 7, 2016

davidlange6 merged commit ff83b47 into cms-sw:CMSSW_8_0_X Dec 7, 2016

This was referenced Dec 7, 2016

put in failsafe to not run PreMixing and HIP simulation simultaneously #16905

Merged

put in failsafe to not run PreMixing and HIP simulation simultaneously #16906

Merged

mandrenguyen added a commit to mandrenguyen/cmssw that referenced this pull request May 1, 2017

Revert "Merge pull request cms-sw#15458 from mdhildreth/HIPPreMix80X"

311c7cd

This reverts commit ff83b47, reversing changes made to 0125196.

davidlange6 mentioned this pull request May 1, 2017

Revert "Merge pull request #15458 from mdhildreth/HIPPreMix80X" #18528

Merged

davidlange6 added a commit that referenced this pull request May 2, 2017

Merge pull request #18528 from mandrenguyen/revertPR_15458

d203b54

Revert "Merge pull request #15458 from mdhildreth/HIPPreMix80X"

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HIP Killing and PreMixing for 80X #15458

HIP Killing and PreMixing for 80X #15458

mdhildreth commented Aug 12, 2016

mdhildreth commented Aug 12, 2016

cmsbuild commented Aug 12, 2016 •

edited

cmsbuild commented Aug 12, 2016

Dr15Jones commented Aug 12, 2016

cmsbuild commented Aug 12, 2016

davidlange6 commented Aug 12, 2016

mdhildreth commented Aug 12, 2016

mdhildreth commented Aug 12, 2016

smuzaffar commented Aug 13, 2016

cmsbuild commented Aug 13, 2016 •

edited

cmsbuild commented Aug 13, 2016

cmsbuild commented Dec 7, 2016

mdhildreth commented Dec 7, 2016

mdhildreth commented Dec 7, 2016

cmsbuild commented Dec 7, 2016 •

edited

cmsbuild commented Dec 7, 2016

cmsbuild commented Dec 7, 2016

cmsbuild commented Dec 7, 2016

HIP Killing and PreMixing for 80X #15458

HIP Killing and PreMixing for 80X #15458

Conversation

mdhildreth commented Aug 12, 2016

mdhildreth commented Aug 12, 2016

cmsbuild commented Aug 12, 2016 • edited

cmsbuild commented Aug 12, 2016

Dr15Jones commented Aug 12, 2016

cmsbuild commented Aug 12, 2016

davidlange6 commented Aug 12, 2016

mdhildreth commented Aug 12, 2016

mdhildreth commented Aug 12, 2016

smuzaffar commented Aug 13, 2016

cmsbuild commented Aug 13, 2016 • edited

cmsbuild commented Aug 13, 2016

cmsbuild commented Dec 7, 2016

mdhildreth commented Dec 7, 2016

mdhildreth commented Dec 7, 2016

cmsbuild commented Dec 7, 2016 • edited

cmsbuild commented Dec 7, 2016

cmsbuild commented Dec 7, 2016

cmsbuild commented Dec 7, 2016

cmsbuild commented Aug 12, 2016 •

edited

cmsbuild commented Aug 13, 2016 •

edited

cmsbuild commented Dec 7, 2016 •

edited