Optimizations of the HGCAL L1 trigger

[jbsauvan]

This pull request includes the following changes to the HGCAL L1 trigger:

• Optimization of the processing time of the HGCAL trigger. This is mainly a reorganization of loops in the front-end part of the trigger.
• Optimization of the memory footprint of the HGCAL trigger geometry. It now makes use of the detid structure to associate cells to trigger cells and trigger modules, instead of storing the full trigger cells and modules maps. This involves changes in the interface of the geometry.
• Updates in the HGCAL trigger tests
• Some bugfixes

[cmsbuild]

Pull request #15782 was updated. @civanch, @mdhildreth, @cmsbuild, @rekovic, @mulhearn, @davidlange6 can you please check and sign again.

[jbsauvan]

@davidlange6 @lgray
I have updated the code according to the comments above.

[lgray]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/15240/console

[cmsbuild]

+1
Tested at: f8b46db
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15782/15240/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15782/15240/summary.html

[jbsauvan]

@davidlange6
Is the updated code ok for you? Is there something else that could be improved?
Thanks

[jbsauvan]

@civanch @mdhildreth @mulhearn @rekovic Could you check if the updated PR is still ok? (And sign again if this is the case)
@davidlange6 Could you also sign if you are satisfied with the changes?
Thanks

[jbsauvan]

@civanch @mdhildreth @mulhearn @rekovic @davidlange6
If you have no more comments and are satisfied with the changes, could you please consider signing (again, for those who already signed) and merging this PR.
I really would like this to be included in pre13 since it brings significant performance improvement.
Thanks