Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[81X] Add payloads for several new Hcal records in all Global Tags and update Hcal 2017dev tags #16048

Merged
merged 1 commit into from Sep 30, 2016

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Sep 30, 2016

Summary of changes in Global Tags

RunI simulation

  • RunI Ideal scenario : 81X_mcRun1_design_v3 as 81X_mcRun1_design_v2 with the following changes:
    • added payload for HcalSiPMsCharacteristics
    • added payload for HcalSiPMParameters
    • added payload for HcalTPChannelParameters
    • added payload for HcalTPParameters
  • RunI Heavy Ions scenario : 81X_mcRun1_HeavyIon_v3 as 81X_mcRun1_HeavyIon_v2 with the following changes:
    • added payload for HcalSiPMsCharacteristics
    • added payload for HcalSiPMParameters
    • added payload for HcalTPChannelParameters
    • added payload for HcalTPParameters
  • RunI Realistic scenario : 81X_mcRun1_realistic_v3 as 81X_mcRun1_realistic_v2 with the following changes:
    • added payload for HcalSiPMsCharacteristics
    • added payload for HcalSiPMParameters
    • added payload for HcalTPChannelParameters
    • added payload for HcalTPParameters
  • RunI Proton-Lead scenario : 81X_mcRun1_pA_v3 as 81X_mcRun1_pA_v2 with the following changes:
    • added payload for HcalSiPMsCharacteristics
    • added payload for HcalSiPMParameters
    • added payload for HcalTPChannelParameters
    • added payload for HcalTPParameters

RunII simulation

  • RunII Ideal scenario : 81X_mcRun2_design_v8 as 81X_mcRun2_design_v7 with the following changes:
    • added payload for HcalSiPMsCharacteristics
    • added payload for HcalSiPMParameters
    • added payload for HcalTPChannelParameters
    • added payload for HcalTPParameters
    • added payload for HFPhase1PMTParams
  • RunII Asymptotic scenario : 81X_mcRun2_asymptotic_v9 as 81X_mcRun2_asymptotic_v8 with the following changes:
    • added payload for HcalSiPMsCharacteristics
    • added payload for HcalSiPMParameters
    • added payload for HcalTPChannelParameters
    • added payload for HcalTPParameters
    • added payload for HFPhase1PMTParams
  • RunII Startup scenario : 81X_mcRun2_startup_v10 as 81X_mcRun2_startup_v9 with the following changes:
    • added payload for HcalSiPMsCharacteristics
    • added payload for HcalSiPMParameters
    • added payload for HcalTPChannelParameters
    • added payload for HcalTPParameters
    • added payload for HFPhase1PMTParams
  • RunII Proton-Lead scenario : 81X_mcRun2_pA_v3 as 81X_mcRun2_pA_v2 with the following changes:
    • added payload for HcalSiPMsCharacteristics
    • added payload for HcalSiPMParameters
    • added payload for HcalTPChannelParameters
    • added payload for HcalTPParameters
    • added payload for HFPhase1PMTParams
  • RunII CRAFT scenario : 81X_mcRun2cosmics_startup_peak_v8 as 81X_mcRun2cosmics_startup_peak_v7 with the following changes:
    • added payload for HcalSiPMsCharacteristics
    • added payload for HcalSiPMParameters
    • added payload for HcalTPChannelParameters
    • added payload for HcalTPParameters
    • added payload for HFPhase1PMTParams
  • RunII Heavy Ions scenario : 81X_mcRun2_HeavyIon_v9 as 81X_mcRun2_HeavyIon_v8 with the following changes:
    • added payload for HcalSiPMsCharacteristics
    • added payload for HcalSiPMParameters
    • added payload for HcalTPChannelParameters
    • added payload for HcalTPParameters
    • added payload for HFPhase1PMTParams

RunII data

  • RunII Offline processing : 81X_dataRun2_v8 as 81X_dataRun2_v7 with the following changes:
    • added payload for HcalSiPMsCharacteristics
    • added payload for HcalSiPMParameters
    • added payload for HcalTPChannelParameters
    • added payload for HcalTPParameters
    • added payload for HFPhase1PMTParams
  • RunII HLTHI processing : 81X_dataRun2_HLTHI_frozen_v2 as 81X_dataRun2_HLTHI_frozen_v1 with the following changes:
    • added payload for HcalSiPMsCharacteristics
    • added payload for HcalSiPMParameters
    • added payload for HcalTPChannelParameters
    • added payload for HcalTPParameters
    • added payload for HFPhase1PMTParams
  • RunII HLT relval processing : 81X_dataRun2_HLT_relval_v4 as 81X_dataRun2_HLT_relval_v3 with the following changes:
    • added payload for HcalSiPMsCharacteristics
    • added payload for HcalSiPMParameters
    • added payload for HcalTPChannelParameters
    • added payload for HcalTPParameters
    • added payload for HFPhase1PMTParams
  • RunII HLT processing : 81X_dataRun2_HLT_frozen_v2 as 81X_dataRun2_HLT_frozen_v1 with the following changes:
    • added payload for HcalSiPMsCharacteristics
    • added payload for HcalSiPMParameters
    • added payload for HcalTPChannelParameters
    • added payload for HcalTPParameters
    • added payload for HFPhase1PMTParams
  • RunII Offline relval processing : 81X_dataRun2_relval_v10 as 81X_dataRun2_relval_v9 with the following changes:
    • added payload for HcalSiPMsCharacteristics
    • added payload for HcalSiPMParameters
    • added payload for HcalTPChannelParameters
    • added payload for HcalTPParameters
    • added payload for HFPhase1PMTParams

Upgrade

…hannelParameters + HcalTPParameters + HFPhase1PMTParams (run2 + upgrade2017) and updated Hcal development queue
@mmusich
Copy link
Contributor Author

mmusich commented Sep 30, 2016

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 30, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/15466/console

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_8_1_X.

It involves the following packages:

Configuration/AlCa

@ghellwig, @cerminar, @cmsbuild, @franzoni, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @ghellwig, @tocheng this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@mmusich
Copy link
Contributor Author

mmusich commented Sep 30, 2016

@abdoulline @walterjr @kpedro88 @igv4321 @bsunanda, you might want to follow this PR.

@abdoulline
Copy link

Great, thanks a lot!

On Fri, 30 Sep 2016, Marco Musich wrote:

@abdoulline @walterjr @kpedro88 @igv4321 @bsunanda, you might want to follow this PR.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the
thread.[AEx02vk-ebCwmXooE1dgNqNWctWOAc-Uks5qvMgpgaJpZM4KK12t.gif]

@cmsbuild
Copy link
Contributor

@mmusich
Copy link
Contributor Author

mmusich commented Sep 30, 2016

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

@cmsbuild
Copy link
Contributor

@kpedro88
Copy link
Contributor

@davidlange6 please merge ASAP so HCAL can continue Phase1 development

@davidlange6
Copy link
Contributor

i'm I correct to expect physics changed in this PR? @mmusich @kpedro88

@mmusich
Copy link
Contributor Author

mmusich commented Sep 30, 2016

@davidlange6 naively I would say no (the new records are not yet consumed), excepted in wf 10624 (judging from https://hypernews.cern.ch/HyperNews/CMS/get/calibrations/2648.html)

@davidlange6
Copy link
Contributor

Interesting i asked as I saw some..

https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_8_1_X_2016-09-29-2300+16048/16136/10624.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017HCALdev_GenSimFull+DigiFull_2017HCALdev+RecoFull_2017HCALdev+HARVESTFull_2017HCALdev/

On Sep 30, 2016, at 5:19 PM, Marco Musich notifications@github.com wrote:

@davidlange6 naively I would say no (the new records are not yet consumed), excepted in wf 10624 (judging from https://hypernews.cern.ch/HyperNews/CMS/get/calibrations/2648.html)


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

@kpedro88
Copy link
Contributor

Physics changes should only be observed in HCALdev 2017 workflows (10624, 10824) due to the update to HcalLutMetadata. The SiPM and TP objects are not used anywhere currently, because they can't be activated until this PR is merged. @abdoulline and @matz-e can confirm the LUT changes are expected/desired.

@mmusich
Copy link
Contributor Author

mmusich commented Sep 30, 2016

@davidlange6 and indeed it's wf 10624 where we expect them. Am I missing something?

@abdoulline
Copy link

abdoulline commented Sep 30, 2016

I was about to type my comments very much the same as
Kevin did. Matthias @matz-e did change 2017dev HcalLutMetadata on purpose, as previous version was unrealistic.

On Fri, 30 Sep 2016, Kevin Pedro wrote:

Physics changes should only be observed in HCALdev 2017 workflows (10624, 10824) due
to the update to HcalLutMetadata. The SiPM and TP objects are not used anywhere
currently, because they can't be activated until this PR is merged. @abdoulline and
@matz-e can confirm the LUT changes are expected/desired.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the
thread.[AEx02nHxKZRlgHt1DukboCbggfsZ11Veks5qvSpkgaJpZM4KK12t.gif]

@davidlange6
Copy link
Contributor

+1
right thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants