-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[81X] Add payloads for several new Hcal records in all Global Tags and update Hcal 2017dev tags #16048
Conversation
…hannelParameters + HcalTPParameters + HFPhase1PMTParams (run2 + upgrade2017) and updated Hcal development queue
please test |
The tests are being triggered in jenkins. |
A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_8_1_X. It involves the following packages: Configuration/AlCa @ghellwig, @cerminar, @cmsbuild, @franzoni, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
@abdoulline @walterjr @kpedro88 @igv4321 @bsunanda, you might want to follow this PR. |
Great, thanks a lot! On Fri, 30 Sep 2016, Marco Musich wrote:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar |
@davidlange6 please merge ASAP so HCAL can continue Phase1 development |
@davidlange6 naively I would say no (the new records are not yet consumed), excepted in wf 10624 (judging from https://hypernews.cern.ch/HyperNews/CMS/get/calibrations/2648.html) |
Interesting i asked as I saw some..
|
Physics changes should only be observed in HCALdev 2017 workflows (10624, 10824) due to the update to HcalLutMetadata. The SiPM and TP objects are not used anywhere currently, because they can't be activated until this PR is merged. @abdoulline and @matz-e can confirm the LUT changes are expected/desired. |
@davidlange6 and indeed it's wf 10624 where we expect them. Am I missing something? |
I was about to type my comments very much the same as On Fri, 30 Sep 2016, Kevin Pedro wrote:
|
+1 |
Summary of changes in Global Tags
RunI simulation
HcalSiPMsCharacteristics
HcalSiPMParameters
HcalTPChannelParameters
HcalTPParameters
HcalSiPMsCharacteristics
HcalSiPMParameters
HcalTPChannelParameters
HcalTPParameters
HcalSiPMsCharacteristics
HcalSiPMParameters
HcalTPChannelParameters
HcalTPParameters
HcalSiPMsCharacteristics
HcalSiPMParameters
HcalTPChannelParameters
HcalTPParameters
RunII simulation
HcalSiPMsCharacteristics
HcalSiPMParameters
HcalTPChannelParameters
HcalTPParameters
HFPhase1PMTParams
HcalSiPMsCharacteristics
HcalSiPMParameters
HcalTPChannelParameters
HcalTPParameters
HFPhase1PMTParams
HcalSiPMsCharacteristics
HcalSiPMParameters
HcalTPChannelParameters
HcalTPParameters
HFPhase1PMTParams
HcalSiPMsCharacteristics
HcalSiPMParameters
HcalTPChannelParameters
HcalTPParameters
HFPhase1PMTParams
HcalSiPMsCharacteristics
HcalSiPMParameters
HcalTPChannelParameters
HcalTPParameters
HFPhase1PMTParams
HcalSiPMsCharacteristics
HcalSiPMParameters
HcalTPChannelParameters
HcalTPParameters
HFPhase1PMTParams
RunII data
HcalSiPMsCharacteristics
HcalSiPMParameters
HcalTPChannelParameters
HcalTPParameters
HFPhase1PMTParams
HcalSiPMsCharacteristics
HcalSiPMParameters
HcalTPChannelParameters
HcalTPParameters
HFPhase1PMTParams
HcalSiPMsCharacteristics
HcalSiPMParameters
HcalTPChannelParameters
HcalTPParameters
HFPhase1PMTParams
HcalSiPMsCharacteristics
HcalSiPMParameters
HcalTPChannelParameters
HcalTPParameters
HFPhase1PMTParams
HcalSiPMsCharacteristics
HcalSiPMParameters
HcalTPChannelParameters
HcalTPParameters
HFPhase1PMTParams
Upgrade
HcalSiPMsCharacteristics
HcalSiPMParameters
HcalTPChannelParameters
HcalTPParameters
HFPhase1PMTParams
HcalSiPMsCharacteristics
HcalSiPMParameters
HcalTPChannelParameters
HcalTPParameters
HFPhase1PMTParams
HcalLutMetadata
HcalSiPMCharacteristics
HcalSiPMParameters