Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert FEStatus to run based. Get LS reports from FEMap instead. #16305

Merged
merged 1 commit into from Oct 25, 2016

Conversation

mbandrews
Copy link
Contributor

@mbandrews mbandrews commented Oct 21, 2016

Fix issue in offline DQM where FE Status Flag plots only display stats from last LS

  • Harvesting step in offline DQM causes LS-based plots to only keep stats from the last LS due to multi-threading, which affects all FE Status Flag plots in offline DQM since the introduction of PR Fix LS reports: only use RawData. #15411 (starting CMSSW 8_0_18 or ~run 279498).
  • Revert changes introduced in that PR: set ecalRawDataClient.MEs.QualitySummary and ecalRawDataTask.MEs.FEStatus to be run-based again
  • To maintain functionality of GOOD channel reporting introduced in that PR, get RawData info instead from ecalRawDataTask.MEs.FEStatusErrMapByLumi (introduced later, in PR Duplicate key MEs for by lumi reset. #16112) which, by design, is already reset every LS, and is filled independently of the affected MEs above.

In conjunction with 80X PR #16304.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mbandrews (Michael Andrews) for CMSSW_8_1_X.

It involves the following packages:

DQM/EcalMonitorClient
DQM/EcalMonitorTasks

@cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@argiro this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 25, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/15947/console

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 6f1691a into cms-sw:CMSSW_8_1_X Oct 25, 2016
@cmsbuild
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants