Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pr90x L1T Stage2 for Phase-2 bis #17588

Conversation

rekovic
Copy link
Contributor

@rekovic rekovic commented Feb 21, 2017

This is a replacement for the reverted #17248.
It is augmented by

For completion, below is the original PR info:

#17248 PR 90x for change in configuration to use L1T Stage2 (as opposed to L1T Legacy) in Phase2 era. This PR also includes (needed to pass tests) #17260 which fixed crashes in HCAL TPs for Phase2

This PR is needed for Phase2 MC Production.

Details:

  • Use phase2_common era modifier to
    • switch in L1T configuration to use Stage2
    • configure conditions of L1T Muon, Calorimeter, and Global (as in Stage2)
    • configure L1T RAW2DIGI and DIGI2RAW to use Stage2 products
  • Include back in simHcalTrigPrimitiveDigis and simHcalTTPDigis into hcalDigiSequence

@cmsbuild cmsbuild added this to the Next CMSSW_9_0_X milestone Feb 21, 2017
@rekovic
Copy link
Contributor Author

rekovic commented Feb 21, 2017

please test

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @rekovic for CMSSW_9_0_X.

It involves the following packages:

L1Trigger/Configuration
L1Trigger/L1TMuonEndCap

@cmsbuild, @rekovic, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @kreczko this is something you requested to watch as well.
@davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 21, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/17901/console Started: 2017/02/21 14:17

@rekovic
Copy link
Contributor Author

rekovic commented Feb 21, 2017

will close. apparently did not pick up #17248

@rekovic rekovic closed this Feb 21, 2017
@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

@rekovic rekovic deleted the pr90x-L1TStage2-forPhase2-bis branch February 22, 2017 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants