pr90x L1T Phase2: Add Stage2 products To RawCollector #17462
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ommon, missed previously.
|
A new Pull Request was created by @rekovic for CMSSW_9_0_X. It involves the following packages: L1Trigger/Configuration @cmsbuild, @rekovic, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
|
@rekovic this has a merge conflict @davidlange6 will #17248 be un-reverted as is, or does it need to be remade? |
|
On Feb 17, 2017, at 2:38 PM, Kevin Pedro ***@***.***> wrote:
@rekovic this has a merge conflict
@davidlange6 will #17248 be un-reverted as is, or does it need to be remade?
i can make a pr that reverts the revert (it currently can merge) - but I won’t merge it until the underlying problems are fixed, so it doesn’t seem to be the right approach
…
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
@davidlange6 that's what I thought, thanks |
|
@davidlange6 |
This was referenced Feb 21, 2017
|
@rekovic should this be closed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an addendum to already merged and then reverted PR #17248.
When re-reverted #17248, complement it with this PR.
Details:
Add CaloLaye2, uGMT, and uGT products to the RawCollector (previously missed).