Pr90x L1T stage2 for phase2 fix #17598
Conversation
…ommon, missed previously.
This reverts commit 432c9be. Conflicts: CalibCalorimetry/HcalTPGAlgos/src/HcaluLUTTPGCoder.cc
|
A new Pull Request was created by @rekovic for CMSSW_9_0_X. It involves the following packages: L1Trigger/Configuration @civanch, @mdhildreth, @cmsbuild, @rekovic, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
|
please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
+1 |
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar |
|
|
||
| # | ||
| # Legacy Trigger: | ||
| # | ||
| if not (stage1L1Trigger.isChosen() or stage2L1Trigger.isChosen()): | ||
| if not (stage1L1Trigger.isChosen() or stage2L1Trigger.isChosen() or phase2_common.isChosen()): |
There was a problem hiding this comment.
Hi @rekovic - two issues
- we agreed to clean up these isChosen..
- you don't want to add phase2_common here, rather, you want to add what trigger you want into phase2_common era definition, Then this code is unchanged.
There was a problem hiding this comment.
Done. Now in #17629.
| @@ -9,7 +9,8 @@ | |||
| +simHcalDigis | |||
| *simHcalTTPDigis) | |||
|
|
|||
| _phase2_hcalDigiSequence = hcalDigiSequence.copyAndExclude([simHcalTriggerPrimitiveDigis,simHcalTTPDigis]) | |||
| #_phase2_hcalDigiSequence = hcalDigiSequence.copyAndExclude([simHcalTriggerPrimitiveDigis,simHcalTTPDigis]) | |||
There was a problem hiding this comment.
these lines can just be removed. Perhaps its worth a small PR with just this change as the first step?
There was a problem hiding this comment.
Done. Now in #17628 .
|
-1 |
I did not understand your question. Could you clarify, please? |
This PR invokes Stage2 L1Trigger for Phase2. It supersedes #17248 and #17462.
It contains:
Original #17248 problems due to HCAL TPs is now fixed (merged #17540).
Overflooding messages from EMTF are silenced as well.
For completion, below is the original PR info:
#17248 PR 90x for change in configuration to use L1T Stage2 (as opposed to L1T Legacy) in Phase2 era. This PR also includes (needed to pass tests) #17260 which fixed crashes in HCAL TPs for Phase2
This PR is needed for Phase2 MC Production.
Details: