New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GT updates for 900pre5 with Summer16 JECs, GEM reco geometry and ESEE Intercalib #17649
GT updates for 900pre5 with Summer16 JECs, GEM reco geometry and ESEE Intercalib #17649
Conversation
A new Pull Request was created by @arunhep (Arun Kumar) for CMSSW_9_0_X. It involves the following packages: Configuration/AlCa @ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
@davidlange6 |
|
We got a larger (x10) statistics for TTBar 2016 with pile up. We confirm the outcome when looking at the profile of the average JEC's applied as a function of eta and pt (red=new GT's, blue=GT's as in the 90x currently - same conventions as the plots of last week):
|
On 3/6/17 2:29 AM, Giovanni Franzoni wrote:
@slava77 <https://github.com/slava77> @schoef
<https://github.com/schoef> can you give us hints
I don't have any specific comments based on the posted plots.
|
Thanks @slava77 |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar |
related to this 80x PR |
Summary of changes in Global TagsRunII simulation
RunI data
RunII data
Upgrade
|
hello @davidlange6 There are other AlCa changes we want to deploy now. Test would be cleaner and more meaningful if we could have an IB including these changes. thanks! |
Ecal also would be interested in knowing if we can move forward .. |
hello @davidlange6 |
hello @davidlange6 |
actually I missed in 91x - why gem reco geometry in run1? Did we not manage to fix the code to understand if there are gems or not? |
@davidlange6 - it's in 2017 onwards. What makes you think it is in run 1? |
I read the comments from @arunhep.EG:
• RunI Offline processing : 90X_dataRun2_v5 as 90X_dataRun2_v4 with the following changes:
• Summer16 JECs
• ESEE Intercalibration mentioned here #17219
• GEM RECO geometry
… On Mar 13, 2017, at 5:09 PM, Ianna Osborne ***@***.***> wrote:
@davidlange6 - it's in 2017 onwards. What makes you think it is in run 1?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
@davidlange6 - It looks like it's the same GT queue for both run 1 and run 2. The tags in data queues have IOVs. @arunhep and @franzoni, please confirm. |
that indeed makes sense - so what is the IOV for the GEM reco geometry addition? Is it just the comment that is incorrect?
… On Mar 13, 2017, at 5:45 PM, Ianna Osborne ***@***.***> wrote:
@davidlange6 - It looks like it's the same GT queue for both run 1 and run 2. The tags in data queues have IOVs. @arunhep and @franzoni, please confirm.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
@davidlange6 @ianna yes as you mentioned data GTs contain tags with multiple IOVs, but the GEM geometry tag has one only one IOV (1) covering actually whole history. Will this affect the Run-I workflows? Because if version of code relevant for Run-I is not consuming this record then it should not affect anything. @franzoni can you please confirm? |
lets fix the IOV to match reality in any case...
… On Mar 13, 2017, at 5:53 PM, Arun Kumar ***@***.***> wrote:
@davidlange6 @ianna yes as you mentioned data GTs contain tags with multiple IOVs, but the GEM geometry tag has one only one IOV (1) covering actually whole history. Will this affect the Run-I workflows? Because if version of code relevant for Run-I is not consuming this record then it should not affect anything. @franzoni can you please confirm?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
@arunhep - standard run 1 code does not consume this record. GEM producer which needs it is enabled from 2017 era onwards. |
hello @ianna @david We concur, however, that an introducing 2 IOV's is the cleaner solution @ianna can you provide the tag ~now / today ? Cheers and thanks, |
Description is updated below.