Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GT updates for 900pre5 with Summer16 JECs, GEM reco geometry and ESEE Intercalib #17649

Conversation

arunhep
Copy link
Contributor

@arunhep arunhep commented Feb 28, 2017

Description is updated below.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @arunhep (Arun Kumar) for CMSSW_9_0_X.

It involves the following packages:

Configuration/AlCa

@ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @ghellwig, @tocheng this is something you requested to watch as well.
@davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@arunhep
Copy link
Contributor Author

arunhep commented Feb 28, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 28, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18001/console Started: 2017/02/28 11:21

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@franzoni
Copy link

@davidlange6
we would like this considered at the ORP today
we're waiting for the tests to finish to sign it

@cmsbuild
Copy link
Contributor

@arunhep arunhep changed the title GT updates for 900pre5 GT updates for 900pre5 with Summer16 JECs, GEM reco geometry and ESEE Intercalib Mar 1, 2017
@franzoni
Copy link

franzoni commented Mar 1, 2017

  • GEM RECO geometry --> not expected to yield any change, simply added a record to support future eras which will demand the present of GEM reco geometry

  • ESEE Intercalibration --> only affects 2016D, not probed by the short matrix; @cmkuo tested locally [here](https://github.com/cms-sw/cmssw/pull/17219#issuecomment-280834478)

  • impact of JEC's update in data 2016B expected and understood, see link and plot
    jetmet__jet_cleanedak4pfjets_dijet_jetenergycorrvspt

  • impact of JEC's update in MC not understood.

    • The update is visible in the TTBar with 50ns pileup (plots)
      50_ns_jetmet__jet_cleanedak4pfjetschs_dijet_jetenergycorrvseta

    • The update is NOT visible in the TTBar with 25ns pileup (plots)

We'll update this PR when understood.
@schoef @slava77

@franzoni
Copy link

franzoni commented Mar 6, 2017

We got a larger (x10) statistics for TTBar 2016 with pile up. We confirm the outcome when looking at the profile of the average JEC's applied as a function of eta and pt (red=new GT's, blue=GT's as in the 90x currently - same conventions as the plots of last week):

  • in the 50ns we observe differences

50ns_eta_ttbar_50200_1

  • in the 25ns there's no change

25ns_pt_ttbar_25200_1
25ns_eta_ttbar_25200_1

  • in the 2017 (noPU) there's no change, either

@slava77 @schoef can you give us hints

@slava77
Copy link
Contributor

slava77 commented Mar 6, 2017 via email

@franzoni
Copy link

franzoni commented Mar 6, 2017

Thanks @slava77
We've gotten feedback form Henning (JetMet) and will update this chat in the next hours with a summary.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2017

@franzoni
Copy link

franzoni commented Mar 7, 2017

  • the update being deployed here to JEC's here only involves, for MC, their uncertainties
  • as such, no differences are expected on the profiles vs eta/pt of the consumed JEC corrections, which is now the case for the 25ns and 50ns alike (for 2017 it's already been reported earlier) - verified in the relmon plots
  • the difference previously noted on the 50ns plots stemmed from the fact that the 2016 startup global tag holds JEC's derived for 50ns; the tags we're deploying here are intended for 25 ns instead, hence we reverted the change to leave in 2016 startup. Now now no changes on the profiles vs eta/pt of the consumed JEC's are visible
  • changes in MET, which probers also the JEC errors, proves that there is an effect of deploying the new tags, see:
    jetmet__metvalidation_slimmedmets_metunc_jetendown
    jetmet__metvalidation_slimmedmets_metunc_jetenup

Many Thanks to @Kirshen and @schoef

@franzoni
Copy link

franzoni commented Mar 7, 2017

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2017

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@franzoni
Copy link

franzoni commented Mar 7, 2017

related to this 80x PR
which needs this PR to be merged/tested to trigger a backport
( Es conditions and code fix among the features needed for the legacy rereco )

@arunhep
Copy link
Contributor Author

arunhep commented Mar 7, 2017

Summary of changes in Global Tags

RunII simulation

RunI data

RunII data

Upgrade

@franzoni
Copy link

franzoni commented Mar 9, 2017

hello @davidlange6
would it be possible to have this PR merged ?
What should be provide for that to happen ?
( the chages are the same already merged in 91x #17702 )

There are other AlCa changes we want to deploy now. Test would be cleaner and more meaningful if we could have an IB including these changes.

thanks!

@argiro
Copy link
Contributor

argiro commented Mar 10, 2017

Ecal also would be interested in knowing if we can move forward ..

@franzoni
Copy link

hello @davidlange6
would it be possible to have this PR merged ?
What should be provide for that to happen ?
( the chages are the same already merged in 91x #17702 )

@franzoni
Copy link

hello @davidlange6
would it be possible to have this PR merged ?
What should be provide for that to happen ?
( the changes are the same already merged in 91x #17702 )

@davidlange6
Copy link
Contributor

actually I missed in 91x - why gem reco geometry in run1? Did we not manage to fix the code to understand if there are gems or not?
@ianna

@ianna
Copy link
Contributor

ianna commented Mar 13, 2017

@davidlange6 - it's in 2017 onwards. What makes you think it is in run 1?

@davidlange6
Copy link
Contributor

davidlange6 commented Mar 13, 2017 via email

@ianna
Copy link
Contributor

ianna commented Mar 13, 2017

@davidlange6 - It looks like it's the same GT queue for both run 1 and run 2. The tags in data queues have IOVs. @arunhep and @franzoni, please confirm.

@davidlange6
Copy link
Contributor

davidlange6 commented Mar 13, 2017 via email

@arunhep
Copy link
Contributor Author

arunhep commented Mar 13, 2017

@davidlange6 @ianna yes as you mentioned data GTs contain tags with multiple IOVs, but the GEM geometry tag has one only one IOV (1) covering actually whole history. Will this affect the Run-I workflows? Because if version of code relevant for Run-I is not consuming this record then it should not affect anything. @franzoni can you please confirm?

@davidlange6
Copy link
Contributor

davidlange6 commented Mar 13, 2017 via email

@ianna
Copy link
Contributor

ianna commented Mar 13, 2017

@arunhep - standard run 1 code does not consume this record. GEM producer which needs it is enabled from 2017 era onwards.

@franzoni
Copy link

hello @ianna @david
the record not being consumed in the run1 standard sequences
won't pose issues to the content / physics performance

We concur, however, that an introducing 2 IOV's is the cleaner solution
Thanks for pointing this out!

@ianna can you provide the tag ~now / today ?
@davidlange6 we'll have to add a commit to both #17886 and #17905 also for other updates - we'll make sure we'll also replace the tag in the data GT to add the IOV. We'll use the same run number we've used for the HCAL phaseI 287446

Cheers and thanks,
@arunhep and Giovanni

@franzoni
Copy link

lets fix the IOV to match reality in any case...

addressed here, given that #17886 will supersede this PR

@arunhep arunhep closed this Mar 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants