Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates on DQMOffline/Trigger for Muons #19512

Closed
wants to merge 26 commits into from

Conversation

sscruz
Copy link
Contributor

@sscruz sscruz commented Jul 3, 2017

Backport from #18968

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19512/21079/summary.html

Comparison Summary:

  • You potentially added 488 lines to the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 22
  • DQMHistoTests: Total histograms compared: 1813506
  • DQMHistoTests: Total failures: 44578
  • DQMHistoTests: Total nulls: 1729
  • DQMHistoTests: Total successes: 1767033
  • DQMHistoTests: Total skipped: 166
  • DQMHistoTests: Total Missing objects: 0
  • Checked 90 log files, 14 edm output root files, 22 DQM output files

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 6, 2017

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_9_3_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@fwyzard
Copy link
Contributor

fwyzard commented Aug 3, 2017

hold

@fwyzard
Copy link
Contributor

fwyzard commented Aug 3, 2017

@sscruz can you check if this PR is included #19961 ?

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 3, 2017

Pull request has been put on hold by @fwyzard
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

@mtosi
Copy link
Contributor

mtosi commented Aug 8, 2017

@sscruz can you please check if the code in this PR is already included in #19961 ?
thanks

@sscruz
Copy link
Contributor Author

sscruz commented Aug 8, 2017

Hi @mtosi, I just checked and my code seems to be in place in #19961. However, I'm on holidays so I haven't been able to run #19961 to see if I still everything is still working properly.
Sorry about this,
Sergio

@mtosi
Copy link
Contributor

mtosi commented Aug 8, 2017 via email

@sscruz
Copy link
Contributor Author

sscruz commented Aug 17, 2017

hi @mtosi , I managed to run #19961 and all the histograms introduced by this PR seem to be in place.
Sorry this took a bit!

@mtosi
Copy link
Contributor

mtosi commented Aug 17, 2017 via email

@mtosi
Copy link
Contributor

mtosi commented Oct 12, 2017

@sscruz
let me cross check
your developments are in #19961
and #19961 is in #20620, which is close to be merged (hopefully)

=> shall we close this PR ?

@sscruz
Copy link
Contributor Author

sscruz commented Oct 13, 2017

hi @mtosi ,
yes, that is correct!

@mtosi
Copy link
Contributor

mtosi commented Oct 13, 2017

then, please
@sscruz @davidlange6 could we please close this PR ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants