Updates on DQMOffline/Trigger for Muons #18968

sscruz · 2017-05-26T16:26:44Z

Improvements in muon Trigger Offline DQM:

Efficiency of dimuon paths calculated using reference method
Efficiency of DZ cut monitored
Multirun plots implemented

…nly booked for doublemuon

cmsbuild · 2017-05-26T16:27:02Z

A new Pull Request was created by @sscruz for master.

It involves the following packages:

DQMOffline/Trigger

@cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@battibass, @mtosi, @jhgoh, @calderona, @HuguesBrun, @trocino, @rociovilar this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

mtosi · 2017-05-26T16:54:02Z

DQMOffline/Trigger/python/HLTMuonOfflineAnalyzer_cfi.py

@@ -79,15 +78,19 @@
    ## Both 1D and 2D plots use the binnings defined here
    binParams = cms.untracked.PSet(
        ## parameters for fixed-width plots
-        NVertex    = cms.untracked.vdouble( 20,  1,   50),
+        NVertex    = cms.untracked.vdouble( 20,  1,   60),


I would suggest you to slightly increase it

To what? 65?

@mtosi how about ( 20, 1, 100)?

mtosi · 2017-05-26T16:55:07Z

DQMOffline/Trigger/python/HLTMuonOfflineAnalyzer_cfi.py

@@ -79,15 +78,19 @@
    ## Both 1D and 2D plots use the binnings defined here
    binParams = cms.untracked.PSet(
        ## parameters for fixed-width plots
-        NVertex    = cms.untracked.vdouble( 20,  1,   50),
+        NVertex    = cms.untracked.vdouble( 20,  1,   60),
+        NVertexFine= cms.untracked.vdouble( 40,  1,   60),
        eta        = cms.untracked.vdouble( 20,  -2.40,   2.40),


couldn't you make use of a variable bin width ?

@BenjaminRS Does 0,5 and then from 10 to 55,with a step of 3 sound reasonable?

mtosi · 2017-05-26T16:58:40Z

https://goo.gl/843SVr ok, these range has been updated for the high PU fill last year .. but in this plots black and blue are 2017 runs mia

…

On Fri, May 26, 2017 at 6:55 PM, Benjamin Radburn-Smith < ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In DQMOffline/Trigger/python/HLTMuonOfflineAnalyzer_cfi.py <#18968 (comment)>: > @@ -79,15 +78,19 @@ ## Both 1D and 2D plots use the binnings defined here binParams = cms.untracked.PSet( ## parameters for fixed-width plots - NVertex = cms.untracked.vdouble( 20, 1, 50), + NVertex = cms.untracked.vdouble( 20, 1, 60), To what? 65? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#18968 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEt586QVRk-tMmSY617w0QWhrIto4vfsks5r9wP8gaJpZM4NnzWO> .

mtosi · 2017-05-26T19:59:50Z

increase the range ! did you see the plot on the offline DQM ? mia

…

On Fri, May 26, 2017 at 9:32 PM, sscruz ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In DQMOffline/Trigger/python/HLTMuonOfflineAnalyzer_cfi.py <#18968 (comment)>: > @@ -79,15 +78,19 @@ ## Both 1D and 2D plots use the binnings defined here binParams = cms.untracked.PSet( ## parameters for fixed-width plots - NVertex = cms.untracked.vdouble( 20, 1, 50), + NVertex = cms.untracked.vdouble( 20, 1, 60), + NVertexFine= cms.untracked.vdouble( 40, 1, 60), eta = cms.untracked.vdouble( 20, -2.40, 2.40), @BenjaminRS <https://github.com/benjaminrs> Does 0,5 and then from 10 to 55,with a step of 3 sound reasonable? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#18968 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEt58xiTXrupOE2Bx50G0iwyVUFyUEEKks5r9yiygaJpZM4NnzWO> .

mtosi · 2017-05-26T20:26:14Z

why don't you simply do 100,0,100 ?

…

On 26 May 2017, at 21:32, sscruz ***@***.***> wrote: @sscruz commented on this pull request. In DQMOffline/Trigger/python/HLTMuonOfflineAnalyzer_cfi.py: > @@ -79,15 +78,19 @@ ## Both 1D and 2D plots use the binnings defined here binParams = cms.untracked.PSet( ## parameters for fixed-width plots - NVertex = cms.untracked.vdouble( 20, 1, 50), + NVertex = cms.untracked.vdouble( 20, 1, 60), + NVertexFine= cms.untracked.vdouble( 40, 1, 60), eta = cms.untracked.vdouble( 20, -2.40, 2.40), @BenjaminRS Does 0,5 and then from 10 to 55,with a step of 3 sound reasonable? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

sscruz · 2017-05-27T08:16:11Z

Will we have statistics for that? This is to measure efficiencies, not distributions...

mtosi · 2017-05-27T08:43:14Z

then, make a variable binning coarse bin size where you are not expecting entries, and finer between 20 and 60, i would say

…

On 27 May 2017, at 10:16, sscruz ***@***.***> wrote: Will we have statistics for that? This is to measure efficiencies, not distributions... — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

cmsbuild · 2017-06-22T15:54:42Z

Pull request #18968 was updated. @vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @vanbesien, @davidlange6 can you please check and sign again.

dmitrijus · 2017-06-23T14:02:37Z

Please remove member DQMStore* theDQM from HLTMuonRefMethod.
It's not introduced by this PR, but accessing DQM store is forbidden!

cmsbuild · 2017-06-27T17:17:34Z

Pull request #18968 was updated. @vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @vanbesien, @davidlange6 can you please check and sign again.

fwyzard · 2017-07-02T11:27:47Z

@cmsbuild, please test

cmsbuild · 2017-07-02T11:28:05Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/21061/console Started: 2017/07/02 16:18

cmsbuild · 2017-07-02T15:40:40Z

+1
Tested at: 6cb6a92
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18968/21061/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
5387f33
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18968/21061/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18968/21061/git-merge-result

cmsbuild · 2017-07-02T15:40:43Z

Comparison job queued.

cmsbuild · 2017-07-02T21:29:52Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18968/21061/summary.html

Comparison Summary:

You potentially added 510 lines to the logs
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 22
DQMHistoTests: Total histograms compared: 1755973
DQMHistoTests: Total failures: 15151
DQMHistoTests: Total nulls: 1021
DQMHistoTests: Total successes: 1739635
DQMHistoTests: Total skipped: 166
DQMHistoTests: Total Missing objects: 0
Checked 90 log files, 14 edm output root files, 22 DQM output files

mtosi · 2017-07-03T09:15:57Z

@sscruz, I think we need the backport to 92x ...

sscruz · 2017-07-03T09:21:50Z

Hi @mtosi , I've added a PR to 92 (#19512)
Cheers!
Sergio

mtosi · 2017-07-03T09:23:50Z

thanks !

…

On Mon, Jul 3, 2017 at 11:21 AM, sscruz ***@***.***> wrote: Hi @mtosi <https://github.com/mtosi> , I've added a PR to 92 (#19512 <#19512>) Cheers! Sergio — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#18968 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEt589wDUgPOSifmbJbakWPPMJZCzs_jks5sKLKwgaJpZM4NnzWO> .

davidlange6 · 2017-07-04T14:38:07Z

merge

This PR includes a backport of the following PRs: - cms-sw#18172 - cms-sw#18950 - cms-sw#18959 - cms-sw#18968 - cms-sw#18971 - cms-sw#19023 - cms-sw#19046 - cms-sw#19078 - cms-sw#19119 - cms-sw#19178 - cms-sw#19290 - cms-sw#19293 - cms-sw#19294 - cms-sw#19490 - cms-sw#19499 - cms-sw#19577 - cms-sw#19585 - cms-sw#19596 - cms-sw#19599 - cms-sw#19627 - cms-sw#19689 - cms-sw#19694 - cms-sw#19703 - cms-sw#19781 - cms-sw#19794 plus the older ones, contained in DQMOffline/Trigger and HLTriggerOffline. It synchronises with CMSSW_9_3_X - DQMServices/ClientConfig - DQMOffline/Configuration - DQMOffline/Trigger - HLTriggerOffline/Btag - HLTriggerOffline/Higgs - HLTriggerOffline/SUSYBSM - HLTriggerOffline/Tau - HLTriggerOffline/Top

sscruz added 15 commits May 22, 2017 10:59

Reference trigger efficiency implemented

550c0c3

Latest improvements and removing couts

7bffe6d

Small bugfix

435a9a2

Adding missing add

af83118

Improvements: 2d plots and others

8438bca

Move MR harvesting to a different directory

50a54ed

New single/dimuon paths, fix dz binning, referenceEfficiency histos o…

4bd6f53

…nly booked for doublemuon

Removing cout

48da751

Fixing DZ histos names

463da56

Removing HLT_L2Mu10 as it's not needed

39cc108

Adding DZ vs NVertex plot

812a91a

Fixing DZ efficiency and adding phi vs eta plot

60a5ecd

Fix HEP2017 binning

4a2305c

Tuning HEP2017 binning

1c2f218

fixing stupid typo

52699a4

cmsbuild added this to the CMSSW_9_2_X milestone May 26, 2017

cmsbuild added comparison-pending dqm-pending orp-pending pending-signatures tests-pending labels May 26, 2017

mtosi reviewed May 26, 2017

View reviewed changes

Changing nvert binning

9480c97

smuzaffar modified the milestones: CMSSW_9_3_X, CMSSW_9_2_X Jun 26, 2017

Addressing Dmitrijus comment

6cb6a92

cmsbuild added tests-started and removed tests-pending labels Jul 2, 2017

cmsbuild added tests-approved and removed tests-started labels Jul 2, 2017

cmsbuild added comparison-available and removed comparison-pending labels Jul 2, 2017

sscruz mentioned this pull request Jul 3, 2017

Updates on DQMOffline/Trigger for Muons #19512

Closed

cmsbuild merged commit 2af1298 into cms-sw:master Jul 4, 2017

fwyzard mentioned this pull request Jul 28, 2017

backport HLT DQM for menu v2.1 to CMSSW 9.2.x #19961

Closed

fwyzard mentioned this pull request Aug 7, 2017

Adding HLT_Mu17_TrkIsoVVL_Mu8_TrkIsoVVL_DZ_Mass3p8 to offline DQM #19595

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Updates on DQMOffline/Trigger for Muons #18968

Updates on DQMOffline/Trigger for Muons #18968

sscruz commented May 26, 2017

cmsbuild commented May 26, 2017

mtosi May 26, 2017

BenjaminRS May 26, 2017

BenjaminRS May 26, 2017 •

edited

mtosi May 26, 2017

sscruz May 26, 2017

mtosi commented May 26, 2017 via email

mtosi commented May 26, 2017 via email

mtosi commented May 26, 2017 via email

sscruz commented May 27, 2017

mtosi commented May 27, 2017 via email

cmsbuild commented Jun 22, 2017

dmitrijus commented Jun 23, 2017

cmsbuild commented Jun 27, 2017

fwyzard commented Jul 2, 2017

cmsbuild commented Jul 2, 2017 •

edited

cmsbuild commented Jul 2, 2017

cmsbuild commented Jul 2, 2017

cmsbuild commented Jul 2, 2017

mtosi commented Jul 3, 2017

sscruz commented Jul 3, 2017

mtosi commented Jul 3, 2017 via email

davidlange6 commented Jul 4, 2017

Updates on DQMOffline/Trigger for Muons #18968

Updates on DQMOffline/Trigger for Muons #18968

Conversation

sscruz commented May 26, 2017

cmsbuild commented May 26, 2017

mtosi May 26, 2017

Choose a reason for hiding this comment

BenjaminRS May 26, 2017

Choose a reason for hiding this comment

BenjaminRS May 26, 2017 • edited

Choose a reason for hiding this comment

mtosi May 26, 2017

Choose a reason for hiding this comment

sscruz May 26, 2017

Choose a reason for hiding this comment

mtosi commented May 26, 2017 via email

mtosi commented May 26, 2017 via email

mtosi commented May 26, 2017 via email

sscruz commented May 27, 2017

mtosi commented May 27, 2017 via email

cmsbuild commented Jun 22, 2017

dmitrijus commented Jun 23, 2017

cmsbuild commented Jun 27, 2017

fwyzard commented Jul 2, 2017

cmsbuild commented Jul 2, 2017 • edited

cmsbuild commented Jul 2, 2017

cmsbuild commented Jul 2, 2017

cmsbuild commented Jul 2, 2017

mtosi commented Jul 3, 2017

sscruz commented Jul 3, 2017

mtosi commented Jul 3, 2017 via email

davidlange6 commented Jul 4, 2017

BenjaminRS May 26, 2017 •

edited

cmsbuild commented Jul 2, 2017 •

edited