EMTF 2017 PR #2 - 2017 DataFormats

[abrinke1]

Part 2 of set of PRs following PR #19741

Updated EMTF internal data formats for 2017, primarily adding info for RPCs, and adding new formats ("EMTFRoad") and functionalities for the upgraded EMTF emulator.

Temporarily have both 2016 and 2017 data formats at the same time, so some old and some new EMTF modules (in the intermediate PRs) can run at the same time.

Updated EMTF unpacker including several major improvements:

• Input link monitoring in EMTFBlockCounters.cc
• Unpack CPPF output in EMTFBlockRPC.cc
• Significantly improved hit-to-track matching in EMTFBlockSP.cc

Still outputs empty collections of EMTFHit2016 and EMTFTrack2016 so we don't break the DQM sequences.

Changes grouped as follows:
DataFormats/L1TMuon/interface/EMTF/*.h

• Updated unpacked objects to mirror changes in RAW EMTF DAQ output

EventFilter/L1TRawToDigi/plugins/implementations_stage2/EMTFBlockX.cc

• Updated unpacking functions

EventFilter/L1TRawToDigi/plugins/implementations_stage2/EMTFBlockX.h

• All deleted, not needed; match convention used by other unpacker

L1Trigger/L1TMuonEndCap/interface/TrackTools.X

• New helper functions

[cmsbuild]

A new Pull Request was created by @abrinke1 for master.

It involves the following packages:

DQM/L1TMonitor
DataFormats/L1TMuon
EventFilter/L1TRawToDigi
L1Trigger/L1TMuonEndCap

@vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @rekovic, @vanbesien, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @kreczko, @thomreis this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

[rekovic]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/21471/console Started: 2017/07/14 14:23

[rekovic]

oops,
this should be tested after #19741 is merged.

[thomreis]

No it should be fine. The commit from #19741seems to be also in this PR.

[abrinke1]

Of course, it could be merged on its own, skipping #19741. That's up to @davidlange6 et. al., I suppose. The PRs are split up for convenience in reviewing different commits, but they are all sequential.

[cmsbuild]

+1
Tested at: f8d0dd9
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19743/21471/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
2136e02
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19743/21471/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19743/21471/git-merge-result

[cmsbuild]

Comparison job queued.

[dmitrijus]

+1

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19743/21471/summary.html

Comparison Summary:

• No significant changes to the logs found
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 23
• DQMHistoTests: Total histograms compared: 2022761
• DQMHistoTests: Total failures: 14926
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2007669
• DQMHistoTests: Total skipped: 166
• DQMHistoTests: Total Missing objects: 0
• Checked 93 log files, 14 edm output root files, 23 DQM output files

[cmsbuild]

Pull request #19743 was updated. @vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @rekovic, @vanbesien, @mulhearn, @davidlange6 can you please check and sign again.

[abrinke1]

@davidlange6, @smuzaffar @rekovic Requested changes committed.

[davidlange6]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/21664/console Started: 2017/07/21 16:01

[cmsbuild]

Pull request #19743 was updated. @vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @rekovic, @vanbesien, @mulhearn, @davidlange6 can you please check and sign again.

[cmsbuild]

+1
Tested at: 33fd87f
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19743/21664/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
33fd87f
be34a0d
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19743/21664/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19743/21664/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19743/21664/summary.html

Comparison Summary:

• No significant changes to the logs found
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 23
• DQMHistoTests: Total histograms compared: 2347494
• DQMHistoTests: Total failures: 15085
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2332243
• DQMHistoTests: Total skipped: 166
• DQMHistoTests: Total Missing objects: 0
• Checked 93 log files, 14 edm output root files, 23 DQM output files

[rekovic]

+1

[davidlange6]

merge

[abrinke1]

Thanks, @davidlange6 !