Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First version of the DQMOffline for L1T Taus - 92x #20043

Merged
merged 17 commits into from Aug 11, 2017
Merged

First version of the DQMOffline for L1T Taus - 92x #20043

merged 17 commits into from Aug 11, 2017

Conversation

thomreis
Copy link
Contributor

@thomreis thomreis commented Aug 3, 2017

backport of #19441

davignon and others added 17 commits August 3, 2017 14:30
@davignon @thomreis
first version of L1Trigger Tau DQM
b984f44 
Conflicts:
	DQMOffline/L1Trigger/python/L1TriggerDqmOffline_cff.py
@davignon @thomreis
first version of L1Tau DQM - cleaning
0509750
@davignon @thomreis
first version of L1Tau DQM - cleaning2
6da2031
@davignon @thomreis
first version of L1Tau DQM - cleaning3
639b2ab
@davignon @thomreis
first version of L1Tau DQM - cleaning4
5d4d524
@davignon @thomreis
first version of L1Tau DQM - cleaning5
06fae8d
@davignon @thomreis
first version of L1Tau DQM - cleaning6
d92d921
@davignon @thomreis
first version of L1Tau DQM - cleaning7
b684403
@davignon @thomreis
first version of L1Tau DQM - cleaning8
f9bd222
@davignon @thomreis
Fixed missing products errors
4315b40
@davignon @thomreis
Cleaning up code following comments
cc83f84
@davignon @thomreis
Small fix to var type
05ad4db
@davignon @thomreis
Cleaned includes and removed some log messages
b521c72
@davignon @thomreis
Few fixes
b7378e7
@davignon @thomreis
Few fixes2
7b9f5df
@davignon @thomreis
Few fixes3
fa288c1
@thomreis
Merge branch 'CMSSW_9_2_X' of github.com:cms-sw/cmssw into l1ttau_dqm…
0774d01 
…_backport_92x

Conflicts:
	DQMOffline/L1Trigger/python/L1TriggerDqmOffline_SecondStep_cff.py
	DQMOffline/L1Trigger/python/L1TriggerDqmOffline_cff.py
	DQMOffline/L1Trigger/src/L1TEfficiencyHarvesting.cc
@cmsbuild cmsbuild added this to the CMSSW_9_2_X milestone Aug 3, 2017
@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 3, 2017 •
edited

A new Pull Request was created by @thomreis (Thomas Reis) for CMSSW_9_2_X.

It involves the following packages:

DQMOffline/L1Trigger

@vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @rekovic, @vanbesien, @mulhearn can you please review it and eventually sign? Thanks.
@kreczko, @rociovilar this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@thomreis
Copy link
Contributor Author

thomreis commented Aug 3, 2017 •
edited

In order to avoid a crash of the L1TMuon harvesting PR #20032 should be merged first.

@rekovic
Copy link
Contributor

rekovic commented Aug 4, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 4, 2017 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22087/console Started: 2017/08/04 11:34

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 4, 2017

+1
Tested at: 0774d01
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20043/22087/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
0774d01
95a3822
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20043/22087/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20043/22087/git-merge-result

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 4, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 4, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20043/22087/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 22
  • DQMHistoTests: Total histograms compared: 1791740
  • DQMHistoTests: Total failures: 29844
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1761730
  • DQMHistoTests: Total skipped: 166
  • DQMHistoTests: Total Missing objects: 0
  • Checked 90 log files, 14 edm output root files, 22 DQM output files

@rekovic
Copy link
Contributor

rekovic commented Aug 8, 2017

+1

@rekovic
Copy link
Contributor

rekovic commented Aug 8, 2017

@dmitrijus please sign

93x version of this has been merged since 8 days ago.

@rekovic
Copy link
Contributor

rekovic commented Aug 8, 2017

@davidlange6
Please, first merge #20032, before this PR is merged.

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 9, 2017

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_9_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit cc45ad3 into cms-sw:CMSSW_9_2_X Aug 11, 2017
@davidlange6 davidlange6 mentioned this pull request Aug 15, 2017
Merged
@rekovic rekovic mentioned this pull request Aug 15, 2017
Closed
@thomreis thomreis mentioned this pull request Aug 15, 2017
Merged
@thomreis thomreis deleted the l1ttau_dqm_backport_92x branch August 30, 2017 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport-ok comparison-available dqm-approved fully-signed l1-approved orp-approved tests-approved
Projects
None yet
Milestone
CMSSW_9_2_X
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@thomreis @cmsbuild @rekovic @dmitrijus @davidlange6 @davignon